| Commit message (Collapse) | Author | Age | Lines |
| |
|
| |
|
|
|
|
| |
No need for bullets here, nor margins above/below each label.
|
|
|
|
|
|
|
| |
Call newRequest directly rather than with an event to avoid resetting
all the layers that have been used and hence removing all the features.
Fixes mysociety/fixmystreet-commercial#1354
|
|
|
|
|
| |
Use carriageway layers for these instead of Tree layer as Tree layer was
not always appropriate.
|
|
|
|
|
| |
The live ans staging sites use different layers to set the correct ones
depending on whether is_live is true
|
|
|
|
|
| |
this is required so that any hiding of messages etc occurs when the
layer is hidden.
|
|
|
|
| |
Fixes mysociety/fixmystreet-commercial#1343
|
| |
|
|
|
|
|
|
| |
If a field has a maximum length set in the javascript validation then
add a maxlength attribute so the user doesn't have to wait till
submission to find out about it.
|
|
|
|
|
|
| |
Prevent people from using very long titles.
Fixes mysociety/fixmystreet-commercial#1344
|
|
|
|
|
| |
The tile URL includes a parameter for the client number which we were
not using so configure this based on live or staging.
|
|
|
|
|
| |
Layers that are always visible mean that we can end up with a count of 1
which means we don't re-display the pin
|
|
|
|
|
|
|
|
| |
The code to stop submission of an emergency category and the code to
stop submission of reports with no assets were conflicting. This makes
the emergency code take precedence over the asset code as there is no
point in telling the user they have not selected an asset and then
telling them to phone the council.
|
| |
|
|
|
|
|
| |
Prevent the user from making a report unless they have clicked on an
asset.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes mysociety/fixmystreet-commercial#1272
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Otherwise, e.g. going straight to /report/new when category groups
enabled may cause always visible layers to disappear because bodies
gets emptied.
|
| |
| |
| |
| | |
This gives us the "set up on load" functionality.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Shared margin rules for `.box-warning` and `.extra-category-questions`
in `_base.scss` and `_layout.scss` (where the margin can potentially
change based on the `$mappage-sidebar-padding` variable).
* Move the Sass rules for `.box-warning` further up `_base.scss` to be
next to `.extra-category-questions` since they’re both so similar.
* No need for `.full-width` on the `.extra-category-questions` div since
we were overriding the margin-top anyway.
* Remove the little triangle between the category select box and the
grey `.extra-category-questions` div, since the category questions
isn’t always presented immediately after the category select box.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Run immediately, not onready, so the category change listener is in
place; listen to a better event, removing need for a debouncer; don't
look up if empty category.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
When an expanded list item has a single image, it would previously float
to the right of the list item action buttons, which looked messy.
Now, the buttons clear below the floated image, just like the buttons in
the individual report page `.problem-header`.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Make the expandable list item’s expanded state look more like the
regular `.problem-header`, to more strongly imply that you don’t need
to visit the individual report page to read more.
Since expandable list items now *always* contain more information in
their expanded state, there’s no need for the `show_more` flag in the
templates.
Addresses part of the feedback in mysociety/fixmystreet-commercial#1304.
|
|
|
|
| |
The two functions were conflicting with one another.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, when update_pin was called, category change events were
fired: 1. if category wasn't blank, 2. if category groups were enabled,
and 3. if category groups were enabled, a group was selected, and a
category was not.
Now we sort out everything inside the category_groups setup function,
only triggering a change event once, at the end.
|
| |
| |
| |
| |
| | |
This is most noticeable with category groups, where changing the
parent would leave visible any asset/attribute questions.
|
| |
| |
| |
| |
| |
| | |
If you had one filter category selected, clicked the map (category
auto pre-selected), changed the category, and clicked the map again,
it would re-select the filter category, not the changed category.
|
|/ |
|
|
|
|
|
|
| |
This makes sure that we re-enable the report form if you select a non
OCC category after selecting PRoW, and also enables correct hiding and
displaying of the message.
|
| |
|
|
|
|
|
|
| |
just because fixmystreet.actions exists on a layer it does not mean the
found or not_found methods are there so check for them too. Otherwise we
don't fall back to the default actions as the JS errors.
|
|
|
|
| |
with others
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the Vector tiles layers which Alloy provided which don't require
and API key or paging. This code is still a bit work in progress as it
makes a few assumptions:
* the zoom level is hard coded
* adding assets to layers assumes things are not async when they are
* we are using itemId which is not the correct thing
This uses an event to notify that loading a request for a new set of
tiles has started and then uses counting to check we've fetched them all
and hence can get the layer to check for an asset.
It also uses start times to throw away requests for tiles in a previous
request if they come in after a new request has started.
This also doesn't have anything for putting labels on assets because
that information doesn't seem to be in the tiles.
A final point is that the tiles can contain multiple assets at the same
coőrdinates and we don't do anything about that at the moment so the
user will just get the last one added when they click.
This includes a dump of all the layers from alloy and then matches them
up to categories displayed on FixMyStreet
|
|
|
|
|
| |
Co-authored-by: Zarino Zappia <zarino@mysociety.org>
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
|
|
|
|
|
|
| |
The form may be brought in via JS, so we have to add an event to
something that will always be there (or alternatively set up when
pulled in, which was the old pre-duplicates.js behaviour).
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
If the pin is dragged, then category changed,
the pin will not be in the centre of the map.
|