| Commit message (Collapse) | Author | Age | Lines |
|
|
|
| |
Trees, street lights, traffic lights, grit bins and gullies
|
|
|
|
|
|
| |
This manually reconstructs the POST as there is no support for formData
in safari, plus our storage mechanism does not handle formData as it's
not a simple object.
|
|
|
|
|
| |
This adds the code for photo uploads from the regular update form to the
inspector form, and adds details to the documentation.
|
| |
|
| |
|
|
|
|
| |
The recaptcha used by fixmystreet.com uses a textarea.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
If a single filter item, that was in multiple groups, was selected,
then the entry in the last group was being selected in the category
dropdown when starting a new report. Make sure we check for a match
in the group first, the same behaviour as when there is an existing
category.
|
| | |
|
|/ |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
Co-authored-by: Dave Arter <davea@mysociety.org>
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
|
|
|
|
|
| |
If we create one category_meta_message for each category, removing when
not relevant, then duplicat suggestion showing leads to duplicate
messages because the layer is still relevant, just not visible, and so
the old layer message is not removed. Instead, repurpose the ID of any
existing category_meta_message, so there is only ever one in existence.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Co-Authored-By: Struan Donald <struan@exo.org.uk>
For https://github.com/mysociety/fixmystreet-commercial/issues/1808
|
|
|
|
|
| |
Mostly inherits from original Alloy code, with addition of a new format
as Alloy no longer returns a native geoJSON collection.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use Dropzone (the photo upload library) to shrink photos client-side
before uploading in the background and display thumbnails. For the
resized upload, Dropzone restores the original Exif data, including
orientation, so it can be correctly oriented server-side; for a
thumbnail, it orients the image itself for immediate display.
Recently, browsers have started honouring Exif orientation much more
widely (Chrome 81+ and Firefox 77+ both now do it by default). This
means the data Dropzone gets from a resize has already been oriented
according to the Exif orientation data. Then Dropzone either looks at
the orientation to correct for display (thumbnail), or adds back the
Exif orientation data (upload) – in both cases, this leads to a double
implementation of the orientation, and an incorrect display.
To fix this, if we detect we are on a modern browser, we do not try and
fix orientation ourself [1], and in all cases we do not add any Exif
data back in (we only strip it server-side anyway). Conversely, that
means on a non-modern browser, we always perform a manual orientation
because no Exif data will be being sent server-side.
Also includes a fix to the orientation code [2] which wouldn't be
noticed in thumbnail generation as they are square, but could be now we
may be orienting full size photos.
[1] https://gitlab.com/meno/dropzone/-/merge_requests/80
[2] https://gitlab.com/meno/dropzone/-/merge_requests/45
|
|
|
|
| |
In my Firefox on Windows, .jpeg files are not otherwise shown.
|
| |
|
|
|
|
|
| |
With the refactor to make sure asset message always uses the default, no
need for these specific config lines any more.
|
|
|
|
|
| |
Wherever asset_item_message is checked/used, make sure it does
the text replacement and falls back to the default.
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| | |
Make sure spans in navbar are legible at all times.
|
|/ |
|
|
|
|
| |
You need to install the @cypress/code-coverage package alongside cypress.
|
|\
| |
| |
| | |
'origin/issues/commercial/1835-geolocation-button-styling'
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The colour and text decoration of links inside `#front-main` can now
be customised via `$primary_link_*` Sass variables.
Text decoration is set in _base.scss (like global link text decoration)
while colour is handled in _layout.scss (which is where `#front-main` is
given its background colour, so likely also the time you’ll want to set
a contrasting colour for links inside it).
The colour variables are set to `null` by default, meaning that no
colour or rules for those links will be compiled, enabling the links to
inherit the global link colour style, which previously wasn’t possible.
The decoration variables are set to `underline` by default, because most
cobrands set their #front-main links to be the same colour as the
surrounding text, so adding an underline is a sensible default. You can
disable the underlines by setting `$primary_link_decoration: none` in
your cobrand’s _colours.scss file, as cheshireeast and oxfordshire do.
Fixes #3007.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Much less opinionated styling for #geolocate_link in core, which
means the link should look better, by default, for most cobrands.
(In particular, the link looks much better on cobrands with the more
modern style of white / off-white #front-main background, such as
highwaysengland, which was the cobrand that started off this work
to begin with.)
I’ve also reduced the specificity of the #geolocate_link rulesets
in both core and all the cobrands.
While this commit means that fewer cobrands need to override styles
on #geolocate_link, there are still 8 cobrands that have to define a
custom text colour for their #geolocate_link, because they both:
A) have a light coloured background for #front-main, and
B) want their #geolocate_link to be coloured like a normal link,
rather than inheriting the text colour of the parent element.
We might want to revisit this handling of #geolocate_link colouring and
the `#front-main a { color: inherit }` rule in _layout.scss at some
point in the future.
Fixes mysociety/fixmystreet-commercial#1835.
|
|/
|
|
|
|
|
|
|
|
| |
Resetting using the class could cause an incorrect "you can pick an
$item from the map" message to be display when asset_groups were being
used. This was happening when the unselect event was firing after the
category change event and then updating the new message using the
message from the unselected layer.
Fixes mysociety/fixmystreet-commercial#1888
|
|
|
|
| |
groups
|
| |
|
|
|
|
| |
Enforce asset selection, except for light-not-on-map category.
|
| |
|
|
|
|
|
|
| |
If you rename an Open311 category when it is not protected, it will only
get reinstated/deleted by the Open311 populate script shortly after, and
can cause issues due to the problem category renaming that occurs.
|
| |
|
|
|
|
|
|
| |
TLRN-only.
For https://github.com/mysociety/fixmystreet-commercial/issues/1883
|
|
|
|
| |
For https://github.com/mysociety/fixmystreet-commercial/issues/1880
|
|
|
|
|
| |
Not sure why this margin was even here. Appears to have been
present since the original FMS redesign in 2012.
|
|
|
|
| |
This reverts commit 724dde2244262d9a51ba55203a9f63c6e6a345f8.
|