| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| | |
|
| | |
|
| |
|
|
| |
Fixes mysociety/fixmystreet-commercial#1272
|
| |\ |
|
| | |
| |
| |
| |
| |
| | |
Otherwise, e.g. going straight to /report/new when category groups
enabled may cause always visible layers to disappear because bodies
gets emptied.
|
| | |
| |
| |
| | |
This gives us the "set up on load" functionality.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Shared margin rules for `.box-warning` and `.extra-category-questions`
in `_base.scss` and `_layout.scss` (where the margin can potentially
change based on the `$mappage-sidebar-padding` variable).
* Move the Sass rules for `.box-warning` further up `_base.scss` to be
next to `.extra-category-questions` since they’re both so similar.
* No need for `.full-width` on the `.extra-category-questions` div since
we were overriding the margin-top anyway.
* Remove the little triangle between the category select box and the
grey `.extra-category-questions` div, since the category questions
isn’t always presented immediately after the category select box.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Run immediately, not onready, so the category change listener is in
place; listen to a better event, removing need for a debouncer; don't
look up if empty category.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
When an expanded list item has a single image, it would previously float
to the right of the list item action buttons, which looked messy.
Now, the buttons clear below the floated image, just like the buttons in
the individual report page `.problem-header`.
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Make the expandable list item’s expanded state look more like the
regular `.problem-header`, to more strongly imply that you don’t need
to visit the individual report page to read more.
Since expandable list items now *always* contain more information in
their expanded state, there’s no need for the `show_more` flag in the
templates.
Addresses part of the feedback in mysociety/fixmystreet-commercial#1304.
|
| |
|
|
| |
The two functions were conflicting with one another.
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, when update_pin was called, category change events were
fired: 1. if category wasn't blank, 2. if category groups were enabled,
and 3. if category groups were enabled, a group was selected, and a
category was not.
Now we sort out everything inside the category_groups setup function,
only triggering a change event once, at the end.
|
| | |
| |
| |
| |
| | |
This is most noticeable with category groups, where changing the
parent would leave visible any asset/attribute questions.
|
| | |
| |
| |
| |
| |
| | |
If you had one filter category selected, clicked the map (category
auto pre-selected), changed the category, and clicked the map again,
it would re-select the filter category, not the changed category.
|
| |/ |
|
| |
|
|
|
|
| |
This makes sure that we re-enable the report form if you select a non
OCC category after selecting PRoW, and also enables correct hiding and
displaying of the message.
|
| | |
|
| |
|
|
|
|
| |
just because fixmystreet.actions exists on a layer it does not mean the
found or not_found methods are there so check for them too. Otherwise we
don't fall back to the default actions as the JS errors.
|
| |
|
|
| |
with others
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the Vector tiles layers which Alloy provided which don't require
and API key or paging. This code is still a bit work in progress as it
makes a few assumptions:
* the zoom level is hard coded
* adding assets to layers assumes things are not async when they are
* we are using itemId which is not the correct thing
This uses an event to notify that loading a request for a new set of
tiles has started and then uses counting to check we've fetched them all
and hence can get the layer to check for an asset.
It also uses start times to throw away requests for tiles in a previous
request if they come in after a new request has started.
This also doesn't have anything for putting labels on assets because
that information doesn't seem to be in the tiles.
A final point is that the tiles can contain multiple assets at the same
coőrdinates and we don't do anything about that at the moment so the
user will just get the last one added when they click.
This includes a dump of all the layers from alloy and then matches them
up to categories displayed on FixMyStreet
|
| |
|
|
|
| |
Co-authored-by: Zarino Zappia <zarino@mysociety.org>
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
|
| |
|
|
|
|
| |
The form may be brought in via JS, so we have to add an event to
something that will always be there (or alternatively set up when
pulled in, which was the old pre-duplicates.js behaviour).
|
| | |
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| | |
If the pin is dragged, then category changed,
the pin will not be in the centre of the map.
|
| |/
|
|
|
|
|
|
|
|
|
| |
Reduce the space between checkbox and label, so the text isn't lost if
the page is zoomed in. Fixes #2411.
Replace the creator_fixed question with segmented control to match the
full questionnaire, and the admin verified checkboxes with inline-text
as they need no padding. Having done that, all uses of .inline are now
on their own lines, so no post-padding is needed any longer, but we’ll
leave some in case of future use.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previously staff-only fixmystreet.set_up.manage_duplicates() has
been promoted from staff.js to its own file so that we can use it to
display the duplicate suggestions on the `/report/new` form.
render_duplicate_list (the old refresh_duplicate_list) no longer filters
or slices the reports_list returned by the ajax call, since it turns out
the server handles all of that (`sub _nearby_json` in `Report.pm` and
`sub nearby` in `Nearby.pm`).
Since the expandable list items include the "fancybox" image previews,
the fancybox CSS now has to be included in the `/report/new` page head,
hence the addition of "photo-js.html" in `fill_in_details.html`.
The “Get updates” flow reuses the same JavaScript that handles the
submission of the "Get updates" drawer at the bottom of around pages.
|
| | |
| |
| |
| |
| | |
There’s no need for this `--reports` to be there, so let’s start phasing
it out.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`_item_expandable.html` is an alternative to regular list items, where
you can display extra information on the first click on the item, and
then also, optionally, offer a further action, as a separate button.
Right now the expandable list items aren’t used anywhere, but we’ll
soon be using them in the duplicate report suggestion UI for council
staff and the public.
|
| | |
| |
| |
| |
| | |
Moving the 4em padding from _layout.scss to _base.scss helps separate
the content on /report/<id> and /report/new pages from the nav below.
|
| |/ |
|
| |
|
|
| |
Makes sure the logo looks nice on devices with high resolution.
|
| |
|
|
|
|
|
|
| |
The previous approach of filtering features that match one of many
values worked client side for e.g. GeoJSON format WFS layers, but crashed
when attemping to build the XML request for server-side feature filtering
(e.g. Bristol). This code instead builds a proper Logical filter which
OpenLayers can use in both situations.
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| | |
The behaviour should be the same whether “Show older” or “Show older
reports” is clicked, but only the latter was updating the URL.
|
| |\ \
| |/
|/| |
|
