| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| | |/ |
|
| |/
|
|
|
|
|
|
| |
If an inspector clicks on a report from an around page the code to setup
the pin dragging needs to be called. This adds a method to the map to
allow the setup code to be called on report load.
Fixes #2073
|
| |
|
|
|
|
|
| |
Asset layer visibility depends on fixmystreet.bodies, which is updated from
ajax request by pin selection or category change, but the visibility change
happens before the ajax request - so if visibility is not also checked when
category_extras returns it can get out of sync.
|
| |
|
|
|
|
|
|
| |
add a do_not_send parameter to reports which allows the front end to specify a
comma separated list of bodies that reports should not be sent to even if
there is a valid contact match. This enables asset layers to override backend
body processing, e.g. if a body only accepts reports that are on a road this
allows the front end to specify that.
|
| |
|
|
|
|
| |
is_only_body() checks if the supplied body is the only one listed in
fixmystreet.bodies and hence if it's the only one that reports for
the current pin position will be sent to.
|
| |
|
|
|
|
|
| |
Also add body name to layer defaults, so they are only used where appropriate.
Switch mapit area javascript calls to GeoJSON, so we can drop KML support in
OpenLayers.wfs.js which saves a small amount of bandwidth.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Return a list of associated bodies on around/new pages and in category ajax
calls, and use that when deciding whether to show/hide layers. If the layer
has no body information, then we show it as before, maybe based on category
selected; if it does, it is only shown if the layer body matches the bodies
for the point.
As part of this create a new VectorAsset class to handle all the visibility
changes for asset layers as it makes it a bit tidier.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2180.
Input placeholders are a generally problematic UI convention, and we’ve
accidentally started using them in more and more parts of FMS over the
last few years.
In some cases, the placeholders simply repeated text from the input’s
existing label element. In cases like those, the placeholder attribute
could just be removed.
In other cases, we broke the placeholder text out into a .form-hint
element, between the input and its label, so that the text is easily
accessible and falls into the top-to-bottom reading flow.
Notable changes:
* Form hint on main postcode search form, instead of placeholder.
* Form hint on alert search form, instead of placeholder.
* Form hints in reporting form (problem summary and description),
instead of placeholders.
* Removed placeholders from most login/password inputs.
* The character limit for "Inspector" report updates is no longer
displayed in the textarea placeholder.
* Form hints now `#666` grey, and better spaced when immediately
following a label element.
|
| |
|
|
| |
[fixmystreet.com] Update to use OS OpenMap Local tiles.
|
| |
|
|
|
|
|
| |
Add a checkbox to show older reports, plus if we get to the end of the new
reports then instead of a Next button show a "show older" button that will
reload the current page but with older reports also loaded. Wire it all up
into the pushState code as well.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Using `$('.pagination')` everywhere in javascript was causing issues
because that returns two elements. This was especially true when
triggering events as it was triggering two events so the data was being
loaded twice. This was also resulting in resetting the page to the
initial page so clicking the back button would always return to the
first page of results.
This also sets `use_page` when clicking the back button otherwise it
also loads the initial page.
|
| |
|
|
|
|
| |
When moving back through pushState history from a report page to a list
of reports the list of reports wasn't being displayed because code to
redisplay it wasn't called.
|
| |
|
|
| |
Styled to only be visible to staff.
|
| |
|
|
|
|
|
|
|
|
| |
This optional flag can be used for layers whose features should
set report extra fields when selected, without the features themselves
becoming highlighted and snapping the report pin to their location.
Useful for polygonal asset layers whose features cover a wide geographic
area where the actual location clicked by the user is important, e.g.
parks.
|
| |
|
|
| |
And there are entries in the defect type dropdown.
|
| |
|
|
|
| |
Categories could contain commas, so splitting on comma is not good enough.
Let’s escape the fields as if it’s a line in CSV. Fixes #2166.
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
| |
This was caused by the header overlapping the state banner
|
| | |
|
| |
|
|
|
| |
The fix in de36c49d1 broke pin clicking on other
map list pages, such as /my and /reports.
|
| |
|
|
|
|
| |
Dealing with the map UI changes earlier leads to a better display
position, and we add a global variable check to allow cobrands to
not use this behaviour. Fixes #1863.
|
| |
|
|
|
| |
The scroll position wa being remmbered, meaning
the full-page map was not being shown correctly.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On a mobile device that implements pointer events, there are two events that
can happen on an /around page – touching the map starts a new report (or goes
back to the map if already on a report page); touching a pin pulls in that
report’s page. The map touch, which uses an OpenLayers.Handler.Click, operates
on click, whereas the pin touch, which uses an OpenLayers.Handler.Feature,
operates on touchstart. Neither event cancels the other, which means you can
end up either starting a new report, and then it tries to pull in an undefined
pin ID report and errors, or the pin report loads and then you instantly go
back to the map page.
In order to work around this, we disable the map click control when the feature
control event starts, and reactivate once the report data has been loaded.
|
| | |
|
| |
|
|
|
|
| |
If a TfL road is clicked, but no asset selected, show a message that it might
not be a Bromley road and set single_body_only to TfL. Otherwise hide message
and set single_body_only to Bromley.
|
| |
|
|
|
| |
Adds street lights, park bins, trees, rights of way,
and TfL red route asset layers.
|
| | |
|
| | |
|
| |
|
|
|
| |
Otherwise a non-interactive layer applying to the same category
as an asset layer can cause an ‘undefined’ message to appear.
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Going back to /around from /report/new can trigger loadend (and the
spinner hiding function) twice (if the strategy activation starts a
read), with triggerRead aborting that read and triggering the event
itself. This means the spinner is not displayed, as the count falls
below 0. We could pin the count above 0, but instead let’s log each
layer ID while ‘active’ and switch off when they’re all gone.
|
| |/
|
|
|
|
| |
Editing a contact with extra fields would cause those fields to be
deleted because they weren't included in the POST request when saving.
This change ensures they're present in the DOM, but hidden by default.
|
| |\ |
|
| | | |
|
| | | |
|
| |/ |
|
| |\ |
|
| | |
| |
| |
| | |
Useful for simple tables like the cookie lists on Privacy Policy pages.
|
| | | |
|
| |/
|
|
|
|
| |
This fixes a bug whereby a double quote in an item would not be JSON-escaped
due to being HTML-escaped first, meaning it would not parse as JSON on the
client.
|
| |
|
|
| |
Fixes #2124.
|
| | |
|
