| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When this commit is finished, modern browsers will have a far less
buggy layout on .with-notes pages. The main improvements are:
1. Simplified padding on .with-notes columns, allowing us to link to
an individual column (eg: /inspect#side-report-secondary) without
the browser scrolling down to jump over the #map_sidebar padding on
desktop browsers. Making hash fragment scrolling work means we can
automatically scroll Inspectors down to the Inspect form, when they
click the Inspect button on mobile devices, without worrying about
it breaking the desktop experience.
2. Flexible .with-notes column widths, meaning the layout no longer
breaks when long sidebar content triggers a scrollbar and decreases
the usable width of the sidebar. A predefined width for #side-report
means we can make sure .shadow-wrap is the correct width, despite
its fixed position taking it out of the document flow.
We make a trade-off on mid-size screens (768-960px), of hiding the map
to keep the two-column sidebar usable. Will revisit if it turns out
this causes problems later on.
|
| | |
| |
| |
| |
| |
| | |
Inspectors can now tick the optional “Save with a public update”
checkbox, to reveal the “Public update” textarea. This means there is
no longer a need for two separate submit buttons.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Even though FMS has had a `.btn` class for a while, styling buttons has
still been difficult, mainly because of the very opinionated base styles
applied to overpowered selectors like `input[type="submit"]`.
This commit brings the FMS styles more in line with modern frameworks
like Bootstrap – inputs and buttons are left completely unstyled by
default, with an opt-in `.btn` class to add the styles back in.
Since `.btn` is just a single class, it’s easy to override, and avoids
selector bloat like `.green-btn, button.green-btn, input.green-btn`.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
IDs and locations at the top, then location-related actions (including
a new “navigate to this problem” button), then status and category
inputs (since these can have an effect on how we display the rest of
the form), then any status/category-related inputs, and finally inputs
for internal details like priority and traffic management.
|
| | |
| |
| |
| | |
Cope better if things aren't defined.
|
| | | |
|
| |/ |
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| | |
The report form is now split into "Public" and "Private" sections,
with a third, matching heading, for the category_extras, if shown.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Form input styling is mostly left up to the browser default now.
A custom border, drop-shadow, and border-radius can be applied by
adding the `.form-control` class, which standardizes the appearance
of inputs, selects, and textareas.
The core reporting form, authentication forms, local alert forms,
contact form, and questionnaire form have all been updated to use
the new `.form-control` class.
|
| | |
| |
| |
| |
| |
| | |
The ticks and crosses already imply that these are things you should
and shouldn’t do. Removing the headings reduces visual clutter, and
better associates the tips with the form input directly above.
|
| | |
| |
| |
| |
| | |
Switching between categories with / without extra questions no longer
results in nested `#category_meta` elements.
|
| |/
|
|
|
|
|
|
| |
As part of this, rename "planned reports" to "shortlist".
The `.segmented-control` component now supports basic usage (as in the
admin report actions menu bar) and usage with hidden radio inputs and
labels (as on the report questionnaire page).
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| | |
A very subtle nudge that you can/should upload multiple photos. With a
fallback to singular if Dropzone fails to load for some reason.
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Firefox would, on a page that pulled in a report via ajax, only
return the reporting form's name field with #form_name. Switch
to using a class on the relevant fields.
|
| | | |
|
| | |
| |
| |
| | |
Firefox still only scrolls precisely to the focus.
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
| |
This builds on the response templates in the Zürich cobrand:
- Allow response templates to be assigned to categories
- Also adds a auto_response flag, which will be used to automatically create
updates when reports are made.
- Include response templates select box on update form
For mysociety/fixmystreetforcouncils#31
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
- Harmonise two-column sidebar with .with-notes convention
`body.mappage.twocol` is now `body.mappage.with-actions` to make it
more obvious that it’s just a special case like `.with-notes`.
- Make sidebar padding-bottom work with floated children
- Display a.btn elements correctly in Safari
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Users with the `report_inspect` permission can click a new 'inspect' button on a
report page to input more detailed problem information into a new form that
appears in a column alongside the report detail.
- Inspector data is stored in problem's 'extra' field
- Report category/state can be edited
- Location can be changed by dragging the pin or HTML5 geolocation
(Factored out Zurich admin pin drag into own function)
For mysociety/fixmystreetforcouncils#22
|
| |
|
|
|
|
| |
If the form is submitted and reshown, due to an error or logging in, the
image preview is loaded from the server, rather than the client. We need
to get the image source data to get the Exif data out of it.
|
| |
|
|
|
|
|
|
| |
This refactors the moderation JS into a fixmystreet.set_up function, and
ensures the button handlers are attached when a new report is loaded
over AJAX. A side effect of bringing it into fixmystreet.js instead of
its own moderate.js file is the few extra kb each user will have to
download, but hopefully gzip and caching will help ameliorate this.
|
| |
|
|
|
|
| |
When the form is shown via JavaScript, we need the email box to start
off editable as it is if you hadn't used JavaScript, and we also need
the change() to be fired on the right field.
|
| | |
|
| |
|
|
|
| |
e.g. if a report is pulled in to the page via JavaScript, we need this
to run on the entry in the update form.
|
| |
|
|
|
|
| |
A user with the appropriate permission can add/remove reports from their
list of planned reports using a button on a report page. The list can be
viewed at /my/planned.
|
| |
|
|
| |
This makes sure the correct dropdown is shown.
|
| |
|
|
|
|
| |
The map JavaScript assumes that the permalink div already exists.
[Bristol] Make sure the control is added.
|
| |
|
|
|
| |
Remove unused code that is same as upstream (it was added when the map
middle didn't match the visible middle), and the world button.
|
| |
|
|
|
| |
No need to use old OpenLayers PanZoom defaults, or load images we don't
want to use.
|
| | |
|
| |
|
|
| |
This was originally fixed in c36a425b, but lost again in c87f28e.
|
| | |
|
| |
|
|
| |
Even though it is empty.
|
| |
|
|
| |
Prevent possible infinite loops during internal hashref change.
|
| | |
|
| | |
|
