From 0ae59f7314fe161245462b8cabba5d4e1988853f Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Tue, 6 Oct 2015 14:10:43 +0100 Subject: Improve item list CSS. Generally, a rewrite of issue-list-a to item-list--reports or item-list--wards (two different uses) and issue-list to item-list--updates, with subsequent renames/changes to children. For those cobrands using a different list showing a pin icon, use item-list__item--with-pin to stop needing to override existing classes. Fix a variety of niggling issues e.e ward list display, or overloading of the .text class. --- perllib/FixMyStreet/TestMech.pm | 4 +- templates/web/base/around/on_map_list_items.html | 2 +- templates/web/base/around/tabbed_lists.html | 2 +- templates/web/base/front/recent.html | 2 +- templates/web/base/my/_problem-list.html | 4 +- templates/web/base/my/my.html | 2 +- templates/web/base/report/_item.html | 4 +- templates/web/base/reports/_problem-list.html | 4 +- templates/web/bromley/front/_list-entry.html | 1 + templates/web/bromley/report/_item.html | 4 +- templates/web/fixamingata/front/recent.html | 2 +- .../web/fixmybarangay/around/tabbed_lists.html | 2 +- .../web/fixmybarangay/report/_message_manager.html | 2 +- .../report/_item-with-pin.html | 2 +- templates/web/fixmystreet/report/update.html | 10 +- templates/web/fixmystreet/reports/_ward-list.html | 10 +- templates/web/greenwich/front/_list-entry.html | 1 + templates/web/oxfordshire/front/_list-entry.html | 1 + templates/web/zerotb/around/on_map_list_items.html | 2 +- templates/web/zerotb/around/tabbed_lists.html | 2 +- templates/web/zerotb/report/_item.html | 4 +- templates/web/zurich/report/_item.html | 4 +- templates/web/zurich/report/updates.html | 6 +- templates/web/zurich/reports/index.html | 2 +- web/cobrands/bromley/base.scss | 4 + web/cobrands/bromley/layout.scss | 5 +- web/cobrands/eastsussex/base.scss | 10 +- web/cobrands/greenwich/base.scss | 2 +- web/cobrands/greenwich/layout.scss | 2 +- web/cobrands/hart/base.scss | 10 +- web/cobrands/hart/hart.scss | 2 +- web/cobrands/oxfordshire/layout.scss | 10 +- web/cobrands/sass/_base.scss | 161 +++++++++------------ web/cobrands/sass/_report_list_pins.scss | 104 +++++++------ web/cobrands/zurich/base.scss | 24 ++- web/js/moderate.js | 2 +- 36 files changed, 193 insertions(+), 222 deletions(-) create mode 100755 templates/web/bromley/front/_list-entry.html create mode 100755 templates/web/greenwich/front/_list-entry.html create mode 100755 templates/web/oxfordshire/front/_list-entry.html diff --git a/perllib/FixMyStreet/TestMech.pm b/perllib/FixMyStreet/TestMech.pm index 1035a47ba..cc5f9dd71 100644 --- a/perllib/FixMyStreet/TestMech.pm +++ b/perllib/FixMyStreet/TestMech.pm @@ -402,7 +402,7 @@ sub extract_update_metas { my $result = scraper { process 'div#updates div.problem-update p em', 'meta[]', 'TEXT'; - process '.update-text .meta-2', 'meta[]', 'TEXT'; + process '.item-list__update-text .meta-2', 'meta[]', 'TEXT'; } ->scrape( $mech->response ); @@ -423,7 +423,7 @@ sub extract_problem_list { my $mech = shift; my $result = scraper { - process 'ul.issue-list-a li a h4', 'problems[]', 'TEXT'; + process 'ul.item-list--reports li a h4', 'problems[]', 'TEXT'; }->scrape( $mech->response ); return $result->{ problems } || []; diff --git a/templates/web/base/around/on_map_list_items.html b/templates/web/base/around/on_map_list_items.html index 90f836fc8..b7257030d 100644 --- a/templates/web/base/around/on_map_list_items.html +++ b/templates/web/base/around/on_map_list_items.html @@ -8,7 +8,7 @@ [% INCLUDE 'reports/_list-entry.html' %] [% END %] [% ELSE %] -
  • +
  • [% loc('There are no reports to show.') %]

  • [% END %] diff --git a/templates/web/base/around/tabbed_lists.html b/templates/web/base/around/tabbed_lists.html index 2828027e2..b0d46444d 100755 --- a/templates/web/base/around/tabbed_lists.html +++ b/templates/web/base/around/tabbed_lists.html @@ -1,5 +1,5 @@ [% INCLUDE "reports/_list-filters.html" %] -