From 889bc287bbfc8eddacae4c19f573b6ea18fbfbac Mon Sep 17 00:00:00 2001 From: Tom Hukins Date: Tue, 9 Apr 2019 14:50:04 +0100 Subject: Avoid string eval Instead, load the required module directly. --- perllib/FixMyStreet/Roles/PhotoSet.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/perllib/FixMyStreet/Roles/PhotoSet.pm b/perllib/FixMyStreet/Roles/PhotoSet.pm index 2a6863cff..4a40ef3f9 100644 --- a/perllib/FixMyStreet/Roles/PhotoSet.pm +++ b/perllib/FixMyStreet/Roles/PhotoSet.pm @@ -19,9 +19,8 @@ Return a PhotoSet object for all photos attached to this field sub get_photoset { my ($self) = @_; - my $class = 'FixMyStreet::App::Model::PhotoSet'; - eval "use $class"; - return $class->new({ + require FixMyStreet::App::Model::PhotoSet; + return FixMyStreet::App::Model::PhotoSet->new({ db_data => $self->photo, object => $self, }); -- cgit v1.2.3