From 9eb0b8ba50ab3835023477f7a44fa9cd4d8c787c Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Mon, 21 May 2018 15:53:48 +0100 Subject: [Open311] Cope with undefined names. --- perllib/Open311.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/perllib/Open311.pm b/perllib/Open311.pm index dc40076db..a91de0a7c 100644 --- a/perllib/Open311.pm +++ b/perllib/Open311.pm @@ -132,7 +132,7 @@ sub _populate_service_request_params { description => $description, service_code => $service_code, first_name => $firstname, - last_name => $lastname || '', + last_name => $lastname, }; $params->{phone} = $problem->user->phone if $problem->user->phone; @@ -413,9 +413,11 @@ sub _populate_service_request_update_params { sub split_name { my ( $self, $name ) = @_; + return ('', '') unless $name; + my ( $first, $last ) = ( $name =~ /(\w+)(?:\.?\s+(.+))?/ ); - return ( $first, $last ); + return ( $first || '', $last || ''); } sub _params_to_string { -- cgit v1.2.3