From cadd35d4853974178a8a04ef7e93ec58f69607ee Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Fri, 23 Mar 2012 16:35:06 +0000 Subject: Needed brackets, dur (bugfix to de7a31da). --- perllib/Catalyst/Plugin/Session/State/Cookie.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'perllib/Catalyst/Plugin/Session/State/Cookie.pm') diff --git a/perllib/Catalyst/Plugin/Session/State/Cookie.pm b/perllib/Catalyst/Plugin/Session/State/Cookie.pm index 7c9f32878..ead8be38d 100644 --- a/perllib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/perllib/Catalyst/Plugin/Session/State/Cookie.pm @@ -51,7 +51,7 @@ sub cookie_is_rejecting { my ( $c, $cookie ) = @_; # Don't output cookie for JS files. mySociety addition - return 1 if substr $c->request->path, -3 eq '.js'; + return 1 if substr($c->request->path, -3) eq '.js'; if ( $cookie->{path} ) { return 1 if index '/'.$c->request->path, $cookie->{path}; -- cgit v1.2.3 From 57c1ba849c25b9397357f744df56895b250e7925 Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Fri, 30 Mar 2012 15:52:07 +0100 Subject: Also don't output cookie for JPEG files to prevent session loss. --- perllib/Catalyst/Plugin/Session/State/Cookie.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'perllib/Catalyst/Plugin/Session/State/Cookie.pm') diff --git a/perllib/Catalyst/Plugin/Session/State/Cookie.pm b/perllib/Catalyst/Plugin/Session/State/Cookie.pm index ead8be38d..c56206774 100644 --- a/perllib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/perllib/Catalyst/Plugin/Session/State/Cookie.pm @@ -50,8 +50,9 @@ sub update_session_cookie { sub cookie_is_rejecting { my ( $c, $cookie ) = @_; - # Don't output cookie for JS files. mySociety addition - return 1 if substr($c->request->path, -3) eq '.js'; + # Don't output cookie for JS or JPEG files. mySociety addition + return 1 if substr($c->request->path, -3) eq '.js' + || substr($c->request->Path, -5) eq '.jpeg'; if ( $cookie->{path} ) { return 1 if index '/'.$c->request->path, $cookie->{path}; -- cgit v1.2.3 From af344b3c0b25713da49fdc1a66014ab8cc6deac9 Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Fri, 30 Mar 2012 15:59:13 +0100 Subject: Typo. --- perllib/Catalyst/Plugin/Session/State/Cookie.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'perllib/Catalyst/Plugin/Session/State/Cookie.pm') diff --git a/perllib/Catalyst/Plugin/Session/State/Cookie.pm b/perllib/Catalyst/Plugin/Session/State/Cookie.pm index c56206774..e0a651ed9 100644 --- a/perllib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/perllib/Catalyst/Plugin/Session/State/Cookie.pm @@ -52,7 +52,7 @@ sub cookie_is_rejecting { # Don't output cookie for JS or JPEG files. mySociety addition return 1 if substr($c->request->path, -3) eq '.js' - || substr($c->request->Path, -5) eq '.jpeg'; + || substr($c->request->path, -5) eq '.jpeg'; if ( $cookie->{path} ) { return 1 if index '/'.$c->request->path, $cookie->{path}; -- cgit v1.2.3