From de7a31daaef62f2e89dfdae767e4061bfbbf576a Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Thu, 22 Mar 2012 19:04:29 +0000 Subject: Don't send cookie on JS files, as can cause session loss. --- perllib/Catalyst/Plugin/Session/State/Cookie.pm | 3 +++ 1 file changed, 3 insertions(+) (limited to 'perllib/Catalyst/Plugin') diff --git a/perllib/Catalyst/Plugin/Session/State/Cookie.pm b/perllib/Catalyst/Plugin/Session/State/Cookie.pm index c4b61123b..7c9f32878 100644 --- a/perllib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/perllib/Catalyst/Plugin/Session/State/Cookie.pm @@ -50,6 +50,9 @@ sub update_session_cookie { sub cookie_is_rejecting { my ( $c, $cookie ) = @_; + # Don't output cookie for JS files. mySociety addition + return 1 if substr $c->request->path, -3 eq '.js'; + if ( $cookie->{path} ) { return 1 if index '/'.$c->request->path, $cookie->{path}; } -- cgit v1.2.3 From cadd35d4853974178a8a04ef7e93ec58f69607ee Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Fri, 23 Mar 2012 16:35:06 +0000 Subject: Needed brackets, dur (bugfix to de7a31da). --- perllib/Catalyst/Plugin/Session/State/Cookie.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'perllib/Catalyst/Plugin') diff --git a/perllib/Catalyst/Plugin/Session/State/Cookie.pm b/perllib/Catalyst/Plugin/Session/State/Cookie.pm index 7c9f32878..ead8be38d 100644 --- a/perllib/Catalyst/Plugin/Session/State/Cookie.pm +++ b/perllib/Catalyst/Plugin/Session/State/Cookie.pm @@ -51,7 +51,7 @@ sub cookie_is_rejecting { my ( $c, $cookie ) = @_; # Don't output cookie for JS files. mySociety addition - return 1 if substr $c->request->path, -3 eq '.js'; + return 1 if substr($c->request->path, -3) eq '.js'; if ( $cookie->{path} ) { return 1 if index '/'.$c->request->path, $cookie->{path}; -- cgit v1.2.3