From 81c542caf4819268bb6b3cb5c1a445f8e5a10b04 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew@mysociety.org>
Date: Thu, 23 Jun 2011 12:23:46 +0100
Subject: Use update user centrally.

---
 perllib/FixMyStreet/App/Controller/Report.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'perllib/FixMyStreet/App/Controller/Report.pm')

diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index f732b94f1..6c14f33fb 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -60,9 +60,9 @@ sub load_problem_or_display_error : Private {
     my ( $self, $c, $id ) = @_;
 
     # try to load a report if the id is a number
-    my $problem    #
-      = $id =~ m{\D}    # is id non-numeric?
-      ? undef           # ...don't even search
+    my $problem
+      = ( !$id || $id =~ m{\D} ) # is id non-numeric?
+      ? undef                    # ...don't even search
       : $c->cobrand->problems->find( { id => $id } );
 
     # check that the problem is suitable to show.
-- 
cgit v1.2.3


From 98e23f576f1114d42f4b847e8bb57d090b19d633 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew@mysociety.org>
Date: Thu, 23 Jun 2011 12:26:18 +0100
Subject: Default to show name.

---
 perllib/FixMyStreet/App/Controller/Report.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'perllib/FixMyStreet/App/Controller/Report.pm')

diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index 6c14f33fb..b50325052 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -124,8 +124,8 @@ sub format_problem_for_display : Private {
         if ( $c->user ) {
             $c->stash->{form_name}     = $c->user->name;
             $c->stash->{email}         = $c->user->email;
-            $c->stash->{may_show_name} = ' checked' if $c->user->name;
         }
+        $c->stash->{may_show_name} = ' checked';
         $c->stash->{add_alert_checked} = ' checked';
     }
 
-- 
cgit v1.2.3


From ead78ff31d49cfeff2503f9faf793e0e53110cf6 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew@mysociety.org>
Date: Thu, 23 Jun 2011 13:33:02 +0100
Subject: Remove unneeded defaults checking and simplify.

---
 perllib/FixMyStreet/App/Controller/Report.pm | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

(limited to 'perllib/FixMyStreet/App/Controller/Report.pm')

diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index b50325052..a15ee993f 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -110,23 +110,8 @@ sub format_problem_for_display : Private {
 
     $c->stash->{report_name} = $c->req->param('name');
 
-    if ( $c->req->param('submit_update') ) {
-        # we may have munged these previously in /report/update 
-        # so only set if they're not already in the stash
-        $c->stash->{form_name}   ||= $c->req->param('name');
-        $c->stash->{update_text} ||= $c->req->param('update');
-        $c->stash->{email}       ||= $c->req->param('rznvy');
-        $c->stash->{fixed}       ||= $c->req->param('fixed') ? ' checked' : '';
-        $c->stash->{add_alert_checked} ||=
-          ( $c->req->param('add_alert') ? ' checked' : '' );
-    }
-    else {
-        if ( $c->user ) {
-            $c->stash->{form_name}     = $c->user->name;
-            $c->stash->{email}         = $c->user->email;
-        }
-        $c->stash->{may_show_name} = ' checked';
-        $c->stash->{add_alert_checked} = ' checked';
+    unless ( $c->req->param('submit_update') ) {
+        $c->stash->{add_alert} = 1;
     }
 
     $c->forward('generate_map_tags');
-- 
cgit v1.2.3