From bd9738d1e9cae14125d2e926bc7bfb87be186805 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew@mysociety.org>
Date: Wed, 21 Mar 2012 00:20:12 +0000
Subject: If questionnaire says report remains open, show that on report page.

---
 perllib/FixMyStreet/App/Controller/Report.pm | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

(limited to 'perllib/FixMyStreet/App/Controller/Report.pm')

diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index 59e3a4410..bb7c8dea0 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -51,7 +51,7 @@ sub display : Path('') : Args(1) {
         return $c->res->redirect( $c->uri_for($1), 301 );
     }
 
-    $c->forward('load_problem_or_display_error', [ $id ] );
+    $c->forward( 'load_problem_or_display_error', [ $id ] );
     $c->forward( 'load_updates' );
     $c->forward( 'format_problem_for_display' );
 }
@@ -88,7 +88,24 @@ sub load_updates : Private {
         { order_by => 'confirmed' }
     );
 
-    $c->stash->{updates} = $updates;
+    my $questionnaires = $c->model('DB::Questionnaire')->search(
+        {
+            problem_id => $c->stash->{problem}->id,
+            whenanswered => { '!=', undef },
+            old_state => 'confirmed', new_state => 'confirmed',
+        },
+        { order_by => 'whenanswered' }
+    );
+
+    my @combined;
+    while (my $update = $updates->next) {
+        push @combined, [ $update->{confirmed}, $update ];
+    }
+    while (my $update = $questionnaires->next) {
+        push @combined, [ $update->{whenanswered}, $update ];
+    }
+    @combined = map { $_->[1] } sort { $a->[0] <=> $b->[0] } @combined;
+    $c->stash->{updates} = \@combined;
 
     return 1;
 }
-- 
cgit v1.2.3


From f7c46612fd1ae32e738acfc084abb674d1c1487a Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew@mysociety.org>
Date: Wed, 21 Mar 2012 00:33:41 +0000
Subject: Use correct method names.

---
 perllib/FixMyStreet/App/Controller/Report.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'perllib/FixMyStreet/App/Controller/Report.pm')

diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index bb7c8dea0..afe180c29 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -99,10 +99,10 @@ sub load_updates : Private {
 
     my @combined;
     while (my $update = $updates->next) {
-        push @combined, [ $update->{confirmed}, $update ];
+        push @combined, [ $update->confirmed, $update ];
     }
     while (my $update = $questionnaires->next) {
-        push @combined, [ $update->{whenanswered}, $update ];
+        push @combined, [ $update->whenanswered, $update ];
     }
     @combined = map { $_->[1] } sort { $a->[0] <=> $b->[0] } @combined;
     $c->stash->{updates} = \@combined;
-- 
cgit v1.2.3