From 8d428f9c8fd9e25821560a20d00d444d9fb67e08 Mon Sep 17 00:00:00 2001 From: Matthew Somerville Date: Wed, 15 Jun 2016 12:43:54 +0100 Subject: Tidy up Open311 XML handling. Parse the XML in such a way other parts of the code do not have to worry about single-value folding or the like. --- perllib/Open311/GetServiceRequestUpdates.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'perllib/Open311/GetServiceRequestUpdates.pm') diff --git a/perllib/Open311/GetServiceRequestUpdates.pm b/perllib/Open311/GetServiceRequestUpdates.pm index daa5fb64d..921b2996d 100644 --- a/perllib/Open311/GetServiceRequestUpdates.pm +++ b/perllib/Open311/GetServiceRequestUpdates.pm @@ -122,8 +122,7 @@ sub update_comments { } ); - # ref test as XML::Simple will have returned an empty hashref for empty element - if ($request->{media_url} && !ref $request->{media_url}) { + if ($request->{media_url}) { my $ua = LWP::UserAgent->new; my $res = $ua->get($request->{media_url}); if ( $res->is_success && $res->content_type eq 'image/jpeg' ) { -- cgit v1.2.3