From d43dcaeccd714926c7dd9d00c554d16d179c21ab Mon Sep 17 00:00:00 2001
From: Struan Donald <struan@exo.org.uk>
Date: Fri, 19 Jul 2019 15:18:21 +0100
Subject: [open311] unset the external_status_code if blank

If an update with a blank external_status_code is fetched then unset it
otherwise we will always a detect a change in the external_status_code
which might mean phantom updates.
---
 perllib/Open311/GetServiceRequestUpdates.pm | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'perllib/Open311/GetServiceRequestUpdates.pm')

diff --git a/perllib/Open311/GetServiceRequestUpdates.pm b/perllib/Open311/GetServiceRequestUpdates.pm
index 7480ba258..2489bd611 100644
--- a/perllib/Open311/GetServiceRequestUpdates.pm
+++ b/perllib/Open311/GetServiceRequestUpdates.pm
@@ -181,6 +181,8 @@ sub process_update {
     if ( $external_status_code ) {
         $comment->set_extra_metadata(external_status_code => $external_status_code);
         $p->set_extra_metadata(external_status_code => $external_status_code);
+    } else {
+        $p->set_extra_metadata(external_status_code => '');
     }
 
     # if the customer reference to display in the report metadata is
-- 
cgit v1.2.3