From 020769f403ef4cf1880bd061b6db6b4f4028d3e4 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew-github@dracos.co.uk>
Date: Thu, 1 Dec 2016 18:23:54 +0000
Subject: Return 400/500 for some client/server errors.

---
 t/app/controller/moderate.t | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 't/app/controller/moderate.t')

diff --git a/t/app/controller/moderate.t b/t/app/controller/moderate.t
index 0ccfcf2c2..3a3c7a708 100644
--- a/t/app/controller/moderate.t
+++ b/t/app/controller/moderate.t
@@ -67,7 +67,8 @@ subtest 'Auth' => sub {
         $mech->get_ok($REPORT_URL);
         $mech->content_lacks('Moderat');
 
-        $mech->get_ok('/contact?m=1&id=' . $report->id);
+        $mech->get('/contact?m=1&id=' . $report->id);
+        is $mech->res->code, 400;
         $mech->content_lacks('Good bad bad bad');
     };
 
-- 
cgit v1.2.3


From 4ad523ad6a4950f91301e896b8f6a3d8e23afc06 Mon Sep 17 00:00:00 2001
From: Matthew Somerville <matthew-github@dracos.co.uk>
Date: Tue, 7 Mar 2017 16:46:38 +0000
Subject: Use name at time of moderation, include superusers

This works better if e.g. a user stops being associated with a body.
---
 t/app/controller/moderate.t | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

(limited to 't/app/controller/moderate.t')

diff --git a/t/app/controller/moderate.t b/t/app/controller/moderate.t
index 3a3c7a708..10287ab22 100644
--- a/t/app/controller/moderate.t
+++ b/t/app/controller/moderate.t
@@ -101,6 +101,7 @@ subtest 'Problem moderation' => sub {
             problem_detail => 'Good good improved',
         }});
         $mech->base_like( qr{\Q$REPORT_URL\E} );
+        $mech->content_like(qr/Moderated by Bromley Council/);
 
         $report->discard_changes;
         is $report->title, 'Good [...] good';
@@ -330,6 +331,23 @@ subtest 'Update 2' => sub {
     is $update2->text, 'update good good [...] good',
 };
 
+subtest 'Now stop being a staff user' => sub {
+    $user->update({ from_body => undef });
+    $mech->get_ok($REPORT_URL);
+    $mech->content_contains('Moderated by Bromley Council');
+};
+
+subtest 'And do it as a superuser' => sub {
+    $user->update({ is_superuser => 1 });
+    $mech->get_ok($REPORT_URL);
+    $mech->submit_form_ok({ with_fields => {
+        %problem_prepopulated,
+        problem_title  => 'Good good',
+        problem_detail => 'Good good improved',
+    }});
+    $mech->content_contains('Moderated by a FixMyStreet administrator');
+};
+
 $update->delete;
 $update2->delete;
 $report->moderation_original_data->delete;
-- 
cgit v1.2.3