From 7b2fb6cd9934fae59d89cfeabf5260a54713c26f Mon Sep 17 00:00:00 2001 From: Struan Donald Date: Wed, 15 Jun 2011 16:53:28 +0100 Subject: update report display to handle new statuses --- t/app/model/problem.t | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) (limited to 't/app/model/problem.t') diff --git a/t/app/model/problem.t b/t/app/model/problem.t index 1b8804fce..5a5eb2520 100644 --- a/t/app/model/problem.t +++ b/t/app/model/problem.t @@ -152,4 +152,48 @@ for my $test ( }; } +for my $test ( + { + state => 'unconfirmed', + is_open => 1, + }, + { + state => 'confirmed', + is_open => 1, + }, + { + state => 'investigating', + is_open => 1, + }, + { + state => 'planned', + is_open => 1, + }, + { + state => 'in progress', + is_open => 1, + }, + { + state => 'fixed', + is_open => 0, + }, + { + state => 'fixed - council', + is_open => 0, + }, + { + state => 'fixed - user', + is_open => 0, + }, + { + state => 'will not fix', + is_open => 0, + }, +) { + subtest $test->{state} . ' is open/closed' => sub { + $problem->state( $test->{state} ); + is $problem->is_open, $test->{is_open}, 'is_open'; + }; +} + done_testing(); -- cgit v1.2.3 From c9773705e4c611363474144f69182ad421187242 Mon Sep 17 00:00:00 2001 From: Struan Donald Date: Thu, 16 Jun 2011 12:17:35 +0100 Subject: handle new states in report display and updating --- t/app/model/problem.t | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) (limited to 't/app/model/problem.t') diff --git a/t/app/model/problem.t b/t/app/model/problem.t index 5a5eb2520..38ddc1857 100644 --- a/t/app/model/problem.t +++ b/t/app/model/problem.t @@ -196,4 +196,100 @@ for my $test ( }; } +for my $test ( + { + state => 'unconfirmed', + is_fixed => 0, + }, + { + state => 'confirmed', + is_fixed => 0, + }, + { + state => 'investigating', + is_fixed => 0, + }, + { + state => 'planned', + is_fixed => 0, + }, + { + state => 'in progress', + is_fixed => 0, + }, + { + state => 'fixed', + is_fixed => 1, + }, + { + state => 'fixed - council', + is_fixed => 1, + }, + { + state => 'fixed - user', + is_fixed => 1, + }, + { + state => 'will not fix', + is_fixed => 0, + }, +) { + subtest $test->{state} . ' is fixed/open' => sub { + $problem->state( $test->{state} ); + is $problem->is_fixed, $test->{is_fixed}, 'is_fixed'; + }; +} + +for my $test ( + { + state => 'partial', + is_visible => 0, + }, + { + state => 'hidden', + is_visible => 0, + }, + { + state => 'unconfirmed', + is_visible => 0, + }, + { + state => 'confirmed', + is_visible => 1, + }, + { + state => 'investigating', + is_visible => 1, + }, + { + state => 'planned', + is_visible => 1, + }, + { + state => 'in progress', + is_visible => 1, + }, + { + state => 'fixed', + is_visible => 1, + }, + { + state => 'fixed - council', + is_visible => 1, + }, + { + state => 'fixed - user', + is_visible => 1, + }, + { + state => 'will not fix', + is_visible => 1, + }, +) { + subtest $test->{state} . ' is fixed/open' => sub { + $problem->state( $test->{state} ); + is $problem->is_visible, $test->{is_visible}, 'is_visible'; + }; +} + done_testing(); -- cgit v1.2.3 From 4d40d4632325a999b66dee1db36841dfeb60bcda Mon Sep 17 00:00:00 2001 From: Struan Donald Date: Thu, 16 Jun 2011 12:40:39 +0100 Subject: rename will not fix to closed --- t/app/model/problem.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 't/app/model/problem.t') diff --git a/t/app/model/problem.t b/t/app/model/problem.t index 38ddc1857..43f15dbde 100644 --- a/t/app/model/problem.t +++ b/t/app/model/problem.t @@ -186,7 +186,7 @@ for my $test ( is_open => 0, }, { - state => 'will not fix', + state => 'closed', is_open => 0, }, ) { @@ -230,7 +230,7 @@ for my $test ( is_fixed => 1, }, { - state => 'will not fix', + state => 'closed', is_fixed => 0, }, ) { @@ -282,7 +282,7 @@ for my $test ( is_visible => 1, }, { - state => 'will not fix', + state => 'closed', is_visible => 1, }, ) { -- cgit v1.2.3 From 2f3388de9ee449080febabd47876620c82d56895 Mon Sep 17 00:00:00 2001 From: Struan Donald Date: Tue, 21 Jun 2011 17:53:08 +0100 Subject: unconfirmed is not really an open state --- t/app/model/problem.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 't/app/model/problem.t') diff --git a/t/app/model/problem.t b/t/app/model/problem.t index 43f15dbde..e7c9d79bb 100644 --- a/t/app/model/problem.t +++ b/t/app/model/problem.t @@ -155,7 +155,7 @@ for my $test ( for my $test ( { state => 'unconfirmed', - is_open => 1, + is_open => 0, }, { state => 'confirmed', -- cgit v1.2.3 From e907816b20bea99f7640f4ebb5e4ef1058fe0904 Mon Sep 17 00:00:00 2001 From: Struan Donald Date: Wed, 22 Jun 2011 18:06:49 +0100 Subject: is_closed utility method --- t/app/model/problem.t | 128 +++++++++++++++----------------------------------- 1 file changed, 38 insertions(+), 90 deletions(-) (limited to 't/app/model/problem.t') diff --git a/t/app/model/problem.t b/t/app/model/problem.t index e7c9d79bb..4c6be6a8d 100644 --- a/t/app/model/problem.t +++ b/t/app/model/problem.t @@ -152,143 +152,91 @@ for my $test ( }; } -for my $test ( - { - state => 'unconfirmed', - is_open => 0, - }, - { - state => 'confirmed', - is_open => 1, - }, - { - state => 'investigating', - is_open => 1, - }, - { - state => 'planned', - is_open => 1, - }, - { - state => 'in progress', - is_open => 1, - }, - { - state => 'fixed', - is_open => 0, - }, - { - state => 'fixed - council', - is_open => 0, - }, - { - state => 'fixed - user', - is_open => 0, - }, - { - state => 'closed', - is_open => 0, - }, -) { - subtest $test->{state} . ' is open/closed' => sub { - $problem->state( $test->{state} ); - is $problem->is_open, $test->{is_open}, 'is_open'; - }; -} - -for my $test ( - { - state => 'unconfirmed', - is_fixed => 0, - }, - { - state => 'confirmed', - is_fixed => 0, - }, - { - state => 'investigating', - is_fixed => 0, - }, - { - state => 'planned', - is_fixed => 0, - }, - { - state => 'in progress', - is_fixed => 0, - }, - { - state => 'fixed', - is_fixed => 1, - }, - { - state => 'fixed - council', - is_fixed => 1, - }, - { - state => 'fixed - user', - is_fixed => 1, - }, - { - state => 'closed', - is_fixed => 0, - }, -) { - subtest $test->{state} . ' is fixed/open' => sub { - $problem->state( $test->{state} ); - is $problem->is_fixed, $test->{is_fixed}, 'is_fixed'; - }; -} - for my $test ( { state => 'partial', - is_visible => 0, + is_visible => 0, + is_fixed => 0, + is_open => 0, + is_closed => 0, }, { state => 'hidden', is_visible => 0, + is_fixed => 0, + is_open => 0, + is_closed => 0, }, { state => 'unconfirmed', is_visible => 0, + is_fixed => 0, + is_open => 0, + is_closed => 0, }, { state => 'confirmed', is_visible => 1, + is_fixed => 0, + is_open => 1, + is_closed => 0, }, { state => 'investigating', is_visible => 1, + is_fixed => 0, + is_open => 1, + is_closed => 0, }, { state => 'planned', is_visible => 1, + is_fixed => 0, + is_open => 1, + is_closed => 0, }, { state => 'in progress', is_visible => 1, + is_fixed => 0, + is_open => 1, + is_closed => 0, }, { state => 'fixed', is_visible => 1, + is_fixed => 1, + is_open => 0, + is_closed => 0, }, { state => 'fixed - council', is_visible => 1, + is_fixed => 1, + is_open => 0, + is_closed => 0, }, { state => 'fixed - user', is_visible => 1, + is_fixed => 1, + is_open => 0, + is_closed => 0, }, { state => 'closed', is_visible => 1, + is_fixed => 0, + is_open => 0, + is_closed => 1, }, ) { - subtest $test->{state} . ' is fixed/open' => sub { + subtest $test->{state} . ' is fixed/open/closed/visible' => sub { $problem->state( $test->{state} ); is $problem->is_visible, $test->{is_visible}, 'is_visible'; + is $problem->is_fixed, $test->{is_fixed}, 'is_fixed'; + is $problem->is_closed, $test->{is_closed}, 'is_closed'; + is $problem->is_open, $test->{is_open}, 'is_open'; }; } -- cgit v1.2.3