1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
|
package Open311::PopulateServiceList;
use Moo;
use Open311;
has bodies => ( is => 'ro' );
has found_contacts => ( is => 'rw', default => sub { [] } );
has verbose => ( is => 'ro', default => 0 );
has schema => ( is => 'ro', lazy => 1, default => sub { FixMyStreet::DB->schema->connect } );
has _current_body => ( is => 'rw' );
has _current_open311 => ( is => 'rw' );
has _current_service => ( is => 'rw' );
sub process_bodies {
my $self = shift;
while ( my $body = $self->bodies->next ) {
next unless $body->endpoint;
next unless lc($body->send_method) eq 'open311';
$self->_current_body( $body );
$self->process_body;
}
}
sub process_body {
my $self = shift;
my $open311 = Open311->new(
endpoint => $self->_current_body->endpoint,
jurisdiction => $self->_current_body->jurisdiction,
api_key => $self->_current_body->api_key
);
$self->_current_open311( $open311 );
$self->_check_endpoints;
my $list = $open311->get_service_list;
unless ( $list && $list->{service} ) {
if ($self->verbose >= 1) {
my $id = $self->_current_body->id;
my $mapit_url = FixMyStreet->config('MAPIT_URL');
my $areas = join( ",", keys %{$self->_current_body->areas} );
warn "Body $id for areas $areas - $mapit_url/areas/$areas.html - did not return a service list\n";
warn $open311->error;
}
return;
}
$self->process_services( $list );
}
sub _check_endpoints {
my $self = shift;
# west berks end point not standard
if ( $self->_current_body->areas->{2619} ) {
$self->_current_open311->endpoints(
{
services => 'Services',
requests => 'Requests'
}
);
}
}
sub process_services {
my $self = shift;
my $list = shift;
$self->found_contacts( [] );
my $services = $list->{service};
foreach my $service ( @$services ) {
$self->_current_service( $service );
$self->process_service;
}
$self->_delete_contacts_not_in_service_list;
}
sub process_service {
my $self = shift;
my $service_name = $self->_normalize_service_name;
unless (defined $self->_current_service->{service_code}) {
warn "Service $service_name has no service code for body @{[$self->_current_body->id]}\n"
if $self->verbose >= 1;
return;
}
print $self->_current_service->{service_code} . ': ' . $service_name . "\n" if $self->verbose >= 2;
my $contacts = $self->schema->resultset('Contact')->search(
{
body_id => $self->_current_body->id,
-OR => [
email => $self->_current_service->{service_code},
category => $service_name,
]
}
);
if ( $contacts->count() > 1 ) {
printf(
"Multiple contacts for service code %s, category %s - Skipping\n",
$self->_current_service->{service_code},
$service_name,
);
# best to not mark them as deleted as we don't know what we're doing
while ( my $contact = $contacts->next ) {
push @{ $self->found_contacts }, $contact->email;
}
return;
}
my $contact = $contacts->first;
if ( $contact ) {
$self->_handle_existing_contact( $contact );
} else {
$self->_create_contact;
}
}
sub _handle_existing_contact {
my ( $self, $contact ) = @_;
my $service_name = $self->_normalize_service_name;
print $self->_current_body->id . " already has a contact for service code " . $self->_current_service->{service_code} . "\n" if $self->verbose >= 2;
if ( $contact->state eq 'deleted' || $service_name ne $contact->category || $self->_current_service->{service_code} ne $contact->email ) {
eval {
$contact->update(
{
category => $service_name,
email => $self->_current_service->{service_code},
state => 'confirmed',
editor => $0,
whenedited => \'current_timestamp',
note => 'automatically undeleted by script',
}
);
};
if ( $@ ) {
warn "Failed to update contact for service code " . $self->_current_service->{service_code} . " for body @{[$self->_current_body->id]}: $@\n"
if $self->verbose >= 1;
return;
}
}
my $metadata = $self->_current_service->{metadata} || '';
if ( $contact and lc($metadata) eq 'true' ) {
$self->_add_meta_to_contact( $contact );
} elsif ( $contact and $contact->extra and lc($metadata) eq 'false' ) {
$contact->set_extra_fields();
$contact->update;
}
if (my $group = $self->_current_service->{group}) {
$contact->set_extra_metadata(group => $group);
$contact->update;
}
push @{ $self->found_contacts }, $self->_current_service->{service_code};
}
sub _create_contact {
my $self = shift;
my $service_name = $self->_normalize_service_name;
my $contact;
eval {
$contact = $self->schema->resultset('Contact')->create(
{
email => $self->_current_service->{service_code},
body_id => $self->_current_body->id,
category => $service_name,
state => 'confirmed',
editor => $0,
whenedited => \'current_timestamp',
note => 'created automatically by script',
}
);
};
if (my $group = $self->_current_service->{group}) {
$contact->set_extra_metadata(group => $group);
$contact->update;
}
if ( $@ ) {
warn "Failed to create contact for service code " . $self->_current_service->{service_code} . " for body @{[$self->_current_body->id]}: $@\n"
if $self->verbose >= 1;
return;
}
my $metadata = $self->_current_service->{metadata} || '';
if ( $contact and lc($metadata) eq 'true' ) {
$self->_add_meta_to_contact( $contact );
}
if ( $contact ) {
push @{ $self->found_contacts }, $self->_current_service->{service_code};
print "created contact for service code " . $self->_current_service->{service_code} . " for body @{[$self->_current_body->id]}\n" if $self->verbose >= 2;
}
}
sub _add_meta_to_contact {
my ( $self, $contact ) = @_;
print "Fetching meta data for " . $self->_current_service->{service_code} . "\n" if $self->verbose >= 2;
my $meta_data = $self->_current_open311->get_service_meta_info( $self->_current_service->{service_code} );
unless (ref $meta_data->{attributes} eq 'ARRAY') {
warn sprintf( "Empty meta data for %s at %s",
$self->_current_service->{service_code},
$self->_current_body->endpoint )
# Bristol has a habit of returning empty metadata, stop noise from that.
if $self->verbose and $self->_current_body->name ne 'Bristol City Council';
return;
}
# turn the data into something a bit more friendly to use
my @meta =
# remove trailing colon as we add this when we display so we don't want 2
map { $_->{description} =~ s/:\s*//; $_ }
# there is a display order and we only want to sort once
sort { $a->{order} <=> $b->{order} }
@{ $meta_data->{attributes} };
# Some Open311 endpoints, such as Bromley and Warwickshire send <metadata>
# for attributes which we *don't* want to display to the user (e.g. as
# fields in "category_extras"
$self->_add_meta_to_contact_cobrand_overrides($contact, \@meta);
$contact->set_extra_fields(@meta);
$contact->update;
}
sub _add_meta_to_contact_cobrand_overrides {
my ( $self, $contact, $meta ) = @_;
if ($self->_current_body->name eq 'Bromley Council') {
$contact->set_extra_metadata( id_field => 'service_request_id_ext');
# Lights we want to store feature ID, PROW on all categories.
push @$meta, {
code => 'prow_reference',
datatype => 'string',
description => 'Right of way reference',
order => 101,
required => 'false',
variable => 'true',
automated => 'hidden_field',
};
push @$meta, {
code => 'feature_id',
datatype => 'string',
description => 'Feature ID',
order => 100,
required => 'false',
variable => 'true',
automated => 'hidden_field',
} if $self->_current_service->{service_code} eq 'LIGHTS';
} elsif ($self->_current_body->name eq 'Warwickshire County Council') {
$contact->set_extra_metadata( id_field => 'external_id');
}
my %override = (
#2482
'Bromley Council' => [qw(
requested_datetime
report_url
title
last_name
email
report_title
public_anonymity_required
email_alerts_requested
) ],
#2243,
'Warwickshire County Council' => [qw(
closest_address
) ],
);
if (my $override = $override{ $self->_current_body->name }) {
my %ignore = map { $_ => 1 } @{ $override };
@$meta = grep { ! $ignore{ $_->{ code } } } @$meta;
}
}
sub _normalize_service_name {
my $self = shift;
# FIXME - at the moment it makes more sense to use the description
# for cambridgeshire but need a more flexible way to set this
my $service_name = $self->_current_body->areas->{2218} ?
$self->_current_service->{description} :
$self->_current_service->{service_name};
# remove trailing whitespace as it upsets db queries
# to look up contact details when creating problem
$service_name =~ s/\s+$//;
return $service_name;
}
sub _delete_contacts_not_in_service_list {
my $self = shift;
my $found_contacts = $self->schema->resultset('Contact')->not_deleted->search(
{
email => { -not_in => $self->found_contacts },
body_id => $self->_current_body->id,
}
);
$found_contacts = $self->_delete_contacts_not_in_service_list_cobrand_overrides($found_contacts);
$found_contacts->update(
{
state => 'deleted',
editor => $0,
whenedited => \'current_timestamp',
note => 'automatically marked as deleted by script'
}
);
}
sub _delete_contacts_not_in_service_list_cobrand_overrides {
my ( $self, $found_contacts ) = @_;
# for Warwickshire/Bristol/BANES, which are mixed Open311 and email, don't delete
# the email addresses
if ($self->_current_body->name eq 'Warwickshire County Council' ||
$self->_current_body->name eq 'Bristol City Council' ||
$self->_current_body->name eq 'Bath and North East Somerset Council') {
$found_contacts = $found_contacts->search(
{
email => { -not_like => '%@%' }
}
);
} elsif ($self->_current_body->name eq 'East Hertfordshire District Council' ||
$self->_current_body->name eq 'Stevenage Borough Council') {
# For EHDC/Stevenage we need to leave the 'Other' category alone or reports made
# in this category will be sent only to Hertfordshire County Council.
$found_contacts = $found_contacts->search(
{
category => { '!=' => 'Other' }
}
);
}
return $found_contacts;
}
1;
|