1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
|
package Open311::UpdatesBase;
use Moo;
use Open311;
use Parallel::ForkManager;
use FixMyStreet::DB;
has send_comments_flag => ( is => 'ro' );
has system_user => ( is => 'rw' );
has body => ( is => 'ro', default => sub { undef } );
has verbose => ( is => 'ro', default => 0 );
has schema => ( is =>'ro', lazy => 1, default => sub { FixMyStreet::DB->schema->connect } );
has suppress_alerts => ( is => 'rw', default => 0 );
has blank_updates_permitted => ( is => 'rw', default => 0 );
has current_body => ( is => 'rw' );
has current_open311 => ( is => 'rwp', lazy => 1, builder => 1 );
has open311_config => ( is => 'ro' ); # If we need to pass in a devolved contact
Readonly::Scalar my $AREA_ID_OXFORDSHIRE => 2237;
sub fetch {
my ($self, $open311) = @_;
my $bodies = $self->schema->resultset('Body')->search(
{
send_method => 'Open311',
send_comments => $self->send_comments_flag,
comment_user_id => { '!=', undef },
endpoint => { '!=', '' },
}
);
if ( $self->body ) {
$bodies = $bodies->search( { name => $self->body } );
}
my $procs_min = FixMyStreet->config('FETCH_COMMENTS_PROCESSES_MIN') || 0;
my $procs_max = FixMyStreet->config('FETCH_COMMENTS_PROCESSES_MAX');
my $procs_timeout = FixMyStreet->config('FETCH_COMMENTS_PROCESS_TIMEOUT');
my $pm = Parallel::ForkManager->new(FixMyStreet->test_mode ? 0 : $procs_min);
if ($procs_max && $procs_timeout) {
my %workers;
$pm->run_on_wait(sub {
while (my ($pid, $started_at) = each %workers) {
next unless time() - $started_at > $procs_timeout;
next if $pm->max_procs == $procs_max;
$pm->set_max_procs($pm->max_procs + 1);
delete $workers{$pid}; # Only want to increase once per long-running thing
}
}, 1);
$pm->run_on_start(sub { my $pid = shift; $workers{$pid} = time(); });
$pm->run_on_finish(sub { my $pid = shift; delete $workers{$pid}; });
}
while ( my $body = $bodies->next ) {
$pm->start and next;
$self->current_body( $body );
$self->_set_current_open311( $open311 || $self->_build_current_open311 );
$self->suppress_alerts( $body->suppress_alerts );
$self->blank_updates_permitted( $body->blank_updates_permitted );
$self->system_user( $body->comment_user );
$self->process_body();
$pm->finish;
}
$pm->wait_all_children;
}
sub _build_current_open311 {
my $self = shift;
my $body = $self->current_body;
my $conf = $self->open311_config || $body;
my %open311_conf = (
endpoint => $conf->endpoint || '',
api_key => $conf->api_key || '',
jurisdiction => $conf->jurisdiction || '',
extended_statuses => $body->send_extended_statuses,
);
my $cobrand = $body->get_cobrand_handler;
$cobrand->call_hook(open311_config_updates => \%open311_conf)
if $cobrand;
return Open311->new(%open311_conf);
}
sub check_date {
my ($self, $request, @args) = @_;
my $comment_time = eval {
DateTime::Format::W3CDTF->parse_datetime( $request->{updated_datetime} || "" )
->set_time_zone(FixMyStreet->local_time_zone);
};
return if $@;
my $updated = DateTime::Format::W3CDTF->format_datetime($comment_time->clone->set_time_zone('UTC'));
return if @args && ($updated lt $args[0] || $updated gt $args[1]);
$request->{comment_time} = $comment_time;
return 1;
}
sub find_problem {
my ($self, $request, @args) = @_;
$self->check_date($request, @args) or return;
my $request_id = $request->{service_request_id};
# If there's no request id then we can't work out
# what problem it belongs to so just skip
return unless $request_id || $request->{fixmystreet_id};
my $criteria = {
external_id => $request_id,
};
# in some cases we only have the FMS id and not the request id so use that
if ( $request->{fixmystreet_id} ) {
unless ( $request->{fixmystreet_id} =~ /^\d+$/ ) {
warn "skipping bad fixmystreet id in updates for " . $self->current_body->name . ": [" . $request->{fixmystreet_id} . "], external id is $request_id\n";
return;
}
$criteria = {
id => $request->{fixmystreet_id},
};
}
return $self->_find_problem($criteria);
}
sub process_update {
my ($self, $request, $p) = @_;
my $open311 = $self->current_open311;
my $body = $self->current_body;
my $state = $open311->map_state( $request->{status} );
my $old_state = $p->state;
my $external_status_code = $request->{external_status_code} || '';
my $customer_reference = $request->{customer_reference} || '';
my $old_external_status_code = $p->get_extra_metadata('external_status_code') || '';
my $comment = $self->schema->resultset('Comment')->new(
{
problem => $p,
user => $self->system_user,
external_id => $request->{update_id},
text => $self->comment_text_for_request(
$request, $p, $state, $old_state,
$external_status_code, $old_external_status_code
),
confirmed => $request->{comment_time},
created => $request->{comment_time},
}
);
# Some Open311 services, e.g. Confirm via open311-adapter, provide
# a more fine-grained status code that we use within FMS for
# response templates.
if ( $external_status_code ) {
$comment->set_extra_metadata(external_status_code => $external_status_code);
$p->set_extra_metadata(external_status_code => $external_status_code);
} else {
$p->set_extra_metadata(external_status_code => '');
}
# if the customer reference to display in the report metadata is
# not the same as the external_id
if ( $customer_reference ) {
$p->set_extra_metadata( customer_reference => $customer_reference );
}
$open311->add_media($request->{media_url}, $comment)
if $request->{media_url};
# don't update state unless it's an allowed state
if ( FixMyStreet::DB::Result::Problem->visible_states()->{$state} &&
# For Oxfordshire, don't allow changes back to Open from other open states
!( $body->areas->{$AREA_ID_OXFORDSHIRE} && $state eq 'confirmed' && $p->is_open ) &&
# Don't let it change between the (same in the front end) fixed states
!( $p->is_fixed && FixMyStreet::DB::Result::Problem->fixed_states()->{$state} ) ) {
$comment->problem_state($state);
# we only want to update the problem state if that makes sense. We never want to unhide a problem.
# If the update is older than the last update then we also do not want to update the state. This
# is largely to avoid the situation where we miss some updates, make more updates and then catch
# the updates when we fetch the last 24 hours of updates. The exception to this is the first
# comment. This is to catch automated updates which happen faster than we get the external_id
# back from the endpoint and hence have an created time before the lastupdate.
if ( $p->is_visible && $p->state ne $state &&
( $comment->created >= $p->lastupdate || $p->comments->count == 0 ) ) {
$p->state($state);
}
}
# If nothing to show (no text, photo, or state change), don't show this update
$comment->state('hidden') unless $comment->text || $comment->photo
|| ($comment->problem_state && $state ne $old_state);
my $cobrand = $body->get_cobrand_handler;
$cobrand->call_hook(open311_get_update_munging => $comment)
if $cobrand;
# As comment->created has been looked at above, its time zone has been shifted
# to TIME_ZONE (if set). We therefore need to set it back to local before
# insertion. We also then need a clone, otherwise the setting of lastupdate
# will *also* reshift comment->created's time zone to TIME_ZONE.
my $created = $comment->created->set_time_zone(FixMyStreet->local_time_zone);
$p->lastupdate($created->clone);
$p->update;
$comment->insert();
if ( $self->suppress_alerts ) {
my @alerts = $self->schema->resultset('Alert')->search( {
alert_type => 'new_updates',
parameter => $p->id,
confirmed => 1,
user_id => $p->user->id,
} );
for my $alert (@alerts) {
my $alerts_sent = $self->schema->resultset('AlertSent')->find_or_create( {
alert_id => $alert->id,
parameter => $comment->id,
} );
}
}
return $comment;
}
sub comment_text_for_request {
my ($self, $request, $problem, $state, $old_state,
$ext_code, $old_ext_code) = @_;
# Response templates are only triggered if the state/external status has changed.
# And treat any fixed state as fixed.
my $state_changed = $state ne $old_state
&& !( $problem->is_fixed && FixMyStreet::DB::Result::Problem->fixed_states()->{$state} );
my $ext_code_changed = $ext_code ne $old_ext_code;
my $template;
if ($state_changed || $ext_code_changed) {
my $order;
my $state_params = {
'me.state' => $state
};
if ($ext_code) {
$state_params->{'me.external_status_code'} = $ext_code;
# make sure that empty string/nulls come last.
$order = { order_by => \"me.external_status_code DESC NULLS LAST" };
};
if (my $t = $problem->response_templates->search({
auto_response => 1,
-or => $state_params,
}, $order )->first) {
$template = $t->text;
}
}
my $desc = $request->{description} || '';
if ($desc && (!$template || $template !~ /\{\{description}}/)) {
return $desc;
}
if ($template) {
$template =~ s/\{\{description}}/$desc/;
return $template;
}
return "" if $self->blank_updates_permitted;
print STDERR "Couldn't determine update text for $request->{update_id} (report " . $problem->id . ")\n";
return "";
}
1;
|