1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
|
#!/usr/bin/perl
#
# Problems.pm:
# Various problem report database fetching related functions for FixMyStreet.
#
# Copyright (c) 2008 UK Citizens Online Democracy. All rights reserved.
# Email: matthew@mysociety.org; WWW: http://www.mysociety.org/
#
# $Id: Problems.pm,v 1.33 2010-01-20 11:09:45 matthew Exp $
#
package Problems;
use strict;
use Memcached;
use mySociety::DBHandle qw/dbh select_all/;
use mySociety::Locale;
use mySociety::Web qw/ent/;
use mySociety::MaPit;
my $site_restriction = '';
my $site_key = 0;
sub set_site_restriction {
my $q = shift;
my $site = $q->{site};
if ($site ne 'fixmystreet'){
my $cobrand = Page::get_cobrand($q);
my $cobrand_data = Cobrand::extra_data($cobrand, $q);
($site_restriction, $site_key) = Cobrand::site_restriction($cobrand, $cobrand_data);
} else {
$site_restriction = '';
$site_key = 0;
}
}
# Front page statistics
sub recent_fixed {
my $key = "recent_fixed:$site_key";
my $result = Memcached::get($key);
unless ($result) {
$result = dbh()->selectrow_array("select count(*) from problem
where state='fixed' and lastupdate>ms_current_timestamp()-'1 month'::interval
$site_restriction");
Memcached::set($key, $result, 3600);
}
return $result;
}
sub number_comments {
my $key = "number_comments:$site_key";
my $result = Memcached::get($key);
unless ($result) {
if ($site_restriction) {
$result = dbh()->selectrow_array("select count(*) from comment, problem
where comment.problem_id=problem.id and comment.state='confirmed'
$site_restriction");
} else {
$result = dbh()->selectrow_array("select count(*) from comment
where state='confirmed'");
}
Memcached::set($key, $result, 3600);
}
return $result;
}
sub recent_new {
my $interval = shift;
(my $key = $interval) =~ s/\s+//g;
$key = "recent_new:$site_key:$key";
my $result = Memcached::get($key);
unless ($result) {
$result = dbh()->selectrow_array("select count(*) from problem
where state in ('confirmed','fixed') and confirmed>ms_current_timestamp()-'$interval'::interval
$site_restriction");
Memcached::set($key, $result, 3600);
}
return $result;
}
# Front page recent lists
sub recent_photos {
my ($num, $e, $n, $dist) = @_;
my $probs;
if ($e) {
my $key = "recent_photos:$site_key:$num:$e:$n:$dist";
$probs = Memcached::get($key);
unless ($probs) {
$probs = select_all("select id, title
from problem_find_nearby(?, ?, ?) as nearby, problem
where nearby.problem_id = problem.id
and state in ('confirmed', 'fixed') and photo is not null
$site_restriction
order by confirmed desc limit $num", $e, $n, $dist);
Memcached::set($key, $probs, 3600);
}
} else {
my $key = "recent_photos:$site_key:$num";
$probs = Memcached::get($key);
unless ($probs) {
$probs = select_all("select id, title from problem
where state in ('confirmed', 'fixed') and photo is not null
$site_restriction
order by confirmed desc limit $num");
Memcached::set($key, $probs, 3600);
}
}
my $out = '';
foreach (@$probs) {
my $title = ent($_->{title});
$out .= '<a href="/report/' . $_->{id} .
'"><img border="0" height="100" src="/photo?tn=1;id=' . $_->{id} .
'" alt="' . $title . '" title="' . $title . '"></a>';
}
return $out;
}
sub recent {
my $key = "recent:$site_key";
my $result = Memcached::get($key);
unless ($result) {
$result = select_all("select id,title from problem
where state in ('confirmed', 'fixed')
$site_restriction
order by confirmed desc limit 5");
Memcached::set($key, $result, 3600);
}
return $result;
}
sub front_stats {
my ($q) = @_;
my $fixed = Problems::recent_fixed();
my $updates = Problems::number_comments();
my $new = Problems::recent_new('1 week');
(my $new_pretty = $new) =~ s/(?<=\d)(?=(?:\d\d\d)+$)/,/g;
my $new_text = sprintf(mySociety::Locale::nget('<big>%s</big> report in past week',
'<big>%s</big> reports in past week', $new), $new_pretty);
if ($q->{site} ne 'emptyhomes' && $new > $fixed) {
$new = Problems::recent_new('3 days');
($new_pretty = $new) =~ s/(?<=\d)(?=(?:\d\d\d)+$)/,/g;
$new_text = sprintf(mySociety::Locale::nget('<big>%s</big> report recently', '<big>%s</big> reports recently', $new), $new_pretty);
}
(my $fixed_pretty = $fixed) =~ s/(?<=\d)(?=(?:\d\d\d)+$)/,/g;
(my $updates_pretty = $updates) =~ s/(?<=\d)(?=(?:\d\d\d)+$)/,/g;
my $out = '';
$out .= $q->h2(_('FixMyStreet updates'));
my $lastmo = '';
if ($q->{site} ne 'emptyhomes'){
$lastmo = $q->div(sprintf(mySociety::Locale::nget("<big>%s</big> fixed in past month", "<big>%s</big> fixed in past month", $fixed), $fixed), $fixed_pretty);
}
$out .= $q->div({-id => 'front_stats'},
$q->div($new_text),
($q->{site} ne 'emptyhomes' ? $q->div(sprintf(mySociety::Locale::nget("<big>%s</big> fixed in past month", "<big>%s</big> fixed in past month", $fixed), $fixed_pretty)) : ''),
$q->div(sprintf(mySociety::Locale::nget("<big>%s</big> update on reports",
"<big>%s</big> updates on reports", $updates), $updates_pretty))
);
return $out;
}
# Problems around a location
sub around_map {
my ($min_e, $max_e, $min_n, $max_n, $interval, $limit) = @_;
my $limit_clause = '';
if ($limit) {
$limit_clause = " limit $limit";
}
mySociety::Locale::in_gb_locale { select_all(
"select id,title,easting,northing,state from problem
where state in ('confirmed', 'fixed')
and easting>=? and easting<? and northing>=? and northing<? " .
($interval ? " and ms_current_timestamp()-lastupdate < '$interval'::interval" : '') .
" $site_restriction
order by created desc
$limit_clause", $min_e, $max_e, $min_n, $max_n);
};
}
sub nearby {
my ($dist, $ids, $limit, $mid_e, $mid_n, $interval) = @_;
mySociety::Locale::in_gb_locale { select_all(
"select id, title, easting, northing, distance, state
from problem_find_nearby(?, ?, $dist) as nearby, problem
where nearby.problem_id = problem.id " .
($interval ? " and ms_current_timestamp()-lastupdate < '$interval'::interval" : '') .
" and state in ('confirmed', 'fixed')" . ($ids ? ' and id not in (' . $ids . ')' : '') . "
$site_restriction
order by distance, created desc limit $limit", $mid_e, $mid_n);
}
}
sub fixed_nearby {
my ($dist, $mid_e, $mid_n) = @_;
mySociety::Locale::in_gb_locale { select_all(
"select id, title, easting, northing, distance
from problem_find_nearby(?, ?, $dist) as nearby, problem
where nearby.problem_id = problem.id and state='fixed'
$site_restriction
order by lastupdate desc", $mid_e, $mid_n);
}
}
# Fetch an individual problem
sub fetch_problem {
my $id = shift;
dbh()->selectrow_hashref(
"select id, easting, northing, council, category, title, detail, photo,
used_map, name, anonymous, extract(epoch from confirmed) as time,
state, extract(epoch from whensent-confirmed) as whensent,
extract(epoch from ms_current_timestamp()-lastupdate) as duration,
service, cobrand, cobrand_data
from problem where id=? and state in ('confirmed','fixed', 'hidden')
$site_restriction", {}, $id
);
}
# API functions
sub problems_matching_criteria {
my ($criteria, @params) = @_;
my $problems = select_all(
"select id, title, council, category, detail, name, anonymous,
confirmed, whensent, service
from problem
$criteria
$site_restriction", @params);
my @councils;
foreach my $problem (@$problems){
if ($problem->{anonymous} == 1){
$problem->{name} = '';
}
if ($problem->{service} eq ''){
$problem->{service} = 'Web interface';
}
if ($problem->{council}) {
$problem->{council} =~ s/\|.*//g;
my @council_ids = split /,/, $problem->{council};
push(@councils, @council_ids);
$problem->{council} = \@council_ids;
}
}
my $areas_info = mySociety::MaPit::get_voting_areas_info(\@councils);
foreach my $problem (@$problems){
if ($problem->{council}) {
my @council_names = map { $areas_info->{$_}->{name}} @{$problem->{council}} ;
$problem->{council} = join(' and ', @council_names);
}
}
return $problems;
}
sub fixed_in_interval {
my ($start_date, $end_date) = @_;
my $criteria = "where state='fixed' and date_trunc('day',lastupdate)>=? and
date_trunc('day',lastupdate)<=?";
return problems_matching_criteria($criteria, $start_date, $end_date);
}
sub created_in_interval {
my ($start_date, $end_date) = @_;
my $criteria = "where state='confirmed' and date_trunc('day',created)>=? and
date_trunc('day',created)<=?";
return problems_matching_criteria($criteria, $start_date, $end_date);
}
=item data_sharing_notification_start
Returns the unix datetime when the T&Cs that explicitly allow for users' data to be displayed
on other sites.
=cut
sub data_sharing_notification_start {
return 1255392000;
}
# Report functions
=item council_problems WARD COUNCIL
Returns a list of problems for a summary page. If WARD or COUNCIL area ids are given,
will only return problems for that area. Uses any site restriction defined by the
cobrand.
=cut
sub council_problems {
my ($ward, $one_council) = @_;
my @params;
my $where_extra = '';
if ($ward) {
push @params, $ward;
$where_extra = "and areas like '%,'||?||',%'";
} elsif ($one_council) {
push @params, $one_council;
$where_extra = "and areas like '%,'||?||',%'";
}
my $problems = select_all(
"select id, title, detail, council, state, areas,
extract(epoch from ms_current_timestamp()-lastupdate) as duration,
extract(epoch from ms_current_timestamp()-confirmed) as age
from problem
where state in ('confirmed', 'fixed')
$where_extra
$site_restriction
order by id desc
", @params);
return $problems;
}
# Admin view functions
=item problem_search SEARCH
Returns all problems containing the search term in their name, email, title,
detail or council, or whose ID is the search term. Uses any site_restriction
defined by a cobrand.
=cut
sub problem_search {
my ($search) = @_;
my $search_n = 0;
$search_n = int($search) if $search =~ /^\d+$/;
my $problems = select_all("select id, council, category, title, name,
email, anonymous, cobrand, cobrand_data, created, confirmed, state, service, lastupdate,
whensent, send_questionnaire from problem where (id=? or email ilike
'%'||?||'%' or name ilike '%'||?||'%' or title ilike '%'||?||'%' or
detail ilike '%'||?||'%' or council like '%'||?||'%' or cobrand_data like '%'||?||'%')
$site_restriction
order by created", $search_n,
$search, $search, $search, $search, $search, $search);
return $problems;
}
=item update_search SEARCH
Returns all updates containing the search term in their name, email or text, or whose ID
is the search term. Uses any site_restriction defined by a cobrand.
=cut
sub update_search {
my ($search) = @_;
my $search_n = 0;
$search_n = int($search) if $search =~ /^\d+$/;
my $updates = select_all("select comment.*, problem.council from comment, problem where problem.id = comment.problem_id
and (comment.id=? or
problem_id=? or comment.email ilike '%'||?||'%' or comment.name ilike '%'||?||'%' or
comment.text ilike '%'||?||'%' or comment.cobrand_data ilike '%'||?||'%')
$site_restriction
order by created", $search_n, $search_n, $search, $search,
$search, $search);
return $updates;
}
=item update_counts
An array reference of updates grouped by state. Uses any site_restriction defined by a cobrand.
=cut
sub update_counts {
return dbh()->selectcol_arrayref("select comment.state, count(comment.*) as c from comment, problem
where problem.id = comment.problem_id
$site_restriction
group by comment.state", { Columns => [1,2] });
}
=item problem_counts
An array reference of problems grouped by state. Uses any site_restriction defined by a cobrand.
=cut
sub problem_counts {
return dbh()->selectcol_arrayref("select state, count(*) as c from problem
where id=id $site_restriction
group by state", { Columns => [1,2] });
}
=item
An array reference of alerts grouped by state (specific to the cobrand if there is one).
=cut
sub alert_counts {
my ($cobrand) = @_;
my $cobrand_clause = '';
if ($cobrand) {
$cobrand_clause = " where cobrand = '$cobrand'";
}
return dbh()->selectcol_arrayref("select confirmed, count(*) as c
from alert
$cobrand_clause
group by confirmed", { Columns => [1,2] });
}
=item questionnaire_counts
An array reference of questionnaires. Restricted to questionnaires related to
problems submitted through the cobrand if a cobrand is specified.
=cut
sub questionnaire_counts {
my ($cobrand) = @_;
my $cobrand_clause = '';
if ($cobrand) {
$cobrand_clause = " and cobrand = '$cobrand'";
}
my $questionnaires = dbh()->selectcol_arrayref("select (whenanswered is not null), count(questionnaire.*) as c
from questionnaire, problem
where problem.id = questionnaire.problem_id
$cobrand_clause
group by (whenanswered is not null)", { Columns => [1,2] });
return $questionnaires;
}
=item contact_counts COBRAND
An array reference of contacts. Restricted to contacts relevant to
the cobrand if a cobrand is specified.
=cut
sub contact_counts {
my ($cobrand) = @_;
my $contact_restriction = Cobrand::contact_restriction($cobrand);
my $contacts = dbh()->selectcol_arrayref("select confirmed, count(*) as c from contacts $contact_restriction group by confirmed", { Columns => [1,2] });
return $contacts;
}
=item admin_fetch_problem ID
Return an array reference of data relating to a problem, to be used in the admin interface.
Uses any site_restriction defined by a cobrand.
=cut
sub admin_fetch_problem {
my ($id) = @_;
my $problem = dbh()->selectall_arrayref("select * from problem
where id=?
$site_restriction", { Slice=>{} }, $id);
return $problem;
}
=item admin_fetch_update ID
Return an array reference of data relating to an update, to be used in the admin interface.
Uses any site_restriction defined by a cobrand.
=cut
sub admin_fetch_update {
my ($id) = @_;
my $update = dbh()->selectall_arrayref("select comment.*, problem.council from comment, problem
where comment.id=?
and problem.id = comment.problem_id
$site_restriction", { Slice=>{} }, $id);
return $update;
}
=item timeline_problems
Return a reference to an array of problems suitable for display in the admin timeline.
Uses any site_restriction defined by a cobrand.
=cut
sub timeline_problems {
my $problems = select_all("select state,id,name,email,title,council,category,service,cobrand,cobrand_data,
extract(epoch from created) as created,
extract(epoch from confirmed) as confirmed,
extract(epoch from whensent) as whensent
from problem where (created>=ms_current_timestamp()-'7 days'::interval
or confirmed>=ms_current_timestamp()-'7 days'::interval
or whensent>=ms_current_timestamp()-'7 days'::interval)
$site_restriction");
return $problems;
}
=item timeline_updates
Return a reference to an array of updates suitable for display in the admin timeline.
Uses any site_restriction defined by a cobrand.
=cut
sub timeline_updates {
my $updates = select_all("select comment.*,
extract(epoch from comment.created) as created,
problem.council
from comment, problem
where comment.problem_id = problem.id
and comment.state='confirmed'
and comment.created>=ms_current_timestamp()-'7 days'::interval
$site_restriction");
return $updates;
}
=item timeline_alerts COBRAND
Return a reference to an array of alerts suitable for display in the admin timeline. Restricted to
cobranded alerts if a cobrand is specified.
=cut
sub timeline_alerts {
my ($cobrand) = @_;
my $cobrand_clause = '';
if ($cobrand) {
$cobrand_clause = " and cobrand = '$cobrand'";
}
my $alerts = select_all("select *,
extract(epoch from whensubscribed) as whensubscribed
from alert where whensubscribed>=ms_current_timestamp()-'7 days'::interval
and confirmed=1
$cobrand_clause");
return $alerts;
}
=item timeline_deleted_alerts COBRAND
Return a reference to an array of deleted alerts suitable for display in the admin timeline. Restricted to
cobranded alerts if a cobrand is specified.
=cut
sub timeline_deleted_alerts {
my ($cobrand) = @_;
my $cobrand_clause = '';
if ($cobrand) {
$cobrand_clause = " and cobrand = '$cobrand'";
}
my $alerts = select_all("select *,
extract(epoch from whensubscribed) as whensubscribed,
extract(epoch from whendisabled) as whendisabled
from alert where whendisabled>=ms_current_timestamp()-'7 days'::interval
$cobrand_clause");
return $alerts;
}
=item timeline_questionnaires
Return a reference to an array of questionnaires suitable for display in the admin timeline. Restricted to
questionnaires for cobranded problems if a cobrand is specified.
=cut
sub timeline_questionnaires {
my ($cobrand) = @_;
my $cobrand_clause = '';
if ($cobrand) {
$cobrand_clause = " and cobrand = '$cobrand'";
}
my $questionnaire = select_all("select questionnaire.*,
extract(epoch from questionnaire.whensent) as whensent,
extract(epoch from questionnaire.whenanswered) as whenanswered
from questionnaire, problem
where questionnaire.problem_id = problem.id
and (questionnaire.whensent>=ms_current_timestamp()-'7 days'::interval
or questionnaire.whenanswered>=ms_current_timestamp()-'7 days'::interval)
$cobrand_clause");
}
1;
|