1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
|
#!/usr/bin/env perl
use strict;
use warnings;
use Test::More;
use FixMyStreet::App;
use FindBin;
use lib "$FindBin::Bin/../perllib";
use lib "$FindBin::Bin/../commonlib/perllib";
use_ok( 'Open311::PopulateServiceList' );
use_ok( 'Open311' );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
ok $processor, 'created object';
subtest 'check basic functionality' => sub {
FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->delete();
my $service_list = get_xml_simple_object( get_standard_xml() );
my $council = FixMyStreet::App->model('DB::Open311Conf')->new( {
area_id => 1
} );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
$processor->_current_council( $council );
$processor->process_services( $service_list );
my $contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->count();
is $contact_count, 3, 'correct number of contacts';
};
subtest 'check non open311 contacts marked as deleted' => sub {
FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->delete();
my $contact = FixMyStreet::App->model('DB::Contact')->create(
{
area_id => 1,
email => 'contact@example.com',
category => 'An old category',
confirmed => 1,
deleted => 0,
editor => $0,
whenedited => \'ms_current_timestamp()',
note => 'test contact',
}
);
my $service_list = get_xml_simple_object( get_standard_xml() );
my $council = FixMyStreet::App->model('DB::Open311Conf')->new( {
area_id => 1
} );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
$processor->_current_council( $council );
$processor->process_services( $service_list );
my $contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->count();
is $contact_count, 4, 'correct number of contacts';
$contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1, deleted => 1 } )->count();
is $contact_count, 1, 'correct number of deleted contacts';
};
subtest 'check email changed if matching category' => sub {
FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->delete();
my $contact = FixMyStreet::App->model('DB::Contact')->create(
{
area_id => 1,
email => '009',
category => 'Cans left out 24x7',
confirmed => 1,
deleted => 0,
editor => $0,
whenedited => \'ms_current_timestamp()',
note => 'test contact',
}
);
ok $contact, 'contact created';
my $service_list = get_xml_simple_object( get_standard_xml() );
my $council = FixMyStreet::App->model('DB::Open311Conf')->new( {
area_id => 1
} );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
$processor->_current_council( $council );
$processor->process_services( $service_list );
$contact->discard_changes;
is $contact->email, '001', 'email unchanged';
is $contact->confirmed, 1, 'contact still confirmed';
is $contact->deleted, 0, 'contact still not deleted';
my $contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->count();
is $contact_count, 3, 'correct number of contacts';
};
subtest 'check category name changed if updated' => sub {
FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->delete();
my $contact = FixMyStreet::App->model('DB::Contact')->create(
{
area_id => 1,
email => '001',
category => 'Bins left out 24x7',
confirmed => 1,
deleted => 0,
editor => $0,
whenedited => \'ms_current_timestamp()',
note => 'test contact',
}
);
ok $contact, 'contact created';
my $service_list = get_xml_simple_object( get_standard_xml() );
my $council = FixMyStreet::App->model('DB::Open311Conf')->new( {
area_id => 1
} );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
$processor->_current_council( $council );
$processor->process_services( $service_list );
$contact->discard_changes;
is $contact->email, '001', 'email unchanged';
is $contact->category, 'Cans left out 24x7', 'category changed';
is $contact->confirmed, 1, 'contact still confirmed';
is $contact->deleted, 0, 'contact still not deleted';
my $contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->count();
is $contact_count, 3, 'correct number of contacts';
};
subtest 'check conflicting contacts not changed' => sub {
FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->delete();
my $contact = FixMyStreet::App->model('DB::Contact')->create(
{
area_id => 1,
email => 'existing@example.com',
category => 'Cans left out 24x7',
confirmed => 1,
deleted => 0,
editor => $0,
whenedited => \'ms_current_timestamp()',
note => 'test contact',
}
);
ok $contact, 'contact created';
my $contact2 = FixMyStreet::App->model('DB::Contact')->create(
{
area_id => 1,
email => '001',
category => 'Bins left out 24x7',
confirmed => 1,
deleted => 0,
editor => $0,
whenedited => \'ms_current_timestamp()',
note => 'test contact',
}
);
ok $contact2, 'contact created';
my $service_list = get_xml_simple_object( get_standard_xml() );
my $council = FixMyStreet::App->model('DB::Open311Conf')->new( {
area_id => 1
} );
my $processor = Open311::PopulateServiceList->new( council_list => [] );
$processor->_current_council( $council );
$processor->process_services( $service_list );
$contact->discard_changes;
is $contact->email, 'existing@example.com', 'first contact email unchanged';
is $contact->category, 'Cans left out 24x7', 'first contact category unchanged';
is $contact->confirmed, 1, 'first contact contact still confirmed';
is $contact->deleted, 0, 'first contact contact still not deleted';
$contact2->discard_changes;
is $contact2->email, '001', 'second contact email unchanged';
is $contact2->category, 'Bins left out 24x7', 'second contact category unchanged';
is $contact2->confirmed, 1, 'second contact contact still confirmed';
is $contact2->deleted, 0, 'second contact contact still not deleted';
my $contact_count = FixMyStreet::App->model('DB::Contact')->search( { area_id => 1 } )->count();
is $contact_count, 4, 'correct number of contacts';
};
sub get_standard_xml {
return qq{<?xml version="1.0" encoding="utf-8"?>
<services>
<service>
<service_code>001</service_code>
<service_name>Cans left out 24x7</service_name>
<description>Garbage or recycling cans that have been left out for more than 24 hours after collection. Violators will be cited.</description>
<metadata>false</metadata>
<type>realtime</type>
<keywords>lorem, ipsum, dolor</keywords>
<group>sanitation</group>
</service>
<service>
<service_code>002</service_code>
<metadata>false</metadata>
<type>realtime</type>
<keywords>lorem, ipsum, dolor</keywords>
<group>street</group>
<service_name>Construction plate shifted</service_name>
<description>Metal construction plate covering the street or sidewalk has been moved.</description>
</service>
<service>
<service_code>003</service_code>
<metadata>false</metadata>
<type>realtime</type>
<keywords>lorem, ipsum, dolor</keywords>
<group>street</group>
<service_name>Curb or curb ramp defect</service_name>
<description>Sidewalk curb or ramp has problems such as cracking, missing pieces, holes, and/or chipped curb.</description>
</service>
</services>
};
}
sub get_xml_simple_object {
my $xml = shift;
my $simple = XML::Simple->new();
my $obj;
eval {
$obj = $simple->XMLin( $xml );
};
die $@ if $@;
return $obj;
}
done_testing();
|
