Improve calculation of PublicBody statistics columns

On PublicBody, we don't need to update info_requests_count
because that's already done with :counter_cache.  On the
other hand, info_requests_successful_count and
info_requests_not_held_count can't be updated easily with
counter_cache (since they need conditions to be attached).
Instead we update them in post_save and post_destroy,
as suggested here:

   http://blog.douglasfshearer.com/post/17495285851/custom-counter-cache-with-conditions

This also adds tests to ensure that the
after_(save|destroy) callbacks are called and that they
modify the counts correctly.

1 files changed, 1 insertions, 1 deletions

diff --git a/spec/controllers/public_body_controller_spec.rb b/spec/controllers/public_body_controller_spec.rb
index 000d1cf80..87544b96a 100644
--- a/spec/controllers/public_body_controller_spec.rb
+++ b/spec/controllers/public_body_controller_spec.rb
@@ -233,7 +233,7 @@ describe PublicBodyController, "when showing public body statistics" do
           graph['y_values'].should == [0, 50, 100, 100]
         end
         # Check that at least every confidence interval value is
-        # numeric:
+        # a Float (rather than NilClass, say):
         graph['cis_below'].each { |v| v.should be_instance_of(Float) }
         graph['cis_above'].each { |v| v.should be_instance_of(Float) }
       end