diff options
| -rw-r--r-- | app/models/exim_log.rb | 7 | ||||
| -rw-r--r-- | todo.txt | 8 |
2 files changed, 8 insertions, 7 deletions
diff --git a/app/models/exim_log.rb b/app/models/exim_log.rb index 98982954d..7b91ff9c6 100644 --- a/app/models/exim_log.rb +++ b/app/models/exim_log.rb @@ -18,7 +18,7 @@ # Copyright (c) 2009 UK Citizens Online Democracy. All rights reserved. # Email: francis@mysociety.org; WWW: http://www.mysociety.org/ # -# $Id: exim_log.rb,v 1.7 2009-03-09 01:17:06 francis Exp $ +# $Id: exim_log.rb,v 1.8 2009-03-09 12:46:05 francis Exp $ class EximLog < ActiveRecord::Base belongs_to :info_request @@ -77,6 +77,9 @@ class EximLog < ActiveRecord::Base # lines. Writes any errors to STDERR. This check is really mainly to # check the envelope from is the request address, as Ruby is quite # flaky with regard to that, and it is important for anti-spam reasons. + # XXX does this really check that, as the exim log just wouldn't pick + # up at all if the requests weren't sent that way as there would be + # no request- email in it? def EximLog.check_recent_requests_have_been_sent # Get all requests sent for a period of 24 hours, ending a day ago. # (the gap is because we load exim log lines via cron at best an hour @@ -97,7 +100,7 @@ class EximLog < ActiveRecord::Base raise "unexpected parsing of exim line" end - STDERR.puts "check_recent_requests_have_been_sent test: " + exim_log.line # debugging + #STDERR.puts "check_recent_requests_have_been_sent test: " + exim_log.line # debugging found = true end end @@ -2,11 +2,6 @@ Next (things that will reduce admin time mainly) ==== -check-recent-requests-sent works (mails "check_recent_requests_have_been_sent") -Write code to make sure the Return-Path is never foi@sandwich.org.uk (even if the - Rails code breaks for Sendmail case in future botched Rails upgrades :) - Maybe can use exim delivery log lines to do this? - Change text so that overdue covers qualified exemption of public interest test being valid reason for delay. @@ -42,6 +37,9 @@ http://www.openspf.org/SPF_Record_Syntax#include Point all MX records to one server, so can see incoming messages in exim logs also. Hmmm, but less robust. Run the exim log grabber across all mail servers? +check-recent-requests-sent probably doesn't work, as exim log lines wouldn't +be load in case where the envelope from gets broken? + Lots of authorities are starting to complain about how their record looks on their page - e.g responses not classified by users, the sort of icon there is for information not held etc. That users may classify incorrectly. We need |