aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--spec/controllers/request_controller_spec.rb11
-rw-r--r--todo.txt19
2 files changed, 14 insertions, 16 deletions
diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb
index 72abd89ae..a6dcd62e0 100644
--- a/spec/controllers/request_controller_spec.rb
+++ b/spec/controllers/request_controller_spec.rb
@@ -210,11 +210,18 @@ describe RequestController, "when creating a new request" do
end
-describe RequestController, "when viewing an individual response" do
+describe RequestController, "when viewing an individual response for reply/followup" do
integrate_views
fixtures :info_requests, :info_request_events, :public_bodies, :users, :incoming_messages, :outgoing_messages, :comments # all needed as integrating views
- it "should show the response" do
+ it "should ask for login if you are logged in as wrong person" do
+ session[:user_id] = users(:silly_name_user).id
+ get :show_response, :id => info_requests(:fancy_dog_request).id, :incoming_message_id => incoming_messages(:useless_incoming_message)
+ response.should render_template('user/wrong_user')
+ end
+
+ it "should show the response if you are logged in as right person" do
+ session[:user_id] = users(:bob_smith_user).id
get :show_response, :id => info_requests(:fancy_dog_request).id, :incoming_message_id => incoming_messages(:useless_incoming_message)
response.should render_template('show_response')
end
diff --git a/todo.txt b/todo.txt
index e4ce9290b..777a6936b 100644
--- a/todo.txt
+++ b/todo.txt
@@ -1,21 +1,16 @@
-Gah - fix caching regarding info_request that correspondence part belongs to
-Profile it!
-
Test data for Tony
-Check tracks still work with URL routing changes
-Check new comments are arriving in variety:comment/newest search first
-
-Check foi backup
-
Next
====
This doesn't work:
http://www.whatdotheyknow.com/search/status:waiting_classification/
-Maybe move "send followup" into actions?
- and make it so you can choose who to send followup to from dropdown
+Optimise so doesn't load raw_data in on every page
+Upload Julian's large Cambridgeshire contract
+
+Sort admin tag search by name rather than by modification date
+
Maybe make it so you need to log in to send follow up (i.e. before)
When forcing auth user for followups is a bit confusing/weird, does it really work?
Perhaps remove signout dialog and have signin instead?
@@ -51,10 +46,6 @@ When they say "successful", encourage them to make an annotation?
Clear out all the need admin attention requests
-"Excessive use of speed by Police vehicles." appears only once, even though multiple annotations.
-Perhaps show grouping count?
-http://www.whatdotheyknow.com/search/variety:comment/newest
-
CSS things
- CSS error on "all councils" page on some browsers
- Spacing on error boxes round form elements