diff options
| -rw-r--r-- | app/controllers/admin_public_body_controller.rb | 35 | ||||
| -rw-r--r-- | todo.txt | 18 |
2 files changed, 33 insertions, 20 deletions
diff --git a/app/controllers/admin_public_body_controller.rb b/app/controllers/admin_public_body_controller.rb index 4c7b63f24..071af1ee8 100644 --- a/app/controllers/admin_public_body_controller.rb +++ b/app/controllers/admin_public_body_controller.rb @@ -4,7 +4,7 @@ # Copyright (c) 2007 UK Citizens Online Democracy. All rights reserved. # Email: francis@mysociety.org; WWW: http://www.mysociety.org/ # -# $Id: admin_public_body_controller.rb,v 1.12 2008-04-14 12:09:38 francis Exp $ +# $Id: admin_public_body_controller.rb,v 1.13 2008-04-15 01:06:12 francis Exp $ class AdminPublicBodyController < ApplicationController layout "admin" @@ -68,24 +68,29 @@ class AdminPublicBodyController < ApplicationController def import_csv if params[:csv_file] - # Try with dry run first - csv_contents = params[:csv_file].read - en = PublicBody.import_csv(csv_contents, params[:tag], true) - errors = en[0] - notes = en[1] - - if errors.size == 0 - # And if OK, with real run - en = PublicBody.import_csv(csv_contents, params[:tag], false) + if not params[:tag].empty? + # Try with dry run first + csv_contents = params[:csv_file].read + en = PublicBody.import_csv(csv_contents, params[:tag], true) errors = en[0] notes = en[1] - if errors.size != 0 - raise "dry run mismatched real run" + + if errors.size == 0 + # And if OK, with real run + en = PublicBody.import_csv(csv_contents, params[:tag], false) + errors = en[0] + notes = en[1] + if errors.size != 0 + raise "dry run mismatched real run" + end + notes.push("Import was successful.") end - notes.push("Import was successful.") + @errors = errors.join("\n") + @notes = notes.join("\n") + else + @errors = "Please enter a tag, use a singular e.g. sea_fishery_committee" + @notes = "" end - @errors = errors.join("\n") - @notes = notes.join("\n") else @errors = "" @notes = "" @@ -30,6 +30,8 @@ BAILII - relationship with law courts, robots.txt ? Next ==== +Put user rather than import_csv + Link more clearly to full request and next/previous correspondence (ask Matthew) Perhaps always redirect to internal # links from the /response/ pages e.g. http://www.flickr.com/groups/central/discuss/72157604494352123/72157604515433851/ @@ -151,11 +153,6 @@ http://www.ico.gov.uk/Home/tools_and_resources/decision_notices.aspx (10:32:52) Matthew: their function is called autogrow_textarea() by the way, if you just want to look at it... thanks :) I won't do it now as there are more important things, I was just accidentally impressed -Read wiki page lots -http://www.mysociety.org/moin.cgi/FreedomOfInformation -And comments on proposal -http://www.mysociety.org/2006/04/04/freedom-of-information-archive/ - Hyperlink Section 1(3) to the act http://www.whatdotheyknow.com/request/49/response/86 and to guidance notes @@ -173,6 +170,8 @@ Including 'Request for information' in the subject line of your e-mail will assi http://www.parliament.uk/parliamentary_publications_and_archives/freedom_of_information_in_the_house_of_lords/lords__foi___how_to_obtain_information.cfm Medway also hint at this with subject= on mailto link +OCR all images automatically, even if badly (check for tiffs!) + Ask what they learnt from request, and other things? and reward by putting their request on front page @@ -194,6 +193,10 @@ http://community.foe.co.uk/tools/right_to_know/faq.html#why_specify Add geographical location to council import +Simple Digg style "I lke this request" button + +Editable user profile, including photo upload + Quoting fixing TODO: http://www.whatdotheyknow.com/request/64/response/102 http://www.whatdotheyknow.com/request/55/response/96 @@ -203,6 +206,8 @@ Quoting fixing TODO: http://www.whatdotheyknow.com/request/road_safety_campaign_expenditure http://www.whatdotheyknow.com/request/47/response/283 http://www.whatdotheyknow.com/request/secured_convictions_aided_by_cct + http://www.whatdotheyknow.com/request/m3_junction_2_eastbound_speed_re + http://www.whatdotheyknow.com/request/taxi_ranking Char encoding and other bad formatting: http://www.whatdotheyknow.com/request/107/response/144 http://www.whatdotheyknow.com/request/35/response/177 @@ -210,6 +215,9 @@ Char encoding and other bad formatting: Sources of public bodies ======================== +List of which get most requests: +http://www.dca.gov.uk/foi/reference/foi-independent-review.pdf + Call university of huddersfield Three lists of departments |