diff options
| -rw-r--r-- | spec/models/request_mailer_spec.rb | 103 |
1 files changed, 54 insertions, 49 deletions
diff --git a/spec/models/request_mailer_spec.rb b/spec/models/request_mailer_spec.rb index c0fb9c6b4..b9e845c1d 100644 --- a/spec/models/request_mailer_spec.rb +++ b/spec/models/request_mailer_spec.rb @@ -4,7 +4,7 @@ describe RequestMailer, " when receiving incoming mail" do fixtures :info_requests, :incoming_messages, :raw_emails, :users, :public_bodies it "should append it to the appropriate request" do - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.incoming_messages.size.should == 1 # in the fixture receive_incoming_mail('incoming-request-plain.email', ir.incoming_email) ir.incoming_messages.size.should == 2 # one more arrives @@ -14,12 +14,11 @@ describe RequestMailer, " when receiving incoming mail" do deliveries.size.should == 1 mail = deliveries[0] mail.to.should == [ 'bob@localhost' ] # to the user who sent fancy_dog_request - #STDERR.puts "=====" + mail.body + "======" deliveries.clear end - + it "should store mail in holding pen and send to admin when the email is not to any information request" do - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.incoming_messages.size.should == 1 InfoRequest.holding_pen_request.incoming_messages.size.should == 0 receive_incoming_mail('incoming-request-plain.email', 'dummy@localhost') @@ -35,7 +34,7 @@ describe RequestMailer, " when receiving incoming mail" do it "should return incoming mail to sender when a request is stopped fully for spam" do # mark request as anti-spam - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.allow_new_responses_from = 'nobody' ir.handle_rejected_responses = 'bounce' ir.save! @@ -54,7 +53,7 @@ describe RequestMailer, " when receiving incoming mail" do mail.multipart?.should == true mail.parts.size.should == 2 bounced_mail = TMail::Mail.parse(mail.parts[1].body) - bounced_mail.to.should == [ ir.incoming_email ] + bounced_mail.to.should == [ ir.incoming_email ] bounced_mail.from.should == [ 'geraldinequango@localhost' ] bounced_mail.body.include?("That's so totally a rubbish question") deliveries.clear @@ -62,7 +61,7 @@ describe RequestMailer, " when receiving incoming mail" do it "should return incoming mail to sender if not authority when a request is stopped for non-authority spam" do # mark request as anti-spam - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.allow_new_responses_from = 'authority_only' ir.handle_rejected_responses = 'bounce' ir.save! @@ -94,13 +93,13 @@ describe RequestMailer, " when receiving incoming mail" do it "should send all new responses to holding pen if a request is marked to do so" do # mark request as anti-spam - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.allow_new_responses_from = 'nobody' ir.handle_rejected_responses = 'holding_pen' ir.save! # test what happens if something arrives - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.incoming_messages.size.should == 1 InfoRequest.holding_pen_request.incoming_messages.size.should == 0 receive_incoming_mail('incoming-request-plain.email', ir.incoming_email) @@ -118,13 +117,13 @@ describe RequestMailer, " when receiving incoming mail" do it "should destroy the messages sent to a request if marked to do so" do ActionMailer::Base.deliveries.clear # mark request as anti-spam - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.allow_new_responses_from = 'nobody' ir.handle_rejected_responses = 'blackhole' ir.save! # test what happens if something arrives - should be nothing - ir = info_requests(:fancy_dog_request) + ir = info_requests(:fancy_dog_request) ir.incoming_messages.size.should == 1 InfoRequest.holding_pen_request.incoming_messages.size.should == 0 receive_incoming_mail('incoming-request-plain.email', ir.incoming_email) @@ -150,68 +149,74 @@ And a paragraph afterwards." end -describe RequestMailer, "when sending reminders to requesters to classify a response to their request" do +describe RequestMailer, "when sending reminders to requesters to classify a response to their request" do - before do + before do Time.stub!(:now).and_return(Time.utc(2007, 11, 12, 23, 59)) @mock_event = mock_model(InfoRequestEvent) @mock_response = mock_model(IncomingMessage) @mock_user = mock_model(User) @mock_request = mock_model(InfoRequest, :get_last_response_event_id => @mock_event.id, :get_last_response => @mock_response, - :user_id => 2, + :user_id => 2, :url_title => 'test_title', :user => @mock_user) InfoRequest.stub!(:find).and_return([@mock_request]) RequestMailer.stub!(:deliver_new_response_reminder_alert) + @sent_alert = mock_model(UserInfoRequestSentAlert, :user= =>nil, + :info_request= => nil, + :alert_type= => nil, + :info_request_event_id= => nil, + :save! => true) + UserInfoRequestSentAlert.stub!(:new).and_return(@sent_alert) end - + def send_alerts RequestMailer.alert_new_response_reminders_internal(7, 'new_response_reminder_1') end - - it 'should ask for all requests that are awaiting description and whose latest response is older than the number of days given and that are not the holding pen' do - expected_params = {:conditions => [ "awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen'", - true, Time.now() - 7.days ], - :include => [ :user ], + + it 'should ask for all requests that are awaiting description and whose latest response is older than the number of days given and that are not the holding pen' do + expected_params = {:conditions => [ "awaiting_description = ? and (select created_at from info_request_events where info_request_events.info_request_id = info_requests.id and info_request_events.event_type = 'response' order by created_at desc limit 1) < ? and url_title != 'holding_pen'", + true, Time.now() - 7.days ], + :include => [ :user ], :order => "info_requests.id"} InfoRequest.should_receive(:find).with(:all, expected_params).and_return([]) send_alerts end - - it 'should raise an error if a request does not have a last response event id' do + + it 'should raise an error if a request does not have a last response event id' do @mock_request.stub!(:get_last_response_event_id).and_return(nil) expected_message = "internal error, no last response while making alert new response reminder, request id #{@mock_request.id}" lambda{ send_alerts }.should raise_error(expected_message) end - - it 'should check to see if an alert matching the attributes of the one to be sent has already been sent' do - expected_params = {:conditions => [ "alert_type = ? and user_id = ? and info_request_id = ? and info_request_event_id = ?", + + it 'should check to see if an alert matching the attributes of the one to be sent has already been sent' do + expected_params = {:conditions => [ "alert_type = ? and user_id = ? and info_request_id = ? and info_request_event_id = ?", 'new_response_reminder_1', 2, @mock_request.id, @mock_event.id]} UserInfoRequestSentAlert.should_receive(:find).with(:first, expected_params) send_alerts end - - describe 'if an alert matching the attributes of the reminder to be sent has already been sent' do - - before do + + describe 'if an alert matching the attributes of the reminder to be sent has already been sent' do + + before do UserInfoRequestSentAlert.stub!(:find).and_return(mock_model(UserInfoRequestSentAlert)) end - - it 'should not send the reminder' do + + it 'should not send the reminder' do RequestMailer.should_not_receive(:deliver_new_response_reminder_alert) send_alerts end - + end - - describe 'if no alert matching the attributes of the reminder to be sent has already been sent' do - - before do + + describe 'if no alert matching the attributes of the reminder to be sent has already been sent' do + + before do UserInfoRequestSentAlert.stub!(:find).and_return(nil) end - - it 'should store the information that the reminder has been sent' do + + it 'should store the information that the reminder has been sent' do mock_sent_alert = mock_model(UserInfoRequestSentAlert) UserInfoRequestSentAlert.stub!(:new).and_return(mock_sent_alert) mock_sent_alert.should_receive(:info_request=).with(@mock_request) @@ -221,38 +226,38 @@ describe RequestMailer, "when sending reminders to requesters to classify a resp mock_sent_alert.should_receive(:save!) send_alerts end - - it 'should send the reminder' do + + it 'should send the reminder' do RequestMailer.should_receive(:deliver_new_response_reminder_alert) send_alerts end end - + end describe RequestMailer, 'when sending mail when someone has updated an old unclassified request' do - before do + before do @user = mock_model(User, :name_and_email => 'test name and email') @public_body = mock_model(PublicBody, :name => 'Test public body') @info_request = mock_model(InfoRequest, :user => @user, - :law_used_full => 'Freedom of Information', - :title => 'Test request', - :public_body => @public_body, + :law_used_full => 'Freedom of Information', + :title => 'Test request', + :public_body => @public_body, :display_status => 'Refused.', :url_title => 'test_request') - @mail = RequestMailer.create_old_unclassified_updated(@info_request) + @mail = RequestMailer.create_old_unclassified_updated(@info_request) end - it 'should have the subject "Someone has updated the status of your request"' do + it 'should have the subject "Someone has updated the status of your request"' do @mail.subject.should == 'Someone has updated the status of your request' end - it 'should tell them what status was picked' do + it 'should tell them what status was picked' do @mail.body.should match(/"refused."/) end - it 'should contain the request path' do + it 'should contain the request path' do @mail.body.should match(/request\/test_request/) end |