diff options
| -rw-r--r-- | spec/models/info_request_spec.rb | 15 | ||||
| -rw-r--r-- | todo.txt | 9 | ||||
| -rw-r--r-- | vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb | 2 |
3 files changed, 24 insertions, 2 deletions
diff --git a/spec/models/info_request_spec.rb b/spec/models/info_request_spec.rb index ab37ffc5b..9c1e32c60 100644 --- a/spec/models/info_request_spec.rb +++ b/spec/models/info_request_spec.rb @@ -1,7 +1,7 @@ require File.dirname(__FILE__) + '/../spec_helper' describe InfoRequest, " when emailing" do - fixtures :info_requests, :public_bodies, :users + fixtures :info_requests, :info_request_events, :public_bodies, :users before do @info_request = info_requests(:fancy_dog_request) @@ -61,6 +61,19 @@ describe InfoRequest, " when emailing" do found_info_request.should be_nil end + it "should cope with indexing after item is deleted" do + # check can just update index + info_request_events(:useless_incoming_message_event).save! + ActsAsXapian.update_index(false, true) + + # then delete it under it + info_request_events(:useless_incoming_message_event).save! + info_request_events(:useless_incoming_message_event).destroy + ActsAsXapian.update_index(false, true) + + # raise ActsAsXapian::ActsAsXapianJob.find(:all).to_yaml + end + end @@ -60,7 +60,13 @@ CSS / design things - Icon for internal_review - CSS error on "all councils" page on some browsers https://bugzilla.mozilla.org/show_bug.cgi?id=424194 - - Spacing on error boxes round form elements + - Spacing on error boxes round form elements. Matthew says: + Well, the correct thing to do is have the class="fieldWithErrors" on the + <p> containing the Summary: label and text input box, not have the + pointless <span> at all, and then it all looks perfect and as you'd + expect. But I had a look at the code and haven't got the slightest clue + how you'd do that, sorry, given it appears new.rhtml is printing the <p> + but some magic Ruby thing is printing the error span. - icons for "Things to do with this request" ? - Improve CSS on IE7 for large images in docs http://www.whatdotheyknow.com/request/3289/response/7810/attach/html/3/20081023ReplyLetter.pdf.html @@ -126,6 +132,7 @@ and display a better error? http://www.whatdotheyknow.com/request/childrens_database_compliance_wi#incoming-8088 http://www.whatdotheyknow.com/request/3326/response/7701/attach/html/2/Scan001.PDF.html http://www.whatdotheyknow.com/request/risk_log#incoming-8090 + http://www.whatdotheyknow.com/request/number_of_out_of_county_placemen_5#incoming-11248 Orientation wrong: http://www.whatdotheyknow.com/request/3153/response/7726/attach/html/2/258850.pdf.html Bug in wvHtml, segfaults when converting this: diff --git a/vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb b/vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb index 46d5f0965..9b801e42b 100644 --- a/vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb +++ b/vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb @@ -482,6 +482,8 @@ module ActsAsXapian # make sure that each index update is definitely saved to disk before # logging in the database that it has been. def ActsAsXapian.update_index(flush = false, verbose = false) + # STDOUT.puts("start of ActsAsXapian.update_index") if verbose + # Before calling writable_init we have to make sure every model class has been initialized. # i.e. has had its class code loaded, so acts_as_xapian has been called inside it, and # we have the info from acts_as_xapian. |