diff options
| -rw-r--r-- | app/helpers/link_to_helper.rb | 4 | ||||
| -rw-r--r-- | spec/controllers/request_controller_spec.rb | 1 | ||||
| -rw-r--r-- | todo.txt | 34 |
3 files changed, 23 insertions, 16 deletions
diff --git a/app/helpers/link_to_helper.rb b/app/helpers/link_to_helper.rb index 0a1a5b188..054bcbf3d 100644 --- a/app/helpers/link_to_helper.rb +++ b/app/helpers/link_to_helper.rb @@ -5,7 +5,7 @@ # Copyright (c) 2007 UK Citizens Online Democracy. All rights reserved. # Email: francis@mysociety.org; WWW: http://www.mysociety.org/ # -# $Id: link_to_helper.rb,v 1.4 2007-12-18 17:39:55 francis Exp $ +# $Id: link_to_helper.rb,v 1.5 2007-12-20 16:42:43 francis Exp $ module LinkToHelper @@ -24,7 +24,7 @@ module LinkToHelper return show_public_body_url(:simple_short_name => simplify_url_part(public_body.short_name), :only_path => true) end def public_body_link_short(public_body) - link_to h(public_body.short_name), public_body_url(public_body_url) + link_to h(public_body.short_name), public_body_url(public_body) end def public_body_link(public_body) link_to h(public_body.name), public_body_url(public_body) diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb index 40a50adac..a332686e2 100644 --- a/spec/controllers/request_controller_spec.rb +++ b/spec/controllers/request_controller_spec.rb @@ -24,6 +24,7 @@ describe RequestController, "when showing the front page" do end describe RequestController, "when listing all requests" do + integrate_views fixtures :info_requests it "should be successful" do @@ -1,25 +1,25 @@ -[12:11:25] … To Liverpool City Council: - -Please send me a copy of the contract signed with Veolia for refuse and recycling collection. - -"Fundamental Savings Review" +"Fundamental Savings Review" - Tom's friend +BAILII - relationship with law courts, robots.txt ? Next ==== -Admin doesn't have stylesheets -Admin links to main site don't work +Track bounce messages via a separate address + +Swap over the question as to if contains info to be on the left -Cope with bouncing requests +Formatting of emails + - don't show HTML and plain version, just show one + - do simple quotation folding + - date of bounce on http://foi.mysociety.org/request/4 is wrong Either rotate log files, or merge with Apache ones +Format user emails as well as request ones + Let requester send follow-ups Do something after 20 working days if you get no response -Forgotten password link -Remember me box - Work out how to get it to tell you code coverage of .rhtml files Make it validate the HTML maybe with http://www.anodyne.ca/wp-content/uploads/2007/09/be_valid_xhtml.rb @@ -28,9 +28,6 @@ Test that actually sending request outgoing mail using deliveries Remove "Outgoing messages is invalid" error -You need to pull the magic email addresses out of incoming_messages so they -aren't shown on the website - Some way of getting to your own user page Tidying @@ -83,8 +80,17 @@ Say that we would like response by email (not postal address) in footer Later ===== +About page +Contact page + +Remember me box + This can't possible be the best way, it is too depressing: + http://onrails.org/articles/2006/02/18/auto-login +Forgotten password link + Check these out for ids http://www.ico.gov.uk/Home/tools_and_resources/decision_notices.aspx +Screen scrape it and add it to the public body page (10:32:14) richard: you just need to count the number of rows of text and compare it to the number of rows in the textbox (10:32:29) richard: then increase the height of the textbox by 1em-ish |