1 files changed, 35 insertions, 52 deletions

diff --git a/spec/controllers/general_controller_spec.rb b/spec/controllers/general_controller_spec.rb
index 8c86ad0be..7590a5b42 100644
--- a/spec/controllers/general_controller_spec.rb
+++ b/spec/controllers/general_controller_spec.rb
@@ -42,6 +42,17 @@ describe GeneralController, 'when getting the blog feed' do
         assigns[:blog_items].count.should == 1
     end
 
+    context 'if no feed is configured' do
+
+        before do
+            AlaveteliConfiguration.stub!(:blog_feed).and_return('')
+        end
+
+        it 'should raise an ActiveRecord::RecordNotFound error' do
+            lambda{ get :blog }.should raise_error(ActiveRecord::RecordNotFound)
+        end
+    end
+
 end
 
 describe GeneralController, "when showing the frontpage" do
@@ -73,11 +84,10 @@ describe GeneralController, "when showing the frontpage" do
     end
 
     it "should render the front page with default language" do
-        old_default_locale = I18n.default_locale
-        I18n.default_locale = "es"
-        get :frontpage
-        response.should have_selector('html[lang="es"]')
-        I18n.default_locale = old_default_locale
+        with_default_locale("es") do
+            get :frontpage
+            response.should have_selector('html[lang="es"]')
+        end
     end
 
     it "should render the front page with default language and ignore the browser setting" do
@@ -85,11 +95,10 @@ describe GeneralController, "when showing the frontpage" do
         config['USE_DEFAULT_BROWSER_LANGUAGE'] = false
         accept_language = "en-GB,en-US;q=0.8,en;q=0.6"
         request.env['HTTP_ACCEPT_LANGUAGE'] = accept_language
-        old_default_locale = I18n.default_locale
-        I18n.default_locale = "es"
-        get :frontpage
-        response.should have_selector('html[lang="es"]')
-        I18n.default_locale = old_default_locale
+        with_default_locale("es") do
+            get :frontpage
+            response.should have_selector('html[lang="es"]')
+        end
     end
 
     it "should render the front page with browser-selected language when there's no default set" do
@@ -118,49 +127,7 @@ describe GeneralController, "when showing the frontpage" do
     end
 
 end
-describe GeneralController, "when showing the front page with fixture data" do
-
-    describe 'when constructing the list of recent requests' do
 
-        before(:each) do
-            get_fixtures_xapian_index
-        end
-
-        describe 'when there are fewer than five successful requests' do
-
-            it 'should list the most recently sent and successful requests by the creation date of the
-                request event' do
-                # Make sure the newest response is listed first even if a request
-                # with an older response has a newer comment or was reclassified more recently:
-                # https://github.com/mysociety/alaveteli/issues/370
-                #
-                # This is a deliberate behaviour change, in that the
-                # previous behaviour (showing more-recently-reclassified
-                # requests first) was intentional.
-                get :frontpage
-
-                request_events = assigns[:request_events]
-                previous = nil
-                request_events.each do |event|
-                    if previous
-                        previous.created_at.should be >= event.created_at
-                    end
-                    ['sent', 'response'].include?(event.event_type).should be_true
-                    if event.event_type == 'response'
-                        ['successful', 'partially_successful'].include?(event.calculated_state).should be_true
-                    end
-                    previous = event
-                end
-            end
-        end
-
-        it 'should coalesce duplicate requests' do
-            get :frontpage
-            assigns[:request_events].map(&:info_request).select{|x|x.url_title =~ /^spam/}.length.should == 1
-        end
-    end
-
-end
 
 describe GeneralController, 'when using xapian search' do
 
@@ -219,6 +186,17 @@ describe GeneralController, 'when using xapian search' do
         assigns[:xapian_bodies].should == nil
     end
 
+    it 'should highlight words for a user-only request' do
+      get :search, :combined => "bob/users"
+      assigns[:highlight_words].should == ['bob']
+    end
+
+    it 'should show spelling corrections for a user-only request' do
+      get :search, :combined => "rob/users"
+      assigns[:spelling_correction].should == 'bob'
+      response.body.should include('did_you_mean')
+    end
+
     it "should filter results based on end of URL being 'requests'" do
         get :search, :combined => "bob/requests"
         assigns[:xapian_requests].results.map{|x|x[:model]}.should =~ [
@@ -238,6 +216,11 @@ describe GeneralController, 'when using xapian search' do
         assigns[:xapian_bodies].results.map{|x|x[:model]}.should == [public_bodies(:geraldine_public_body)]
     end
 
+    it 'should show "Browse all" link if there are no results for a search restricted to bodies' do
+        get :search, :combined => "noresultsshouldbefound/bodies"
+        response.body.should include('Browse all')
+    end
+
     it "should show help when searching for nothing" do
         get :search_redirect, :query => nil
         response.should render_template('search')