diff options
Diffstat (limited to 'spec/models')
| -rw-r--r-- | spec/models/incoming_message_spec.rb | 29 | ||||
| -rw-r--r-- | spec/models/info_request_event_spec.rb | 3 |
2 files changed, 30 insertions, 2 deletions
diff --git a/spec/models/incoming_message_spec.rb b/spec/models/incoming_message_spec.rb index 10bb3de62..8fb57e36c 100644 --- a/spec/models/incoming_message_spec.rb +++ b/spec/models/incoming_message_spec.rb @@ -503,6 +503,20 @@ end describe IncomingMessage, " when uudecoding bad messages" do + it "decodes a valid uuencoded attachment" do + mail = get_fixture_mail('simple-uuencoded-attachment.email') + im = incoming_messages(:useless_incoming_message) + im.stub!(:mail).and_return(mail) + im.extract_attachments! + + im.reload + attachments = im.foi_attachments + attachments.size.should == 2 + attachments[1].filename.should == 'Happy.txt' + attachments[1].body.should == "Happy today for to be one of peace and serene time.\n" + im.get_attachments_for_display.size.should == 1 + end + it "should be able to do it at all" do mail = get_fixture_mail('incoming-request-bad-uuencoding.email') im = incoming_messages(:useless_incoming_message) @@ -516,6 +530,21 @@ describe IncomingMessage, " when uudecoding bad messages" do im.get_attachments_for_display.size.should == 1 end + it "decodes an attachment where the uudecode program reports a 'No end line' error" do + # See https://github.com/mysociety/alaveteli/issues/2508 + mail = get_fixture_mail('incoming-request-bad-uuencoding-2.email') + im = incoming_messages(:useless_incoming_message) + im.stub!(:mail).and_return(mail) + im.extract_attachments! + + im.reload + attachments = im.foi_attachments + attachments.size.should == 2 + attachments[1].filename.should == 'ResponseT5741 15.doc' + attachments[1].display_size.should == '123K' + im.get_attachments_for_display.size.should == 1 + end + it "should still work when parsed from the raw email" do raw_email = load_file_fixture 'inline-uuencode.email' mail = MailHandler.mail_from_raw_email(raw_email) diff --git a/spec/models/info_request_event_spec.rb b/spec/models/info_request_event_spec.rb index ff20ab059..17c6a5004 100644 --- a/spec/models/info_request_event_spec.rb +++ b/spec/models/info_request_event_spec.rb @@ -111,8 +111,7 @@ describe InfoRequestEvent do describe "should know" do it "that it's an incoming message" do - event = InfoRequestEvent.new - event.stub!(:incoming_message_selective_columns).and_return(1) + event = InfoRequestEvent.new(:incoming_message => mock_model(IncomingMessage)) event.is_incoming_message?.should be_true event.is_outgoing_message?.should be_false event.is_comment?.should be_false |