| Commit message (Collapse) | Author | Age | Lines |
| |
|
| |
|
|
|
|
| |
commands. Also, don't word-wrap. Includes non-word-wrapped source files.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
all the Exims I've used lately already have a log_selector
setting. This syntax allows us to override that. Otherwise, you get
complaints from Exim.
|
|
|
|
|
| |
1) Not overriding any *existing* RAILS_ENV setting in rails_env.rb
2) Always creating a rails_env.rb file
|
|
|
|
|
|
|
|
|
|
| |
Partially revert 2eac4bef8d73f47bbe579b6f787ef54b8d782d7a, creating
config/rails_env.rb in production only. This should address some of
the difficulties with config/rails_env.rb causing unexpected behaviour
in development, whilst forcing Rails into production environment
where necessary for scripts run from cron etc.
Closes #418?
|
|\ |
|
| |\ |
|
| | |
| | |
| | |
| | | |
can't override it. Fixes #416.
|
| | |
| | |
| | |
| | | |
Closes #415.
|
|/ /
| |
| |
| |
| |
| | |
Don't change logged-in user from an admin when visiting a auto-login URL.
Closes #306.
|
| |
| |
| |
| |
| | |
Include information about what the per-day limit is, and when the
user can next make a request. Fixes #412.
|
| |
| |
| |
| | |
Fixes #413.
|
| |
| |
| |
| | |
Fixes #407.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Issue #409 seems to be another problem of the same type as #408,
though with the important difference that the bug in this case
is in the test suite rather than the code under test.
RequestMailer sends alert emails warning of overdue requests.
However it does not specify the order that these messages are
sent in, but runs over the overdue requests in whatever order
they are returned by a database query (that does not have an
order by clause). Therefore it is not safe for the test code
to assume that the alert mails will have been sent in a particular
order: just as with #408 it seems that they were *usually* sent
in the order assumed by the test code, but occasionally not --
which would result in sporadic test failures.
Closes #409.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
So it turns out that issue #408 is a real and potentially nasty
bug. The code was assuming that attachments are returned in the
order they were created, which is a) not guaranteed to be the case,
and b) sometimes actually not the case, hence the occasional test
failures.
This trivial patch corrects the issue by sorting attachments by
id. The effect of this is to return them in the order they were
added to the database, since all were added using the same sequence
in a single database session.
Fixes #408.
|
| | |
|
| |
| |
| |
| | |
Really, what was that about?
|
| |
| |
| |
| |
| | |
Change the test assertions so they give more informative errors
when they fail -- as they sometimes do: see issue #408.
|
|\| |
|
| |
| |
| |
| |
| |
| |
| | |
The variables last_request_id and last_body_id were not used
by the view, so it’s clearer to make them local variables so
it’s obvious from the controller code which values influence
the rendering.
|
| | |
|
| |\ |
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Make it possible to log the output of failed pairs, so we have some
hope of determining the cause of failure in cases where it does not
turn out to be reproducible.
|
| |/ / |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
(a) it doesn't do fuzzy matches (apparently Transifex does that for you)
(b) it doesn't update all the PO files too (which certainly Transifex does for you)
|
| |\| |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The rails-post-deploy script was creating a file config/rails_env.rb
to force $RAILS_ENV to have the appropriate value. But this is a huge
pain during development, and shouldn’t be necessary anyway, so let’s
get rid of it.
|
| | | |
|
| | |
| | |
| | |
| | | |
categories that work with the sample data.
|
| | | |
|
|\ \ \
| | |/
| |/| |
|
| |\ \
| | |/
| |/|
| | |
| | | |
Conflicts:
locale/app.pot
|
| | | |
|
| | |
| | |
| | |
| | | |
Corrected diagnosis, test & fix for issue #351. Fixes #351.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Revert a small part of 33f8ef66084bbfb61bf0b4e0f53e1da5e7cc84dc,
which was not intended, so that the behaviour is unchanged if a
xapian database doesn’t exist, say.
|