| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
|
|
|
|
| |
Now if you click on the bar representing statistics for a
particular public body, it will take you to that public
body's page.
In addition, the bars are highlighted when you hover over
them.
|
|
|
|
|
|
| |
This commit adds the tickrotor extension to Flot, which allows
rotated labels for public bodies. This extension is licensed
under either MPL 1.1, GPL 2.0 or LGPL 2.1.
|
|
|
|
|
|
| |
This updates flot to version 0c2f6e3, which should be shortly before the
release of 0.8.2. This is required for the tickrotor extension
(allowing rotated public body names on the x-axis).
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Clicking on the "This request requires administrator attention"
label would actually select the "I've received an error message"
option due to the label referring to the wrong input element.
This change corrects the label.
Thanks to Jedidiah Broadbent for spotting this bug.
Fixes #1113
|
| |
| |
| |
| |
| |
| | |
These are only being rendered into a comment, and have been for a long
time. They now appear to be causing problems with non-ascii characters
in ruby 1.9, so drop them completely.
|
| | |
|
| |
| |
| |
| |
| | |
This is something you should be able to override without having to take
on the maintenance of your own layout.
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
Gemfile
app/views/admin_request/edit_outgoing.html.erb
config/packages
doc/CHANGES.md
doc/INSTALL.md
spec/models/info_request_spec.rb
spec/models/public_body_spec.rb
|
| |
| |
| |
| |
| |
| | |
Add the 'Actions' to the incoming message admin - now that this has both
this and the prominence form, it seems like the logical place to link to
from the main request page.
|
| |
| |
| |
| |
| |
| |
| | |
get_last_response_event and get_last_outgoing_event are used in various
places to determine which events to link to, use in queries etc.
Restrict them to refer to the last publicly visible event of the
relevant type, and rename them to make that clear.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Conflicts:
app/views/request/_incoming_correspondence.html.erb
|
| |
| |
| |
| |
| |
| | |
At least some of the logic for incoming and outgoing message prominence
is going to be identical, so move it to a module they can both include
and use.
|
| |
| |
| |
| |
| |
| | |
This was disabled for hidden requests as the download was by redirect,
allowing people who have not been authenticated to conceivably access
the download. We'll be moving to send_file instead, so can restore it.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Adds a spec for what we want to see - no message text in
correspondence.txt, and no attachments. Refactors the
simple_correspondence templates to make it clearer that these are doing
the same job as the html.erb ones, for text.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Each part is a separate sentence, and we're going to reuse some of them
in the text view.
Conflicts:
spec/integration/view_request_spec.rb
|
| |
| |
| |
| | |
We're about to reuse them for the text view.
|
| |
| |
| |
| |
| |
| | |
Conflicts:
app/views/request/_incoming_correspondence.html.erb
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Render the show template within the current thread rather than making
another request - we're going to need to use the current session in
order to know what do include in the zip file, now that we have more
fine-grained visibility of messages. Also, this will mean we can use
this functionality in single threaded contexts, and test it more easily.
Don't display profile photos as this would require another process, and
hide other icons so we don't need to include them. Use render_to_string
as a more standard way of rendering templates to a string for further
manipulation.
|
| |
| |
| |
| |
| |
| | |
So we can reuse them when rendering the show template to a file. Lots of
the sidebar prep isn't going to be needed for that view, so make that
optional in the template.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This will happen if the prominence has been changed in the admin
interface but no reason has been filled in.
Conflicts:
app/views/request/_incoming_correspondence.html.erb
|
| |
| |
| |
| | |
From the request admin page.
|
| |
| |
| |
| | |
The order is the same as the default association.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Eventually this should use standard RESTful routing.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
app/views/request/_incoming_correspondence.html.erb
Conflicts:
spec/integration/view_request_spec.rb
|
| |
| |
| |
| | |
Different messages for normal user, requester and admin user.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Add a migration to remove the unused column 'prominence' from
info_request_events, remove validation of prominence, remove unused
InfoRequestEvent.user_can_view? method. Remove references to
InfoRequestEvent.prominence.
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The statistics we're publishing are potentially subject to
misinterpretation, so add some warnings about their experimental
nature. Also, add a note crediting Mark Goodge for his useful
work on statistics for WhatDoTheyKnow.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Move the calculation of statistics on public bodies into
the PublicBody model, so that there's less logic in the
controller.
|
| | |
| | |
| | |
| | | |
This is as suggested in the Flot documentation.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The statistics on the status of the requests to a particular
public body are too slow to calculate on-the-fly, so this
commit adds:
* Extra columns on public_bodies to store counts of
the successful, not held, and overdue request counts
for each public body.
* A rake task which should be run periodically to update
the overdue request count column.
If Javascript is not available, the summary statistics are
shown as tables. If Javascript is available, graphs are
drawn with Flot.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
admin.js was being generated from a view so that the config variable
ADMIN_PUBLIC_URL could be used to direct AJAX requests in the admin
interface correctly. ADMIN_PUBLIC_URL was necessary for
WhatDoTheyKnow when the admin interface was proxied over SSL, while
the rest of the site was non-SSL. Now that the whole site is served
over SSL, however, the proxy for the admin interface is not longer
used and ADMIN_PUBLIC_URL / ADMIN_BASE_URL have been removed.
As a result, admin.js is now being generated from a Rails view
unnecessarily, and at some performance cost. This commit moves
admin.coffee and admin.js to the public directory, so they will
be served more efficiently.
In addition, this commit removes admin.coffee / admin.js from
public/javascripts/ where there was a second (and different) version
that now appears to be unused.
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | | |
Closes #1053.
|
| |/ /
| | |
| | |
| | | |
We use the :confirm option of the submit_tag helper. Fixes #1042.
|
|/ /
| |
| |
| | |
When status was updated by a script.
|
|/ |
|