aboutsummaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeLines
* No need to set permissions on file now.Louise Crow2013-09-16-1/+0
| | | | | Either rails or the webserver will be sending it, we're not redirecting anymore.
* Add message index to attachment filesLouise Crow2013-09-16-1/+3
| | | | | So that files attached to different messages with the same name and url_part don't get overwritten.
* Point admin link to incoming message admin interface.Louise Crow2013-09-16-1/+2
| | | | | | Add the 'Actions' to the incoming message admin - now that this has both this and the prominence form, it seems like the logical place to link to from the main request page.
* Exclude hidden responses when calculating old_unclassifiedLouise Crow2013-09-16-4/+14
| | | | | Make old_unclassified_params method consistent with last_public_response_event and associated methods.
* Only include public messages in who_can_followup_toLouise Crow2013-09-16-0/+2
|
* Add public criteria for message event access methodsLouise Crow2013-09-16-23/+25
| | | | | | | get_last_response_event and get_last_outgoing_event are used in various places to determine which events to link to, use in queries etc. Restrict them to refer to the last publicly visible event of the relevant type, and rename them to make that clear.
* Shorter way of getting text template.Louise Crow2013-09-16-1/+1
|
* Hide hidden outgoing messages in download.Louise Crow2013-09-16-9/+11
|
* Add prominence fields and cache expiry to outgoing adminLouise Crow2013-09-16-7/+36
|
* InfoRequestEvent.indexed_by_search consults OutgoingMessage.Louise Crow2013-09-16-0/+3
|
* Move indexed_by_search to MessageProminenceLouise Crow2013-09-16-4/+0
| | | | Add some tests that it's working on the outgoing message model.
* Add hidden messages for outgoing message.Louise Crow2013-09-16-30/+39
| | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb
* Create MessageProminence module.Louise Crow2013-09-16-7/+3
| | | | | | At least some of the logic for incoming and outgoing message prominence is going to be identical, so move it to a module they can both include and use.
* Move some download methods to InfoRequest.Louise Crow2013-09-16-25/+41
| | | | | | Use send_file to send zips. Also adds 'all_can_view_all_correspondence?' - is this request completely cachable, or do we need to cache different versions for different levels of privilege?
* Restore the download for hidden requestsLouise Crow2013-09-16-6/+4
| | | | | | This was disabled for hidden requests as the download was by redirect, allowing people who have not been authenticated to conceivably access the download. We'll be moving to send_file instead, so can restore it.
* Make sure that info_request gets assigned to the viewLouise Crow2013-09-16-2/+2
| | | | | | This should be handled by assign_variables_for_show_template. Otherwise, the make_request_summary_file method shouldn't depend on instance variables
* Move zip file creation to its own method.Louise Crow2013-09-16-16/+15
|
* Move display text generation to outgoing message.Louise Crow2013-09-16-5/+9
|
* Remove hidden incoming messages from correspondence.txtLouise Crow2013-09-16-46/+46
| | | | | | | Adds a spec for what we want to see - no message text in correspondence.txt, and no attachments. Refactors the simple_correspondence templates to make it clearer that these are doing the same job as the html.erb ones, for text.
* Split up translated messages.Louise Crow2013-09-16-2/+5
| | | | | | | | | Each part is a separate sentence, and we're going to reuse some of them in the text view. Conflicts: spec/integration/view_request_spec.rb
* Move a couple of complex conditionals to helper methods.Louise Crow2013-09-16-2/+11
| | | | We're about to reuse them for the text view.
* Remove unused param.Louise Crow2013-09-16-1/+1
| | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb
* Normalize method spacing.Louise Crow2013-09-16-0/+3
|
* Extract calculation of last update hashLouise Crow2013-09-16-2/+5
|
* Extract out code for making a request summary fileLouise Crow2013-09-16-45/+62
| | | | | | | | | | | | Render the show template within the current thread rather than making another request - we're going to need to use the current session in order to know what do include in the zip file, now that we have more fine-grained visibility of messages. Also, this will mean we can use this functionality in single threaded contexts, and test it more easily. Don't display profile photos as this would require another process, and hide other icons so we don't need to include them. Use render_to_string as a more standard way of rendering templates to a string for further manipulation.
* Extract the various info_request assignsLouise Crow2013-09-16-10/+16
| | | | | | So we can reuse them when rendering the show template to a file. Lots of the sidebar prep isn't going to be needed for that view, so make that optional in the template.
* Reorder assignsLouise Crow2013-09-16-12/+12
| | | | | Split into those that come from request params and those that come from the model
* Add new code and specs for hiding attachments.Louise Crow2013-09-16-11/+33
|
* Handle the case of an empty string in the prominence_reason.Louise Crow2013-09-16-3/+3
| | | | | | | | | This will happen if the prominence has been changed in the admin interface but no reason has been filled in. Conflicts: app/views/request/_incoming_correspondence.html.erb
* Add a possible event type 'edit_incoming'.Louise Crow2013-09-16-1/+1
| | | | This will cover changes in prominence to incoming messages.
* Add the meat of the update action.Louise Crow2013-09-16-0/+19
|
* Link to the new incoming message edit form.Louise Crow2013-09-16-1/+6
| | | | From the request admin page.
* I don't think there's any need to refind incoming messages.Louise Crow2013-09-16-1/+1
| | | | The order is the same as the default association.
* Use new partial for incoming message admin boilerplate.Louise Crow2013-09-16-5/+1
|
* Add a simple edit action and templateLouise Crow2013-09-16-0/+32
|
* Shorter route names and pathsLouise Crow2013-09-16-6/+6
|
* Add incoming message update action and route.Louise Crow2013-09-16-0/+3
| | | | | We'll use this for saving the changes to the prominence of an incoming message in a relatively RESTful url structure.
* Make prominence states a constant so we can access them elsewhere.Louise Crow2013-09-16-5/+2
|
* Slightly nicer action names.Louise Crow2013-09-16-2/+2
|
* Move incoming message admin to its own controller.Louise Crow2013-09-16-52/+54
| | | | | Make specs that depend on multiple controllers and models interacting integration specs.
* Move outgoing message admin actions to their own controller.Louise Crow2013-09-16-33/+36
| | | | Eventually this should use standard RESTful routing.
* Don't index hidden and requester_only incoming messages.Louise Crow2013-09-16-0/+8
|
* Remove unused hidden correspondence template.Louise Crow2013-09-16-33/+0
|
* Add prominence reason.Louise Crow2013-09-16-4/+15
| | | | | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb Conflicts: spec/integration/view_request_spec.rb
* Adding prominence_reason to IncomingMessage.Louise Crow2013-09-16-0/+1
|
* Add messages for hidden and requester_only states.Louise Crow2013-09-16-15/+35
| | | | Different messages for normal user, requester and admin user.
* Refactor common logic about prominence and access.Louise Crow2013-09-16-14/+2
| | | | Move it into the Ability module.
* Add a method to ask whether a user can view an incoming message.Louise Crow2013-09-16-0/+10
|
* Rename method to make it a bit more genericLouise Crow2013-09-16-5/+5
| | | | A super user will be able to see all hidden things, not just requests.
* Refactor correspondence template into partials.Louise Crow2013-09-16-81/+63
|