Commit message (Collapse) | Author | Age | Lines | ||
---|---|---|---|---|---|
... | |||||
| * | | Extract complexity in ChangeEmailValidator | Gareth Rees | 2014-10-29 | -2/+10 | |
| | | | | | | | | | | | | Add some private methods to add more semantics to conditionals | ||||
| * | | Remove duplication in ChangeEmailValidator | Gareth Rees | 2014-10-29 | -5/+8 | |
| | | | |||||
| * | | Tidy ChangeEmailValidator | Gareth Rees | 2014-10-29 | -9/+19 | |
| | | | | | | | | | | | | | | | Line Length Remove self. | ||||
| * | | Clean up AboutMeValidator | Gareth Rees | 2014-10-20 | -1/+1 | |
| | | | | | | | | | | | | Remove self. | ||||
* | | | Extract public_body/show sidebar to partial | Gareth Rees | 2014-10-28 | -21/+28 | |
| | | | | | | | | | Easier to override | ||||
* | | | Merge branch 'censor_rule_cleanup' into rails-3-develop | Gareth Rees | 2014-10-28 | -34/+35 | |
|\ \ \ | |/ / |/| | | |||||
| * | | Avoid use of parameter with attribute name | Gareth Rees | 2014-10-15 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | The `text` parameter in `apply_to_text!(text)` can easily be confused with the `text` attribute of a CensorRule. Renamed to avoid confusion and renamed the parameter in `apply_to_binary!` for consistency. | ||||
| * | | Privatise uncalled CensorRule methods | Gareth Rees | 2014-10-15 | -20/+20 | |
| | | | | | | | | | | | | Make public api as slim as possible | ||||
| * | | Extract duplication in CensorRule | Gareth Rees | 2014-10-15 | -2/+6 | |
| | | | |||||
| * | | Clean up CensorRule | Gareth Rees | 2014-10-15 | -22/+19 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Avoid self when not required https://github.com/bbatsov/ruby-style-guide#no-self-unless-required - Pad hashes - Line length - Omit paentheses for method calls with no arguments https://github.com/bbatsov/ruby-style-guide#no-args-no-parens - Avoid return where not required https://github.com/bbatsov/ruby-style-guide#no-explicit-return | ||||
* | | | Merge branch 'issues/1778-send-message' into rails-3-develop | Gareth Rees | 2014-10-17 | -41/+95 | |
|\ \ \ | |/ / |/| | | |||||
| * | | Remove now-unused OutgoingMessage#send_message | Gareth Rees | 2014-10-17 | -44/+0 | |
| | | | | | | | | | | | | Models should not send emails | ||||
| * | | Extract resending a message from the model | Gareth Rees | 2014-10-17 | -4/+27 | |
| | | | |||||
| * | | Use updated method for sending an InfoRequestBatch | Gareth Rees | 2014-10-17 | -1/+7 | |
| | | | | | | | | | | | | | | | Could do with extracting the sending from the model, but this allows the removal of OutgoingMessage#send_message | ||||
| * | | Extract initial and followup sending from model | Gareth Rees | 2014-10-17 | -3/+30 | |
| | | | |||||
| * | | OutgoingMessage methods for async email sending | Gareth Rees | 2014-10-14 | -0/+42 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | #sendable? checks whether the message is in a state that we can send, otherwise it raises an appropriate exception. Not ideal (should just return false, but this is existing behaviour) #record_email_delivery updates the OutgoingMessage instance, logs an event with the InfoRequest and updates the InfoRequest state. | ||||
* | | | Merge branch 'spam_address_routing' into rails-3-develop | Gareth Rees | 2014-10-14 | -5/+5 | |
|\ \ \ | |||||
| * | | | Add admin prefix to spam_addresses resources | Gareth Rees | 2014-10-10 | -5/+5 | |
| |/ / | |||||
* | | | Merge branch 'issues/1830-batch-request-user-filter' into rails-3-develop | Gareth Rees | 2014-10-14 | -0/+22 | |
|\ \ \ | |||||
| * | | | User profile option to filter requests by status | Gareth Rees | 2014-10-14 | -0/+22 | |
| |/ / | | | | | | | | | | | | | Filters on `latest_status` because filtering by `status` searches all states a request has ever been in. | ||||
* | | | Merge branch 'issues/222-category-editing-add-order-interface' into ↵ | Louise Crow | 2014-10-14 | -14/+805 | |
|\ \ \ | |/ / |/| | | | | | rails-3-develop | ||||
| * | | fixup! Use RESTful routing. | Louise Crow | 2014-10-09 | -22/+22 | |
| | | | |||||
| * | | Require heading and category in PublicBodyCategoryLink. | Louise Crow | 2014-10-09 | -0/+2 | |
| | | | | | | | | | | | | Update default factory accordingly. | ||||
| * | | Remove old PublicBodyCategories calls. | Louise Crow | 2014-10-09 | -7/+7 | |
| | | | | | | | | | | | | | | | Add deprecation notice to draw attention to any place where PublicBodyCategories is called from themes. | ||||
| * | | Don't migrate categories automatically. | Louise Crow | 2014-09-26 | -2/+0 | |
| | | | | | | | | | | | | | | | It becomes confusing in the test environment, better to have a clean script. | ||||
| * | | Don't require a category description | Louise Crow | 2014-09-26 | -1/+0 | |
| | | | | | | | | | | | | | | | Some existing themes don't use one for categories like 'misc' and that seems reasonable usage. Add some specs for the things we do validate. | ||||
| * | | Use double quotes to avoid backslash | Louise Crow | 2014-09-26 | -3/+3 | |
| | | | |||||
| * | | Refactor for clarity of return/error conditions | Louise Crow | 2014-09-26 | -34/+53 | |
| | | | |||||
| * | | Rename partials to be more descriptive | Louise Crow | 2014-09-26 | -3/+3 | |
| | | | |||||
| * | | Use RESTful routing. | Louise Crow | 2014-09-26 | -61/+49 | |
| | | | |||||
| * | | Create module to clarify what code is just for migrating from files. | Louise Crow | 2014-09-25 | -81/+13 | |
| | | | |||||
| * | | fixup! Basic category admin screen | Louise Crow | 2014-09-25 | -2/+2 | |
| | | | |||||
| * | | fixup! Use translation tables for PublicBodyCategory and PublicBodyHeading | Louise Crow | 2014-09-25 | -53/+51 | |
| | | | |||||
| * | | fixup! Basic category admin screen | Louise Crow | 2014-09-24 | -3/+0 | |
| | | | |||||
| * | | fixup! Replace existing PublicBodyCategories functionality with db models ↵ | Louise Crow | 2014-09-24 | -1/+1 | |
| | | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading | ||||
| * | | fixup! Replace existing PublicBodyCategories functionality with db models ↵ | Louise Crow | 2014-09-24 | -53/+54 | |
| | | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading | ||||
| * | | fixup! Add display order to public body categories and headings | Louise Crow | 2014-09-24 | -1/+1 | |
| | | | |||||
| * | | fixup! Replace existing PublicBodyCategories functionality with db models ↵ | Louise Crow | 2014-09-24 | -10/+10 | |
| | | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading | ||||
| * | | fixup! Basic category admin screen | Louise Crow | 2014-09-24 | -16/+17 | |
| | | | |||||
| * | | fixup! Add actions for reordering public body headings and categories. | Louise Crow | 2014-09-24 | -4/+3 | |
| | | | |||||
| * | | fixup! Validation of display order, default setting callbacks. | Louise Crow | 2014-09-24 | -3/+3 | |
| | | | |||||
| * | | Allow reordering of categories and headings using javascript. | Louise Crow | 2014-09-22 | -43/+100 | |
| | | | |||||
| * | | New heading associations should be added on category create. | Louise Crow | 2014-09-22 | -0/+5 | |
| | | | |||||
| * | | Add actions for reordering public body headings and categories. | Louise Crow | 2014-09-22 | -0/+44 | |
| | | | |||||
| * | | Validation of display order, default setting callbacks. | Louise Crow | 2014-09-22 | -14/+34 | |
| | | | |||||
| * | | Destroy link on destruction of heading or category. | Louise Crow | 2014-09-22 | -2/+2 | |
| | | | |||||
| * | | Allow deletion of public body categories with associatied bodies | lizconlan | 2014-09-22 | -7/+0 | |
| | | | |||||
| * | | Add display order to public body categories and headings | lizconlan | 2014-09-22 | -7/+80 | |
| | | | |||||
| * | | Reinstate automatic loading of categories on get if no categories defined | lizconlan | 2014-09-22 | -0/+2 | |
| | | | |||||
| * | | Set default font for admin navbar throughout site | lizconlan | 2014-09-22 | -0/+3 | |
| | | |