aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeLines
* Merge branch 'hotfix/0.21.0.35' into rails-3-developrails-3-developLouise Crow2015-05-29-3/+3
|\
| * Address#to_s changes the input passed to it - dup before calling.Louise Crow2015-05-28-3/+3
| | | | | | | | Otherwise UTF-8 encoded strings will be returned as ASCII-8BIT.
| * Fix encoding issue with searching for macronsCaleb2015-05-28-35/+37
| | | | | | | | Correct indentation to be consistent
* | Merge branch 'hotfix/0.21.0.33' into rails-3-developLouise Crow2015-05-28-1/+4
|\|
| * Make sure spelling corrections are encoded as UTF-8Louise Crow2015-05-28-1/+4
| |
* | Merge branch 'rails-3-develop' of ↵Louise Crow2015-05-28-2/+2
|\ \ | | | | | | | | | ssh://git.mysociety.org/data/git/public/alaveteli into rails-3-develop
| * \ Merge remote-tracking branch 'jpmckinney/truefalse' into rails-3-developGareth Rees2015-05-28-2/+2
| |\ \
| | * | Eliminate !! (bang bang)James McKinney2015-05-27-2/+2
| | | |
| | * | Avoid unnecessary ternary operationsJames McKinney2015-05-21-2/+2
| | | |
* | | | Merge branch 'force-filenames-to-utf8' into rails-3-developLouise Crow2015-05-28-1/+20
|\ \ \ \ | |/ / / |/| | |
| * | | Force attachment filenames to utf-8 before trying to save themLouise Crow2015-05-15-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a database with encoding SQL-ASCII, an invalid utf-8 filename can be saved but will cause an "invalid byte sequence in UTF-8" when the filename is prepared for display. In a database with a UTF-8 encoding, saving the string will cause an error like "ActiveRecord::StatementInvalid (PG::Error: ERROR: invalid byte sequence for encoding "UTF8""
| * | | Add method for forcing strings to valid utf-8Louise Crow2015-05-14-0/+11
| | | | | | | | | | | | | | | | | | | | Try likely conversions but if that fails, just replace the characters that are invalid utf-8.
* | | | Merge branch 'locale-specific-language-name' into rails-3-developLouise Crow2015-05-28-0/+2
|\ \ \ \
| * | | | Allow locale specific language names and add one for Hong Kong Chinese.Louise Crow2015-05-15-0/+2
| | | | |
* | | | | Merge remote-tracking branch 'jpmckinney_github/class_methods' into ↵Louise Crow2015-05-26-29/+29
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | rails-3-develop
| * | | | | Declare class methods the idiomatic Ruby wayJames McKinney2015-05-21-29/+29
| | |_|/ / | |/| | |
* | | | | Merge remote-tracking branch 'schlos_github/patch-2' into rails-3-developLouise Crow2015-05-26-1/+5
|\ \ \ \ \
| * | | | | Adding Croatian AlaveteliMiroslav2015-05-24-1/+5
| | | | | | | | | | | | | | | | | | Added Croatian Alaveteli to the list of world FOI websites
* | | | | | Merge branch 'hotfix/0.21.0.32' into rails-3-developLouise Crow2015-05-26-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | / | | |_|_|/ | |/| | |
| * | | | Handle invalid 'to' addresses.Louise Crow2015-05-22-1/+1
| | | | |
* | | | | Merge remote-tracking branch 'jpmckinney_github/parentheses' into ↵Louise Crow2015-05-22-10/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | rails-3-develop
| * | | | | Remove all optional parentheses for method calls in RubyJames McKinney2015-05-21-10/+10
| | |/ / / | |/| | |
* / | | | Simplify HealthCheckable APIJames McKinney2015-05-21-7/+3
|/ / / /
* | / / Move common AttachmentToHTML methods to a superclassJames McKinney2015-05-20-202/+87
| |/ / |/| |
* | | Add source file encoding for all ruby files.Louise Crow2015-05-15-5/+48
| |/ |/| | | | | | | | | This is important under ruby 1.9 in order to determine the encoding that will be used for new strings created in the code in the file.
* | Merge branch 'html-relative-path' into rails-3-developLouise Crow2015-05-12-2/+2
|\|
| * Use a relative path in call to pdftohtml.Louise Crow2015-05-11-2/+2
| | | | | | | | | | | | | | | | pdftohtml will use the file path as the basis for generating the image links in the generated HTML, so we want them to be relative, not absolute. Ruby 1.9 tempfile.path will generate an absolute path when given the current directory as the tmpdir, whilst 2.0 and 1.8 will use a relative one.
* | Send mail import errors to exception notification address.Louise Crow2015-05-11-2/+2
| | | | | | | | | | Usually these are going to require some technical action. There's not much regular admins can do about them.
* | Merge branch 'remove-obsolete-code' into rails-3-developLouise Crow2015-05-07-8/+0
|\ \
| * | Remove monkeypatch required when running Rails 2.3 under Ruby 1.9Louise Crow2015-05-07-8/+0
| | | | | | | | | | | | | | | | | | This was added because TMail calls String#is_binary_data? which does not exist in Ruby 1.9.2 onwards. We don't use TMail anymore so this is no longer needed.
* | | Add bulletGareth Rees2015-05-07-1/+2
|/ / | | | | | | Help to kill N+1 queries and unused eager loading
* | Merge branch 'xapian-refactor' into rails-3-developLouise Crow2015-04-30-84/+91
|\ \
| * | Refactor for idiomatic ruby.Louise Crow2015-04-30-15/+18
| | | | | | | | | | | | | | | | | | Use of each rather than for, case statement for multi-clause if, variable interpolation rather than concatenation. Also use inline variables in the each for clarity.
| * | Factor out initialisation of values into its own methodLouise Crow2015-04-29-26/+28
| | |
| * | Factor out term initialisation into its own method.Louise Crow2015-04-29-18/+20
| | |
| * | Use each, identify variables for readability, break up long lines.Louise Crow2015-04-29-13/+16
| | |
| * | Use variable interpolation.Louise Crow2015-04-29-1/+1
| | |
| * | Extract running a job to its own method.Louise Crow2015-04-29-24/+28
| | |
| * | Cleanup spacing.Louise Crow2015-04-29-1/+1
| | |
| * | Use pluck - it's more efficient and concise.Louise Crow2015-04-29-2/+1
| | |
| * | Use empty?, it's more idiomaticLouise Crow2015-04-29-1/+1
| | |
| * | Use a pluck call to get the model namesLouise Crow2015-04-29-1/+1
| | | | | | | | | | | | Clearer, and more efficient.
| * | Use an each blockLouise Crow2015-04-29-4/+1
| | | | | | | | | | | | It's idiomatic, and you can assign the elements of the list inline.
| * | Use respond_to? rather than a begin rescue blockLouise Crow2015-04-29-10/+7
| | | | | | | | | | | | Exceptions are a slow way to do control flow, and this seems clearer.
* | | Use .example files for daemons.Louise Crow2015-04-28-5/+5
|/ / | | | | | | | | Consistent with other example config files, and helps us solve a mySociety config issue.
* | Allow widgets to be controlled with a feature flag.Louise Crow2015-04-27-0/+1
| |
* | Fix encoding issue with searching for macronsCaleb2015-04-20-35/+37
| | | | | | | | Correct indentation to be consistent
* | Merge branch 'fix-text-masker-logger-call' into rails-3-developLouise Crow2015-04-16-11/+24
|\ \
| * | Break up long line.Louise Crow2015-04-16-1/+9
| | |
| * | Make syntax a bit more readable.Louise Crow2015-04-16-1/+1
| | |