aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeLines
* Merge branch 'html-relative-path' into rails-3-developLouise Crow2015-05-12-2/+2
|\
| * Use a relative path in call to pdftohtml.Louise Crow2015-05-11-2/+2
| | | | | | | | | | | | | | | | pdftohtml will use the file path as the basis for generating the image links in the generated HTML, so we want them to be relative, not absolute. Ruby 1.9 tempfile.path will generate an absolute path when given the current directory as the tmpdir, whilst 2.0 and 1.8 will use a relative one.
* | Send mail import errors to exception notification address.Louise Crow2015-05-11-2/+2
| | | | | | | | | | Usually these are going to require some technical action. There's not much regular admins can do about them.
* | Merge branch 'remove-obsolete-code' into rails-3-developLouise Crow2015-05-07-8/+0
|\ \
| * | Remove monkeypatch required when running Rails 2.3 under Ruby 1.9Louise Crow2015-05-07-8/+0
| | | | | | | | | | | | | | | | | | This was added because TMail calls String#is_binary_data? which does not exist in Ruby 1.9.2 onwards. We don't use TMail anymore so this is no longer needed.
* | | Add bulletGareth Rees2015-05-07-1/+2
|/ / | | | | | | Help to kill N+1 queries and unused eager loading
* | Merge branch 'xapian-refactor' into rails-3-developLouise Crow2015-04-30-84/+91
|\ \
| * | Refactor for idiomatic ruby.Louise Crow2015-04-30-15/+18
| | | | | | | | | | | | | | | | | | Use of each rather than for, case statement for multi-clause if, variable interpolation rather than concatenation. Also use inline variables in the each for clarity.
| * | Factor out initialisation of values into its own methodLouise Crow2015-04-29-26/+28
| | |
| * | Factor out term initialisation into its own method.Louise Crow2015-04-29-18/+20
| | |
| * | Use each, identify variables for readability, break up long lines.Louise Crow2015-04-29-13/+16
| | |
| * | Use variable interpolation.Louise Crow2015-04-29-1/+1
| | |
| * | Extract running a job to its own method.Louise Crow2015-04-29-24/+28
| | |
| * | Cleanup spacing.Louise Crow2015-04-29-1/+1
| | |
| * | Use pluck - it's more efficient and concise.Louise Crow2015-04-29-2/+1
| | |
| * | Use empty?, it's more idiomaticLouise Crow2015-04-29-1/+1
| | |
| * | Use a pluck call to get the model namesLouise Crow2015-04-29-1/+1
| | | | | | | | | | | | Clearer, and more efficient.
| * | Use an each blockLouise Crow2015-04-29-4/+1
| | | | | | | | | | | | It's idiomatic, and you can assign the elements of the list inline.
| * | Use respond_to? rather than a begin rescue blockLouise Crow2015-04-29-10/+7
| | | | | | | | | | | | Exceptions are a slow way to do control flow, and this seems clearer.
* | | Use .example files for daemons.Louise Crow2015-04-28-5/+5
|/ / | | | | | | | | Consistent with other example config files, and helps us solve a mySociety config issue.
* | Allow widgets to be controlled with a feature flag.Louise Crow2015-04-27-0/+1
| |
* | Fix encoding issue with searching for macronsCaleb2015-04-20-35/+37
| | | | | | | | Correct indentation to be consistent
* | Merge branch 'fix-text-masker-logger-call' into rails-3-developLouise Crow2015-04-16-11/+24
|\ \
| * | Break up long line.Louise Crow2015-04-16-1/+9
| | |
| * | Make syntax a bit more readable.Louise Crow2015-04-16-1/+1
| | |
| * | Use implicit evaluation.Louise Crow2015-04-16-1/+1
| | |
| * | Clean up variable nameLouise Crow2015-04-16-2/+2
| | |
| * | Clean up unneeded local variable.Louise Crow2015-04-16-2/+1
| | |
| * | Refactor a bit to allow testing of logic branches.Louise Crow2015-04-16-10/+16
| | | | | | | | | | | | | | | Add specs for current behaviour on failure to uncompress, failure to compress.
| * | Call logger explicitly because it's not in scope hereHenare Degan2015-04-16-1/+1
| | | | | | | | | | | | | | | Prevents exception `undefined local variable or method 'logger' for AlaveteliTextMasker:Module` being thrown.
* | | Set standard default values.Louise Crow2015-04-14-2/+2
|/ /
* | Make clear that it is only the production delivery method that is being set.Louise Crow2015-04-14-1/+1
| |
* | Make clear that SMTP mail settings are SMTP-specific.Louise Crow2015-04-14-9/+9
| |
* | Allow configuration for SMTP settingsCaleb2015-04-09-1/+9
|/
* Handle the expected case where conversion fails and returns nil.Louise Crow2015-04-02-1/+2
|
* Merge branch '1472-simpler-external-process-management' into rails-3-developLouise Crow2015-03-24-30/+43
|\
| * Handle a child that cannot be terminated.Louise Crow2015-03-23-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Basic handling that is the same as for other process errors - just write to stderr. Add TODO for allowing the calling code to specify an error stream to allow other handling. In different circumstances, the calling code might want to raise an exception, write to the log, or do something else. At the moment this code assumes a cron context and writes to stderr, which will cause an email to be sent from the cron process, but that's not always the context the calling code is being run in. So we may be missing errors that are, for example, being written to stderr during the request cycle. In fact, this code may be called from the same place with different contexts (i.e. as part of a cron reindexing task and in the request cycle), so at the moment some substantial refactoring of the calling code would be required to make sure calls to this code handle errors appropriately for each context.
| * Give messages standard start text.Louise Crow2015-03-23-3/+3
| | | | | | | | To make it easier to find them in other output.
| * Set options via options hash only.Louise Crow2015-03-23-16/+3
| |
| * Add a default timeout of 20 mins to external commands.Louise Crow2015-03-23-1/+3
| |
| * Give a forced timeout its own error message.Louise Crow2015-03-23-2/+11
| | | | | | | | Clarify grouping of command and arguments with quotes.
| * Separate flags for binary input and outputLouise Crow2015-03-23-3/+8
| | | | | | | | | | There may be cases where the input is binary but the output is encoded text.
| * Allow options hash to be passed to ExternalCommand.Louise Crow2015-03-23-2/+3
| | | | | | | | Document :timeout as a possible option key.
| * Factor out find_program method.Louise Crow2015-01-27-13/+14
| |
* | Merge branch 'translation-script' into rails-3-developLouise Crow2015-03-23-1/+46
|\ \
| * | Add rake task for uppdating locale files with slightly changed msgidsLouise Crow2015-03-23-1/+46
| | | | | | | | | | | | | | | | | | We don't really want to make all the translators retranslate strings that are basically the same but slightly tweaked in the English version. So this task just replaces the msgid in the app.po files for each locale.
* | | Update Croatian languageMiroslav2015-03-17-1/+1
|/ / | | | | Just updating to first caps to match GUI context
* | Remove deprecated code. Fixes #2015.Louise Crow2015-02-26-102/+0
| |
* | Merge branch '2101-country-specific-select-authority' into rails-3-developGareth Rees2015-02-19-0/+1
|\ \
| * | Add AUTHORITY_MUST_RESPOND configuration optionGareth Rees2015-02-19-0/+1
| |/
generated by cgit v1.2.3 (git 2.25.1) at 2025-09-01 14:05:14 +0000