Commit message (Collapse) | Author | Age | Lines | |
---|---|---|---|---|
* | Update URLs in spec now that custom url methods have been removed. | Louise Crow | 2013-03-13 | -3/+3 |
| | ||||
* | Now direct changes of state to error_message and requires_admin to a new ↵ | Matthew Landauer | 2013-03-06 | -15/+19 |
| | | | | page asking for more info | |||
* | Can also record a message when posting to RequestController#describe_state | Matthew Landauer | 2013-03-05 | -3/+21 |
| | ||||
* | Remove code added previously because on the wrong track | Matthew Landauer | 2013-03-05 | -62/+0 |
| | ||||
* | Don't allow external requests to have their state changed | Matthew Landauer | 2013-03-04 | -0/+14 |
| | ||||
* | Record who changes the state | Matthew Landauer | 2013-03-04 | -1/+1 |
| | ||||
* | Fix bug when user not owner of request changing state to requires_admin ↵ | Matthew Landauer | 2013-03-04 | -3/+12 |
| | | | | email should come from user making the change | |||
* | Inline temporary variables | Matthew Landauer | 2013-03-04 | -0/+1 |
| | ||||
* | Simplify controller test by mock behaviour in Ability | Matthew Landauer | 2013-03-03 | -45/+13 |
| | ||||
* | Can update status when request is old and unclassified | Matthew Landauer | 2013-03-03 | -0/+24 |
| | ||||
* | admin user can change status | Matthew Landauer | 2013-03-03 | -2/+16 |
| | ||||
* | Refactor tests a little | Matthew Landauer | 2013-03-03 | -19/+21 |
| | ||||
* | only can make the change as the owner of a request | Matthew Landauer | 2013-03-03 | -0/+14 |
| | ||||
* | Add basic authentication to new action | Matthew Landauer | 2013-03-03 | -16/+26 |
| | ||||
* | Switch to pretty urls | Matthew Landauer | 2013-03-02 | -1/+1 |
| | ||||
* | New request controller action for requires_admin state with message | Matthew Landauer | 2013-03-02 | -0/+16 |
| | ||||
* | Use routes to only allow post to RequestController#describe_state | Matthew Landauer | 2013-03-02 | -9/+5 |
| | ||||
* | Test for what happens when user is playing the classification game | Matthew Landauer | 2013-03-02 | -0/+11 |
| | ||||
* | Test for situation where request changes while user is looking at it and ↵ | Matthew Landauer | 2013-03-02 | -0/+10 |
| | | | | they change the status | |||
* | Test for forgetting to select the status | Matthew Landauer | 2013-03-02 | -0/+8 |
| | ||||
* | Don't integrate views here - we're not looking at a controller. | Louise Crow | 2013-02-16 | -1/+0 |
| | ||||
* | Clear the purge requests in the setup for these tests so they are isolated ↵ | Louise Crow | 2013-02-16 | -0/+3 |
| | | | | from the behaviour of other tests. | |||
* | modernise redirect tests by converting to using url helpers | Matthew Landauer | 2013-01-29 | -7/+7 |
| | ||||
* | Remove interlock as it's not compatible with Rails 3 and is unmaintained | Henare Degan | 2013-01-18 | -13/+0 |
| | ||||
* | Only serve up 'similar' pages up to the offset we use for list. | Louise Crow | 2012-12-17 | -0/+8 |
| | ||||
* | Adding mocking of incoming message id. | Louise Crow | 2012-12-17 | -0/+1 |
| | ||||
* | Rewrite specs that were in spec/controller/application_controller as ↵ | Louise Crow | 2012-12-17 | -0/+27 |
| | | | | full-stack controller specs in the relevant controllers. It turns out that having spec blocks that reference the ApplicationController class directly i.e. "describe ApplicationController" can have unpredictable effects. actionpack's action_controller/test_case.rb rewrites rescue_action_without_handler on whatever it is included in, and if this is done on a controller class, and then directly on action controller, it can result in an infinite loop of recursive calls. This turns out to be the problem that was causing some tests in error_spec.rb to fail in Travis under Ruby 1.9. | |||
* | Merge branch 'hotfix/authenticate-and-expire-download-zips' into develop | Louise Crow | 2012-12-13 | -1/+11 |
|\ | ||||
| * | Check that a request is publicly visible before generating a download link. | Louise Crow | 2012-12-13 | -1/+11 |
| | | ||||
* | | Merge branch 'hotfix/no-html-conversion-for-hidden' into develop | Louise Crow | 2012-12-13 | -0/+15 |
|\| | ||||
| * | Don't offer or allow viewing of an HTML version of a response attachment if ↵ | Louise Crow | 2012-12-13 | -0/+15 |
| | | | | | | | | the request is hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently can produce image files that will then be publicly viewable directly from the webserver (see config/httpd.conf). If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | |||
* | | Reformat for line length, add the expected response code. | Louise Crow | 2012-12-13 | -2/+9 |
| | | ||||
* | | Don't offer or allow viewing of an HTML version of a request if it is ↵ | Louise Crow | 2012-12-13 | -0/+15 |
| | | | | | | | | hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently produces image files that will then be publicly viewable. If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | |||
* | | Fix syntax of example email. The number of expected attachments was based on ↵ | Louise Crow | 2012-12-04 | -1/+1 |
| | | | | | | | | the specific handling of a bad end boundary in tmail. | |||
* | | Use new function that copies existing xapian index in spec setup where a ↵ | Louise Crow | 2012-11-21 | -1/+1 |
|/ | | | | clean copy of the xapian index with fixtures loaded is required. | |||
* | Add spec - currently failing due to typo. | Louise Crow | 2012-10-23 | -0/+42 |
| | ||||
* | Add extra checks from ↵ | Louise Crow | 2012-10-23 | -2/+4 |
| | | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb and some extra description. | |||
* | Adding new spec from ↵ | Louise Crow | 2012-10-23 | -2/+13 |
| | | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb | |||
* | Add an option to disable comments on a request | Robin Houston | 2012-09-19 | -0/+16 |
| | | | | Closes #30. | |||
* | Bugfix in spec. | Louise Crow | 2012-09-11 | -1/+1 |
| | ||||
* | Record a status update by someone other than the request owner as a request ↵ | Louise Crow | 2012-09-11 | -2/+12 |
| | | | | classification. | |||
* | Update references to point to the mySociety repo. | Louise Crow | 2012-08-29 | -1/+1 |
| | ||||
* | Now that external request followups can't be made and status can't be ↵ | Louise Crow | 2012-08-23 | -12/+104 |
| | | | | updated, don't show links or text that suggests they can. | |||
* | Don't allow status updates on external requests from the front end interface ↵ | Louise Crow | 2012-08-23 | -259/+331 |
| | | | | | | (they can still be changed from the admin interface). Final part of fix for #562. | |||
* | Don't show 'requester only' actions for an external request. | Louise Crow | 2012-08-23 | -0/+12 |
| | | | | Part of the fix for #562. | |||
* | Don't error on a request to followup an external request. | Louise Crow | 2012-08-23 | -0/+16 |
| | | | | Partial solution to #562. | |||
* | Use user_name to supply the user name for an internal or external request in ↵ | Louise Crow | 2012-08-22 | -32/+42 |
| | | | | | | the simple correspondence template used when a full request zip is downloaded. Fixes #561. | |||
* | Fix admin links in the case where an external request is viewed by an admin ↵ | Louise Crow | 2012-08-22 | -0/+12 |
| | | | | user. | |||
* | Don't send comment alerts for external requests. | Louise Crow | 2012-08-22 | -0/+10 |
| | ||||
* | Re-enable testing of comment links in emails. | Louise Crow | 2012-08-22 | -7/+2 |
| |