aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers/request_controller_spec.rb
Commit message (Collapse)AuthorAgeLines
* Admin users clicking confirmation linksRobin Houston2012-03-13-1/+1
| | | | Fixes #446. See issue for details.
* Test should not depend on nondeterministic orderRobin Houston2012-02-03-9/+12
| | | | | | | | | | | | | | | | | | Issue #409 seems to be another problem of the same type as #408, though with the important difference that the bug in this case is in the test suite rather than the code under test. RequestMailer sends alert emails warning of overdue requests. However it does not specify the order that these messages are sent in, but runs over the overdue requests in whatever order they are returned by a database query (that does not have an order by clause). Therefore it is not safe for the test code to assume that the alert mails will have been sent in a particular order: just as with #408 it seems that they were *usually* sent in the order assumed by the test code, but occasionally not -- which would result in sporadic test failures. Closes #409.
* Eliminate trailing spaces in test namesRobin Houston2012-02-03-2/+2
| | | | Really, what was that about?
* issue #351 reduxRobin Houston2012-02-01-4/+41
| | | | Corrected diagnosis, test & fix for issue #351. Fixes #351.
* Load all fixtures for all testsRobin Houston2012-01-31-19/+0
| | | | | | | | | The ad hoc specification of fixtures has been an ongoing source of bugs in the tests. The straw that broke the camel’s back is that 7c6eb09 requires the fixtures to be loaded in order (i.e. children before their parents), and it would have been a painful process to reorder all the dozens of different fixture lists, but the test system ought to be more reliable this way.
* Rate limitingRobin Houston2012-01-29-0/+53
| | | | | | Add the capability to specify a limit to the number of requests a user can make per day, which can be turned off for specific users in the admin interface.
* More test data, and fix testsRobin Houston2012-01-29-14/+21
| | | | | | Add some more test data, and fix the tests to accommodate both this new test data and the fact that raw emails are now correctly loaded into the test environment.
* Load all raw emails for testingRobin Houston2012-01-29-12/+12
| | | | | | | | | | | Previously there was just one raw email, and the test code relied on that fact. Generalise it to handle multiple raw emails. This change causes a number of tests to fail, because it exposes failures that should have happened when the second raw email was added but were masked by the fact that the text of this second raw email was never loaded. These failures will be fixed in the next commit.
* clearing the test censor rules in an ensure blockRobin Houston2012-01-27-7/+9
| | | | | | Might as well be consistent about clearing the test censor rules in an ensure block. This would only mean that an exception in one test is less likely to cause unrelated failures in another.
* More test data and a new testRobin Houston2012-01-27-3/+11
| | | | | This is a test for what I thought issue #370 might be. However this test is passing, so it isn’t that.
* Refactor test code so new test data can be addedRobin Houston2012-01-26-9/+50
| | | | | | | | Previously many of the tests made assumptions about the global structure of the test data set: the total number of requests, for example, or the names of all public bodies. This makes it difficult to add to the test data. This change is intended to make the test data easier to extend by eliminating such global assumptions.
* Fix #372Robin Houston2012-01-26-10/+26
|
* Correct test titleRobin Houston2012-01-25-1/+1
|
* Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkSeb Bacon2012-01-25-2/+11
|\ | | | | | | | | Conflicts: app/controllers/request_controller.rb
| * Fix sporadic test failureRobin Houston2012-01-24-1/+6
| | | | | | | | Another contribution to #361.
| * Merge branch 'wdtk' of github.com:sebbacon/alaveteli into wdtkRobin Houston2012-01-20-1/+11
| |\
| * | Be sure to restore RoutingFiltersRobin Houston2012-01-20-1/+5
| | | | | | | | | | | | | | | | | | There were some order-dependent test failures that turned out to be caused by the fact that the RoutingFilters were cleared and not subsequently restored, by some tests.
* | | Ensure short cache keys for interlock. Fixes #362Seb Bacon2012-01-24-0/+5
| | |
* | | Bug: we are causing a 500 when trying to raise 404 because the arguments to ↵Seb Bacon2012-01-24-0/+9
| |/ |/| | | | | the exception constructor are wrong.
* | Don't allow users to page beyond a certain number of results (because in ↵Seb Bacon2012-01-20-1/+11
|/ | | | large databases, the sorting of such large batches causes an extreme slowdown).
* Return a 404 for broken attachment urls. Fixes #351.Seb Bacon2012-01-18-0/+10
|
* Ensure request typeahead search is tested properly (and fix a validation error).Seb Bacon2012-01-18-0/+2
|
* Test belonging to commit a39f71ee21739eb754688f185c59c3a7f209aaaSeb Bacon2012-01-17-3/+3
|
* Actually do a proper ORed and partial match query, rather than fix parsing ↵Seb Bacon2012-01-17-2/+12
| | | | errors ad hoc as I find them that result from the workaround code. Fixes #328 (for good, I hope).
* Fix bug introduced in cec2c545e0a10e0641c4ee67839c88d872b394b8, related to ↵Seb Bacon2012-01-13-11/+11
| | | | issue #343.
* Show internal_review (and some other) items in the "unresolved" list. Fixes ↵Seb Bacon2012-01-13-0/+10
| | | | #344.
* Ensure we show "all requests" in order that they were last updated. FIxes #343.Seb Bacon2012-01-13-3/+6
|
* Fix further special character searches as per issue #328Seb Bacon2012-01-13-1/+2
|
* Further fix for issue #328.Seb Bacon2012-01-12-2/+2
|
* Further fix for issue #328.Seb Bacon2012-01-12-2/+15
|
* Fix problem with typeahead searches containing " - " characters and similar. ↵Seb Bacon2012-01-11-1/+17
| | | | Closes #328
* Don't give error when viewing HTML versions. Fixes issue #321Seb Bacon2012-01-08-0/+9
|
* Fix zip-attachment functionalitySeb Bacon2012-01-06-3/+3
|
* Ensure we only parse emails when needed by referring to a new last_parsed ↵Seb Bacon2011-12-21-2/+4
| | | | field on incoming_messages. Currently mails are always parsed just-in-time, but could be parsed as a queue in the future.
* Merge branch 'develop' into cache-foi-attachments-sebSeb Bacon2011-12-21-5/+4
|\ | | | | | | | | Conflicts: app/controllers/request_controller.rb
| * Don't do wildcard searches for partial matches in type ahead searches. ↵Seb Bacon2011-12-21-5/+4
| | | | | | | | Fixes #310.
* | Further improvements to attachment cachingSeb Bacon2011-12-13-4/+4
| |
* | WIP on caching attachmentsSeb Bacon2011-12-12-5/+65
|/
* Merge remote-tracking branch 'jpmckinney/pre1.9' into developSeb Bacon2011-11-24-9/+9
|\ | | | | | | | | Conflicts: spec/controllers/request_controller_spec.rb
| * call #first on from_addrs and to_addrs before calling #to_sJames McKinney2011-10-16-9/+9
| |
| * add encoding magic comments and fix pathsJames McKinney2011-10-16-0/+1
| |
* | Merge pull request #275 from jpmckinney/independent-specsSeb Bacon2011-11-22-15/+15
|\ \ | | | | | | Allow specs to run independently
| * | allow specs to run independentlyJames McKinney2011-10-16-16/+15
| |/
* / Fix occasional test failures due to two events happening in the same second ↵seb2011-11-21-2/+2
|/ | | | being treated as one for the purposes of caching. Fixes #290.
* fix fixtures order to avoid postgresql foreign key errorsJames McKinney2011-10-11-15/+15
|
* Merge branch 'release/0.4' into developSeb Bacon2011-10-10-0/+27
|\
| * Remove invalid collate argument for public body searchesDavid Cabo2011-09-23-0/+27
| | | | | | | | The existing bug wasn't catched by the tests, because it only fails when running in dev: otherwise all the classes are loaded before the search is done, and acts_as_xapian can find the provided 'request_collapse' argument, even if the PublicBody class doesn't define it, since all the init options end up together in acts_as_xapian.
* | Extra tests to sanity check UTF conversion (see issue #128 for background)Seb Bacon2011-10-10-0/+7
|/
* Simplify the "Send follow up" / "Reply" UI: only offer singe "Write a reply" ↵Seb Bacon2011-09-15-0/+16
| | | | option, and on the next page, give the user the opportunity to change the recipient from the default (the last valid sender of a message) to any other valid recipient. Closes #35.
* Provide ability to download zip file containing complete request. Closes #11Seb Bacon2011-09-13-1/+22
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-20 10:08:14 +0000