aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers/request_controller_spec.rb
Commit message (Collapse)AuthorAgeLines
* Remove interlock as it's not compatible with Rails 3 and is unmaintainedHenare Degan2013-01-18-13/+0
|
* Only serve up 'similar' pages up to the offset we use for list.Louise Crow2012-12-17-0/+8
|
* Adding mocking of incoming message id.Louise Crow2012-12-17-0/+1
|
* Rewrite specs that were in spec/controller/application_controller as ↵Louise Crow2012-12-17-0/+27
| | | | full-stack controller specs in the relevant controllers. It turns out that having spec blocks that reference the ApplicationController class directly i.e. "describe ApplicationController" can have unpredictable effects. actionpack's action_controller/test_case.rb rewrites rescue_action_without_handler on whatever it is included in, and if this is done on a controller class, and then directly on action controller, it can result in an infinite loop of recursive calls. This turns out to be the problem that was causing some tests in error_spec.rb to fail in Travis under Ruby 1.9.
* Merge branch 'hotfix/authenticate-and-expire-download-zips' into developLouise Crow2012-12-13-1/+11
|\
| * Check that a request is publicly visible before generating a download link.Louise Crow2012-12-13-1/+11
| |
* | Merge branch 'hotfix/no-html-conversion-for-hidden' into developLouise Crow2012-12-13-0/+15
|\|
| * Don't offer or allow viewing of an HTML version of a response attachment if ↵Louise Crow2012-12-13-0/+15
| | | | | | | | the request is hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently can produce image files that will then be publicly viewable directly from the webserver (see config/httpd.conf). If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server.
* | Reformat for line length, add the expected response code.Louise Crow2012-12-13-2/+9
| |
* | Don't offer or allow viewing of an HTML version of a request if it is ↵Louise Crow2012-12-13-0/+15
| | | | | | | | hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently produces image files that will then be publicly viewable. If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server.
* | Fix syntax of example email. The number of expected attachments was based on ↵Louise Crow2012-12-04-1/+1
| | | | | | | | the specific handling of a bad end boundary in tmail.
* | Use new function that copies existing xapian index in spec setup where a ↵Louise Crow2012-11-21-1/+1
|/ | | | clean copy of the xapian index with fixtures loaded is required.
* Add spec - currently failing due to typo.Louise Crow2012-10-23-0/+42
|
* Add extra checks from ↵Louise Crow2012-10-23-2/+4
| | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb and some extra description.
* Adding new spec from ↵Louise Crow2012-10-23-2/+13
| | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb
* Add an option to disable comments on a requestRobin Houston2012-09-19-0/+16
| | | | Closes #30.
* Bugfix in spec.Louise Crow2012-09-11-1/+1
|
* Record a status update by someone other than the request owner as a request ↵Louise Crow2012-09-11-2/+12
| | | | classification.
* Update references to point to the mySociety repo.Louise Crow2012-08-29-1/+1
|
* Now that external request followups can't be made and status can't be ↵Louise Crow2012-08-23-12/+104
| | | | updated, don't show links or text that suggests they can.
* Don't allow status updates on external requests from the front end interface ↵Louise Crow2012-08-23-259/+331
| | | | | | (they can still be changed from the admin interface). Final part of fix for #562.
* Don't show 'requester only' actions for an external request.Louise Crow2012-08-23-0/+12
| | | | Part of the fix for #562.
* Don't error on a request to followup an external request.Louise Crow2012-08-23-0/+16
| | | | Partial solution to #562.
* Use user_name to supply the user name for an internal or external request in ↵Louise Crow2012-08-22-32/+42
| | | | | | the simple correspondence template used when a full request zip is downloaded. Fixes #561.
* Fix admin links in the case where an external request is viewed by an admin ↵Louise Crow2012-08-22-0/+12
| | | | user.
* Don't send comment alerts for external requests.Louise Crow2012-08-22-0/+10
|
* Re-enable testing of comment links in emails.Louise Crow2012-08-22-7/+2
|
* Fix comment typo.Louise Crow2012-08-22-2/+2
|
* Don't pass a page param of less than one through to Xapian, treat it as a ↵Louise Crow2012-08-21-1/+8
| | | | param of 1. Fixes #557.
* Merge branch 'develop' of github.com:sebbacon/alaveteli into developLouise Crow2012-08-20-0/+6
|\
| * Fail with NotFound if request slug doesn't existRobin Houston2012-08-20-0/+6
| | | | | | | | Closes #554.
* | Use find_by_url_title! to raise ActiveRecordNotFound in upload response when ↵Louise Crow2012-08-20-0/+4
|/ | | | | | no record is found using url_title. Closes #553.
* When displaying attachments, only cache them out to files if they are ↵Louise Crow2012-08-16-198/+219
| | | | visible to everyone, so can be served up from a file cache without authentication.
* Merge branch 'develop' of github.com:sebbacon/alaveteli into developRobin Houston2012-06-23-24/+44
|\ | | | | | | | | | | | | | | Conflicts: Gemfile.lock script/handle-mail-replies script/handle-mail-replies.rb spec/controllers/request_controller_spec.rb
| * Only invalidate a user's cached requests when their *name* changes. ↵Seb Bacon2012-06-20-1/+7
| | | | | | | | Otherwise we issue PURGEs every time, for example, we send out email alerts.
| * Fix test to match current wordingSeb Bacon2012-06-19-1/+1
| |
| * Correctly name the person who has requested something for admin attentionSeb Bacon2012-06-19-0/+1
| |
| * Revert "Set a "Content-Disposition: attachment" header when downloading ↵Seb Bacon2012-06-15-9/+1
| | | | | | | | | | | | | | | | files. Closes #428" This reverts commit 506af7a640f63b17000ccfc5e1344bbc3039c913. See issue #428 for a discussion
| * Use POST rather than GET for tests (this matches better what the UI does)Seb Bacon2012-06-12-4/+4
| |
| * Ensure attention-requesting tests pass by faking a logged in userSeb Bacon2012-06-12-0/+5
| |
| * Make emails requesting admin attention appear to come from the user who ↵Seb Bacon2012-06-12-0/+10
| | | | | | | | requested the attention, not the user who made the original request.
* | Update tests to reflect code changesRobin Houston2012-06-07-0/+23
| | | | | | | | | | Since users must now be logged-in to report requests, the tests need to reflect this.
* | Update test for e3cfe550fe835c68b25d693abd40aedd954913b3Robin Houston2012-06-07-1/+1
|/ | | | | The wording that was changed by e3cfe550fe835c68b25d693abd40aedd954913b3 turns out to be relied on by one of the tests.
* Test for reporting functionalitySeb Bacon2012-05-24-0/+41
|
* Fix typo (introduced in commit cc023c67) that broke a testSeb Bacon2012-05-11-1/+1
|
* Don't cache results from pages with different locales using the same key. ↵Seb Bacon2012-05-04-1/+9
| | | | Fixes #454
* Don't ever create more than one entry for each URL that we want Varnish to ↵Seb Bacon2012-05-04-0/+10
| | | | purge.
* Modify InfoRequest stubs so they work with tests that iterate over the ↵Seb Bacon2012-05-02-0/+4
| | | | collection (e.g. `@user.info_requests.each`)
* More changes and refactoring to make purges work.Seb Bacon2012-04-20-13/+8
|
* Merge branch 'develop' into purge-requestsSeb Bacon2012-04-19-11/+10
|\ | | | | | | | | Conflicts: spec/controllers/request_controller_spec.rb
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-21 14:29:42 +0000