aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers/request_controller_spec.rb
Commit message (Collapse)AuthorAgeLines
* Remove extra "is invalid" message.Louise Crow2013-09-18-0/+8
| | | | Fixes #1101.
* Merge branch 'feature/hide-individual-responses' into rails-3-developLouise Crow2013-09-17-173/+201
|\ | | | | | | | | | | | | | | | | | | | | Conflicts: Gemfile app/views/admin_request/edit_outgoing.html.erb config/packages doc/CHANGES.md doc/INSTALL.md spec/models/info_request_spec.rb spec/models/public_body_spec.rb
| * Use 403, not 410, for hidden items.Louise Crow2013-09-16-4/+4
| | | | | | | | | | As @mhl points out, this more clearly indicates that they may come back at some point.
| * Use earlier factory_girl syntaxLouise Crow2013-09-16-4/+6
| |
| * Add public criteria for message event access methodsLouise Crow2013-09-16-7/+7
| | | | | | | | | | | | | | get_last_response_event and get_last_outgoing_event are used in various places to determine which events to link to, use in queries etc. Restrict them to refer to the last publicly visible event of the relevant type, and rename them to make that clear.
| * Restore the download for hidden requestsLouise Crow2013-09-16-6/+0
| | | | | | | | | | | | This was disabled for hidden requests as the download was by redirect, allowing people who have not been authenticated to conceivably access the download. We'll be moving to send_file instead, so can restore it.
| * Rewrite download specLouise Crow2013-09-16-45/+3
| | | | | | | | | | Make it an integration spec so we don't need to touch the internals so much.
| * Replace fixture-based spec with factory-based equivalent.Louise Crow2013-09-16-10/+6
| |
| * Use expectation for hidden responses more generally.Louise Crow2013-09-16-9/+9
| |
| * Fix request in spec for hidden attachments not being viewed.Louise Crow2013-09-16-2/+15
| | | | | | | | | | Add another spec for the same behaviour when an incoming message is hidden.
| * Add new code and specs for hiding attachments.Louise Crow2013-09-16-1/+106
| |
| * Refactor expectation into a methodLouise Crow2013-09-16-6/+8
| | | | | | | | Remove expectation of pdf contents - we're looking at the raw file.
| * Refactor prominence specs to use factories not fixtures.Louise Crow2013-09-16-116/+74
| |
| * Clarify specs.Louise Crow2013-09-16-5/+5
| | | | | | | | They refer to the case where the request itself is hidden.
* | Save cached columns once updated.Louise Crow2013-09-05-1/+1
|/
* Merge branch 'feature/localisation-fixes' into rails-3-developLouise Crow2013-07-29-4/+0
|\
| * Switch routing-filter (which takes locale out of the params and puts it in ↵Louise Crow2013-07-18-4/+0
| | | | | | | | the URL) off by default in model, controller, and helper tests. This means we can supply the locale as a param. Turn it on specifically for a couple of controller tests that test routing, and change other url localization tests into integration tests.
* | Merge remote-tracking branch ↵Louise Crow2013-07-23-5/+6
|\ \ | |/ |/| | | | | | | | | 'openaustralia_github/tests_set_described_state' into rails-3-develop Conflicts: spec/models/info_request_spec.rb
| * Now record a state_update event *whenever* a user classifies a requestMatthew Landauer2013-04-20-5/+6
| |
* | Better spec isolation - these specs require raw emails, so make sure they're ↵Louise Crow2013-06-10-0/+1
| | | | | | | | loaded.
* | Remove reference to incoming message from purge request test - it brings in ↵Louise Crow2013-06-07-1/+1
| | | | | | | | a requirement to have loaded the raw emails, which is tangential to what we're testing.
* | Allow the donation url to be configured. Closes #909.Louise Crow2013-06-07-0/+28
| |
* | Add some context blocks to group together tests with the same status.Louise Crow2013-06-07-57/+103
| |
* | Merge branch 'release/0.11' into rails-3-developLouise Crow2013-06-04-7/+32
|\ \
| * | Handle json requests for hidden info requests.Louise Crow2013-06-03-7/+32
| | |
* | | Merge remote-tracking branch ↵Louise Crow2013-06-04-86/+30
|\ \ \ | | | | | | | | | | | | 'openaustralia_github/more_info_on_report_request' into rails-3-develop
| * | | Move reporting actions to their own controllerMatthew Landauer2013-03-22-118/+30
| | | |
| * | | Extract methodMatthew Landauer2013-03-22-1/+1
| | | |
| * | | Only allow posts for reporting request. Don't try redirection when not logged inMatthew Landauer2013-03-22-3/+4
| | | |
| * | | Posted reason and message gets sent out in the emailMatthew Landauer2013-03-22-0/+7
| | | |
| * | | Only allow reporting a request when logged inMatthew Landauer2013-03-22-0/+24
| | | |
* | | | Merge remote-tracking branch ↵Louise Crow2013-06-04-2/+4
|\ \ \ \ | |_|/ / |/| | | | | | | 'openaustralia_github/inline_search_method_refactor' into rails-3-develop
| * | | Inline method InfoRequest.full_searchMatthew Landauer2013-03-25-2/+4
| |/ /
* | | Add a comment about the behaviour of the censor rulesMark Longair2013-05-24-0/+2
| | |
* | | The file_name on getting an attachment should be the display filenameMark Longair2013-05-24-1/+1
| | | | | | | | | | | | | | | Previously the behaviour would have been the same, since we weren't checking the filename so strictly.
* | | Make an attachment filename in test fixtures more difficultMark Longair2013-05-24-24/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes 'hello.txt' to 'hello-world.txt' in the incoming-request-two-same-name.email fixture. The reasoning for this change is that if there are no special characters in the filename then filename and display_filename will be the same and the tests won't pick up any confusion between the two. The test requests to :get_attachment and :get_attachment_as_html should get the display_filename rather than filename.
* | | Check that display_filename matches URL part number or fallbackMark Longair2013-05-24-15/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the display_filename of the attachment found from the URL part number doesn't match the passed in display_filename then the email may have been reparsed, causing a reordering. In that case, look to see if there is another attachment that uniquely matches that filename, and, if so, return that other attachment. If no matching uniquely matching filename is found, redirect to the incoming message, rather than returning a 404.
* | | All the tests in this group rely on having the xapian db - make it part of ↵Louise Crow2013-05-02-1/+1
| | | | | | | | | | | | the setup.
* | | The test "should work" relies on the xapian index existing - make sure this ↵Louise Crow2013-05-01-2/+4
| |/ |/| | | | | is true for all tests in this group.
* | Fixup test issue found with config.order = 'random:5549'Matthew Landauer2013-03-26-0/+2
|/
* Fix another order dependent test issueMatthew Landauer2013-03-19-0/+4
|
* Another order dependent test issue fixedMatthew Landauer2013-03-19-0/+2
|
* Reenable test now that we don't do HTML validation in the test suiteHenare Degan2013-03-16-9/+6
|
* Changed in 166b6d90bc2dc79536d8d2d145281fa340075735Henare Degan2013-03-15-1/+1
|
* Update to current matcher APIHenare Degan2013-03-15-2/+2
|
* Merge remote-tracking branch 'mysociety/develop' into rails-3-developHenare Degan2013-03-14-24/+81
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: Gemfile Gemfile.lock app/controllers/admin_request_controller.rb app/controllers/admin_track_controller.rb app/controllers/request_controller.rb app/controllers/services_controller.rb app/helpers/link_to_helper.rb app/mailers/request_mailer.rb app/models/application_mailer.rb app/models/info_request.rb app/views/admin_censor_rule/edit.html.erb app/views/admin_censor_rule/new.html.erb app/views/admin_public_body/_form.html.erb app/views/admin_public_body/_locale_selector.html.erb app/views/admin_public_body/_one_list.html.erb app/views/admin_public_body/edit.html.erb app/views/admin_public_body/list.html.erb app/views/admin_public_body/new.html.erb app/views/admin_request/_incoming_message_actions.html.erb app/views/admin_request/edit.html.erb app/views/admin_request/edit_comment.html.erb app/views/admin_request/edit_outgoing.html.erb app/views/admin_request/list.html.erb app/views/admin_request/list_old_unclassified.html.erb app/views/admin_request/show.html.erb app/views/admin_track/_some_tracks.html.erb app/views/admin_track/list.html.erb app/views/admin_user/edit.html.erb app/views/admin_user/list.html.erb app/views/admin_user/show.html.erb app/views/general/_footer.html.erb app/views/general/exception_caught.html.erb app/views/help/contact.html.erb app/views/layouts/default.html.erb app/views/public_body/_alphabet.html.erb app/views/request/_request_listing_single.html.erb app/views/request/_sidebar.html.erb app/views/request/new.html.erb app/views/request/show.html.erb app/views/request_mailer/external_response.rhtml app/views/request_mailer/fake_response.rhtml config/environment.rb config/environments/production.rb config/routes.rb spec/controllers/admin_censor_rule_controller_spec.rb spec/controllers/request_controller_spec.rb spec/controllers/track_controller_spec.rb spec/helpers/link_to_helper_spec.rb spec/mailers/request_mailer_spec.rb spec/models/info_request_spec.rb spec/spec_helper.rb spec/views/public_body/show.html.erb_spec.rb spec/views/request/show.html.erb_spec.rb vendor/plugins/rails_xss/lib/rails_xss/erubis.rb
| * Update URLs in spec now that custom url methods have been removed.Louise Crow2013-03-13-3/+3
| |
| * Now direct changes of state to error_message and requires_admin to a new ↵Matthew Landauer2013-03-06-15/+19
| | | | | | | | page asking for more info
| * Can also record a message when posting to RequestController#describe_stateMatthew Landauer2013-03-05-3/+21
| |
| * Remove code added previously because on the wrong trackMatthew Landauer2013-03-05-62/+0
| |
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-23 13:28:08 +0000