aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers
Commit message (Collapse)AuthorAgeLines
* Merge branch '2051-back-to-search' into rails-3-developGareth Rees2015-01-13-0/+45
|\
| * Add a “Back to search results” linkGareth Rees2015-01-13-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Store the search parameters in the flash when a search is made via the select_authority_path page. Stores the parameters for both POST and AJAX typeahead searches. The presence of stored search params renders the link on the PublicBodyController#show template. “keep”s the search params in PublicBodyController#show so that if the user clicks the browser’s back button the “Back to search results” link can still be rendered on the next search result they click. “keep”s all flash keys in ServicesController#other_country_message as it’s called through AJAX and ends up sweeping the flash. [1] [1] More details about this: http://mikenaberezny.com/2007/09/08/keep-the-flash-and-test-it-too/
* | Use a partial to render batch sent messageGareth Rees2015-01-13-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dropped the law_used_full interpolation: So I think there are two significant bits of context here. One is that the law_used_full attribute is derived from law_used, which in turn is set on InfoRequest initialisation based on the tags applied to the public body. So different requests in a batch could have different values for law_used_full - some of them might be to bodies that only accept environmental information requests. So using the value from the batch template is not really a good proxy for the whole collection. The second is that, in any case, the distinction between the two types of request is a UK-specific feature which should be moved to the UK theme (#2085). Given these two factors, I think the cleanest thing might be to drop law_used_full from this descriptive text, and just have it say "Your requests will be sent shortly", without specifying what law will be used. – Louise Crow (@crowbot)
* | Use a partial to render request sent messageGareth Rees2015-01-13-0/+10
|/
* Merge branch 'hotfix/0.20.0.2' into rails-3-developLouise Crow2015-01-07-0/+24
|\
| * Sanitize the blog contents0.20.0.2Louise Crow2014-12-22-0/+12
| |
| * Sanitize the contents of HTML attachments before displayLouise Crow2014-12-22-0/+12
| |
* | Remove focus tagLouise Crow2014-12-23-1/+1
| |
* | Merge branch 'restful-admin-routes' into rails-3-developLouise Crow2014-12-18-301/+511
|\ \
| * | Don't raise internal error when handling non-user or request rulesLouise Crow2014-12-18-43/+107
| | | | | | | | | | | | | | | | | | | | | Handle attempts to edit or destroy global or public body censor rules with a notice and a redirect. Closes #2009
| * | RESTful routing for admin censor rule actionsLouise Crow2014-12-18-213/+249
| | |
| * | RESTful routing for admin track actionsLouise Crow2014-12-18-4/+3
| | |
| * | Use RESTful routes for CRUD admin user actionsLouise Crow2014-12-18-5/+5
| | |
| * | Move admin incoming message actions to use RESTful routes.Louise Crow2014-12-18-5/+5
| | | | | | | | | | | | | | | So data changing actions require a POST and can be protected against CSRF.
| * | Move change request actions to use RESTful routes.Louise Crow2014-12-18-4/+6
| | |
| * | Move edit and update to RESTful routingLouise Crow2014-12-18-1/+1
| | |
| * | Move new action to use RESTful routing.Louise Crow2014-12-18-1/+1
| | |
| * | Use RESTful routing for indexLouise Crow2014-12-18-2/+2
| | |
| * | Make downloading a raw email a RESTful routeLouise Crow2014-12-18-3/+19
| | |
| * | Make marking an event as a clarification a RESTful routeLouise Crow2014-12-18-0/+41
| | |
| * | Make hide a RESTful action accessed via POSTLouise Crow2014-12-12-3/+3
| | |
| * | Make show_raw_email a RESTful action via GETLouise Crow2014-12-12-28/+14
| | | | | | | | | | | | | | | Move specs that involve receiving email and then viewing the interface to be integration specs, which is what they really are.
| * | RESTful routing for editing and updating commentsLouise Crow2014-12-12-0/+66
| | |
| * | Use RESTful routing for destroy actionLouise Crow2014-12-12-2/+2
| | |
| * | Use RESTful routing for index and show actionsLouise Crow2014-12-12-2/+2
| | |
* | | Merge branch 'admin-public-holiday-interface' into rails-3-developLouise Crow2014-12-18-0/+265
|\ \ \
| * | | Allow import of holidays from feed or built-in suggestionsLouise Crow2014-12-15-1/+75
| | | |
| * | | Add some inline editingLouise Crow2014-12-15-7/+31
| | | |
| * | | Add create actionLouise Crow2014-12-15-0/+39
| | | |
| * | | Add new actionLouise Crow2014-12-15-0/+15
| | | |
| * | | Add basic destroy action.Louise Crow2014-12-15-0/+25
| | | |
| * | | Add basic update action.Louise Crow2014-12-15-2/+38
| | | |
| * | | Add basic edit actionLouise Crow2014-12-15-1/+21
| | | |
| * | | Add index method for listing existing holidaysLouise Crow2014-12-15-0/+32
| | | |
* | | | Refactor the application of masks and censor rules to messages.Louise Crow2014-12-15-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Seems more logical to make this one method that figures out what to do based on file type. Plus, incoming message does so many things, it seemed like having these related methods be separate would make them easier to read and understand. Also, email, mobile and login substitution texts weren't being translated. Finally, I think passing the censor rules and masks as arguments is a first step in some more decoupling of models.
* | | | Enforce a lifetime on session cookiesLouise Crow2014-12-12-0/+29
| |/ / |/| | | | | | | | | | | | | | Problem described in http://seclists.org/fulldisclosure/2013/Sep/145 Pattern taken from https://www.coffeepowered.net/2013/09/26/rails-session-cookies/
* | | Merge branch 'catch-openuri-timeout-errors' into rails-3-developLouise Crow2014-12-11-1/+5
|\ \ \ | |/ / |/| |
| * | Use exception notification for third party url errorsLouise Crow2014-11-14-1/+5
| | | | | | | | | | | | Include URL and error in notification and log.
* | | Merge branch '1666-related-requests-search' into rails-3-developGareth Rees2014-12-08-0/+17
|\ \ \ | |_|/ |/| |
| * | RequestController#search_typaahead limit resultsGareth Rees2014-11-11-0/+11
| | | | | | | | | | | | Use the per_page parameter to limit the results returned
| * | RequestController#search_typeahead filter by bodyGareth Rees2014-11-11-0/+6
| | | | | | | | | | | | | | | Action now supports the `request_from` param as per the Xapian filtering system to filter search typeaheads by public body
* | | Merge branch '1965-censor-rule-creation-failure' into rails-3-developLouise Crow2014-12-01-0/+471
|\ \ \
| * | | Use instance variable for CensorRule in #destroyGareth Rees2014-11-19-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | Easier to check against the assigned variable, but the spec still fails because an internal error is raised if the rule is not associated with a User or InfoRequest
| * | | Set the form URL to POST to in #createGareth Rees2014-11-19-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | Direct the (re-rendered) form at the correct route for the association (or use the generic route if the rule is being created for some other reason)
| * | | Associate censor rule with something in #createGareth Rees2014-11-19-0/+48
| | | | | | | | | | | | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id)
| * | | Set the form URL to POST to in #newGareth Rees2014-11-19-0/+17
| | | | | | | | | | | | | | | | | | | | Direct the form at the correct route for the association (or use the generic route if the rule is being created for some other reason)
| * | | Associate censor rule with something in #newGareth Rees2014-11-19-0/+12
| | | | | | | | | | | | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id)
| * | | Initialize a new CensorRule in #newGareth Rees2014-11-19-0/+5
| | | |
| * | | Specs for AdminCensorRuleController#updateGareth Rees2014-11-19-0/+126
| | | | | | | | | | | | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do!
| * | | Specs for AdminCensorRuleController#createGareth Rees2014-11-19-0/+111
| | | | | | | | | | | | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do!