aboutsummaryrefslogtreecommitdiffstats
path: root/spec/controllers
Commit message (Collapse)AuthorAgeLines
* Use flash[:error] for error conditionGareth Rees2014-11-18-1/+3
| | | Also use double quotes rather than string escaping
* Add specs to cover unsuccessful creationGareth Rees2014-11-17-1/+12
|
* Add coverage to ensure ‘new’ templates are renderedGareth Rees2014-11-17-0/+11
|
* Add expectation to #index specGareth Rees2014-11-17-0/+1
| | | | The spec that covers AdminPublicBodyCategoriesController#index did not have an expectation
* Redirect to #edit after updatingGareth Rees2014-11-17-0/+14
| | | | | On an unsuccessful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should render the #edit action.
* Redirect to #edit after updatingGareth Rees2014-11-17-0/+16
| | | | | | | On a successful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should redirect to the #edit action rather than simply rendering the ‘edit’ template. Fixes https://github.com/mysociety/alaveteli/issues/1977
* Provide expectations for controller specsGareth Rees2014-11-17-4/+17
| | | | This commit adds expectations to AdminPublicBodyCategoriesController and AdminPublicBodyHeadingsController edit actions
* Redirect /help to /help/aboutGareth Rees2014-11-05-0/+9
| | | | Shouldn't really 404 on an important/accessible URL
* Merge branch 'issues/1457-close-change-request-without-email' into ↵Louise Crow2014-10-30-16/+26
|\ | | | | | | rails-3-develop
| * Remove redirect to trailing slash URL.Louise Crow2014-10-30-6/+1
| | | | | | | | | | Introduced in 4f501309ade230f65f4ba45e1d0161e89587d755 but no longer needed as we don't proxy the admin interface.
| * Allow closure of a change request without sending an email.Louise Crow2014-10-30-10/+25
| |
* | Merge branch 'issues/1778-send-message' into rails-3-developGareth Rees2014-10-17-2/+18
|\ \
| * | Extract initial and followup sending from modelGareth Rees2014-10-17-2/+18
| | |
* | | Merge branch 'spam_address_routing' into rails-3-developGareth Rees2014-10-14-2/+2
|\ \ \
| * | | Add admin prefix to spam_addresses resourcesGareth Rees2014-10-10-2/+2
| |/ /
* | | Merge branch 'issues/1830-batch-request-user-filter' into rails-3-developGareth Rees2014-10-14-1/+11
|\ \ \
| * | | User profile option to filter requests by statusGareth Rees2014-10-14-1/+11
| |/ / | | | | | | | | | | | | Filters on `latest_status` because filtering by `status` searches all states a request has ever been in.
* | | Merge branch 'issues/222-category-editing-add-order-interface' into ↵Louise Crow2014-10-14-7/+447
|\ \ \ | |/ / |/| | | | | rails-3-develop
| * | fixup! Use RESTful routing.Louise Crow2014-10-09-7/+7
| | |
| * | Use RESTful routing.Louise Crow2014-09-26-73/+74
| | |
| * | fixup! Basic category admin screenLouise Crow2014-09-25-8/+0
| | |
| * | fixup! Replace existing PublicBodyCategories functionality with db models ↵Louise Crow2014-09-24-8/+11
| | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading
| * | fixup! New heading associations should be added on category create.Louise Crow2014-09-24-7/+4
| | |
| * | fixup! Add actions for reordering public body headings and categories.Louise Crow2014-09-24-12/+35
| | |
| * | fixup! Add actions for reordering public body headings and categories.Louise Crow2014-09-24-20/+24
| | |
| * | fixup! Remove dependence on default public bodies.Louise Crow2014-09-24-26/+36
| | |
| * | New heading associations should be added on category create.Louise Crow2014-09-22-0/+16
| | |
| * | Add actions for reordering public body headings and categories.Louise Crow2014-09-22-1/+89
| | |
| * | Remove dependence on default public bodies.Louise Crow2014-09-22-16/+18
| | | | | | | | | | | | Seems like this could trip us up later. Use factories instead, they're more clearly associated with tests.
| * | Allow deletion of public body categories with associatied bodieslizconlan2014-09-22-9/+1
| | |
| * | Reinstate automatic loading of categories on get if no categories definedlizconlan2014-09-22-1/+6
| | |
| * | Enable admins to link public body categories to headingslizconlan2014-09-22-0/+14
| | |
| * | Restrict category_tag edits to empty public body categorieslizconlan2014-09-22-0/+18
| | |
| * | Basic category admin screenlizconlan2014-09-22-0/+275
| |/
* / Add an action to run the checksGareth Rees2014-09-25-0/+30
|/
* Whitelist UserController#signup params0.19.0.3hotfix/0.19.0.3Gareth Rees2014-09-09-0/+10
| | | | Protects from mass-assignment exploit attempts
* Merge branch 'issues/1181-destroy-external-request' into rails-3-developGareth Rees2014-08-21-0/+6
|\
| * Use different flash for fully_destroy external InfoRequestGareth Rees2014-08-18-0/+6
| | | | | | | | Uses a different flash message to avoid trying to fetch a non existent user record
* | Add honeypot spam protection to body update formGareth Rees2014-08-21-2/+16
|/ | | | | Intercepts the request and redirects to the homepage if the comment field is filled in on the public body update form.
* Use since_event_id to restrict query, not just data displayed.Louise Crow2014-08-11-1/+10
| | | | | Allow the same params (since_event_id, since_date) for both formats. There doesn't seem to be a particular reason not to treat them the same.
* whitespacelizconlan2014-07-28-436/+434
| | | | includes various code layout fixes
* Sending an invalid state value to add_correspondence now aborts the entire ↵lizconlan2014-07-28-29/+40
| | | | operation
* Refactor state update API, better error handlinglizconlan2014-07-28-10/+12
| | | | Filters; more 403s, fewer 500s; added logging; less duplication
* Extend add_correspondence API method to optionally accept a state paramlizconlan2014-07-28-79/+135
|
* New API method for updating request statelizconlan2014-07-28-277/+357
|
* Merge branch 'issues/1415-bulk-update-public-bodies' into rails-3-developGareth Rees2014-06-25-0/+17
|\
| * Add PublicBodyController#list_all_csv specsGareth Rees2014-06-06-0/+17
| | | | | | | | | | - Shouldn't include non-visible bodies - Shouldn't include internal admin bodies
* | Handle unhelpful stemmingGareth Rees2014-06-25-1/+1
| | | | | | | | | | | | | | Stemming returns 'bore' as the word to highlight which can't be matched in the original phrase. Also removes duplicates from the results
* | Use regex based highlightingGareth Rees2014-06-25-2/+1
| |
* | Rename XXX comments with TODO:Gareth Rees2014-06-10-20/+20
|/ | | | Picks these up in `rake notes` and adds semantic meaning