Commit message (Collapse) | Author | Age | Lines | ||
---|---|---|---|---|---|
... | |||||
* | | Merge remote-tracking branch 'mysociety/develop' into rails-3-spike | Matthew Landauer | 2013-01-04 | -58/+129 | |
|\| | | | | | | | | | | | | | | | | | | | | | Conflicts: Gemfile.lock Rakefile app/controllers/request_controller.rb lib/tasks/rspec.rake spec/controllers/services_controller_spec.rb spec/spec_helper.rb spec/views/request/_after_actions.rhtml_spec.rb | ||||
| * | Only serve up 'similar' pages up to the offset we use for list. | Louise Crow | 2012-12-17 | -0/+8 | |
| | | |||||
| * | Adding mocking of incoming message id. | Louise Crow | 2012-12-17 | -0/+1 | |
| | | |||||
| * | Rewrite specs that were in spec/controller/application_controller as ↵ | Louise Crow | 2012-12-17 | -56/+71 | |
| | | | | | | | | full-stack controller specs in the relevant controllers. It turns out that having spec blocks that reference the ApplicationController class directly i.e. "describe ApplicationController" can have unpredictable effects. actionpack's action_controller/test_case.rb rewrites rescue_action_without_handler on whatever it is included in, and if this is done on a controller class, and then directly on action controller, it can result in an infinite loop of recursive calls. This turns out to be the problem that was causing some tests in error_spec.rb to fail in Travis under Ruby 1.9. | ||||
| * | Merge branch 'hotfix/authenticate-and-expire-download-zips' into develop | Louise Crow | 2012-12-13 | -1/+11 | |
| |\ | |||||
| | * | Check that a request is publicly visible before generating a download link. | Louise Crow | 2012-12-13 | -1/+11 | |
| | | | |||||
| * | | Merge branch 'hotfix/no-html-conversion-for-hidden' into develop | Louise Crow | 2012-12-13 | -0/+15 | |
| |\| | |||||
| | * | Don't offer or allow viewing of an HTML version of a response attachment if ↵ | Louise Crow | 2012-12-13 | -0/+15 | |
| | | | | | | | | | | | | the request is hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently can produce image files that will then be publicly viewable directly from the webserver (see config/httpd.conf). If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | ||||
| * | | Reformat for line length, add the expected response code. | Louise Crow | 2012-12-13 | -2/+9 | |
| | | | |||||
| * | | Don't offer or allow viewing of an HTML version of a request if it is ↵ | Louise Crow | 2012-12-13 | -0/+15 | |
| | | | | | | | | | | | | hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently produces image files that will then be publicly viewable. If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | ||||
* | | | No need to specify extension when testing particular template is rendered | Matthew Landauer | 2013-01-04 | -7/+7 | |
| | | | |||||
* | | | response.status now returns an integer | Matthew Landauer | 2013-01-04 | -6/+6 | |
| | | | |||||
* | | | Get rid of resetting of ActionController::Routing::Routes.filters | Matthew Landauer | 2013-01-04 | -28/+0 | |
| | | | |||||
* | | | integrate_views is render_views RSpec 2 | Henare Degan | 2012-12-11 | -47/+47 | |
| | | | |||||
* | | | The with_locale has been removed in Globalize3 | Henare Degan | 2012-12-11 | -9/+9 | |
| | | | | | | | | | | | | | | | | | | I think Globalize is supposed to pick up the locale from I18n anyway so I don't know if these are needed. I think I still haven't done the right thing but it's time to move on. | ||||
* | | | Remove interlock as it's not compatible with Rails 3 and is unmaintained | Henare Degan | 2012-12-11 | -13/+0 | |
| | | | |||||
* | | | Switch to new method name | Henare Degan | 2012-12-11 | -9/+9 | |
|/ / | |||||
* | | Fix syntax of example email. The number of expected attachments was based on ↵ | Louise Crow | 2012-12-04 | -1/+1 | |
| | | | | | | | | the specific handling of a bad end boundary in tmail. | ||||
* | | Add option to load_file_fixture to specify that the file contents should ↵ | Louise Crow | 2012-12-04 | -2/+1 | |
| | | | | | | | | just be loaded as binary. | ||||
* | | The absence of an API key in an API request should be a permission denied ↵ | Louise Crow | 2012-12-03 | -6/+19 | |
| | | | | | | | | error, so that notification emails don't get sent. | ||||
* | | Make regex for space normalization more unambiguous - it's the spaces at the ↵ | Louise Crow | 2012-11-29 | -55/+55 | |
| | | | | | | | | beginning and end of the whole string that we want to strip entirely, not at the beginning and end of each line (interpretation of ^ and $ is subject to default multiline behaviour of the regexp interpreter) | ||||
* | | Give the implicit default locale in a URL without locale precedence over the ↵ | Louise Crow | 2012-11-28 | -0/+50 | |
| | | | | | | | | session in the case where the default locale is not being included in URLs. This allows the user to return to the default locale. | ||||
* | | Use new function that copies existing xapian index in spec setup where a ↵ | Louise Crow | 2012-11-21 | -55/+55 | |
| | | | | | | | | clean copy of the xapian index with fixtures loaded is required. | ||||
* | | Merge branch 'release/0.6.8' into develop | Louise Crow | 2012-11-12 | -11/+11 | |
|\| | | | | | | | | | Conflicts: lib/world_foi_websites.rb | ||||
| * | Stub configuration in order to setup test cases. Previous direct setting of ↵ | Louise Crow | 2012-11-12 | -11/+11 | |
| | | | | | | | | config values was not isolated to particular tests. | ||||
* | | Pass a hash of params to foi_fragment_cache_path in spec, as is passed in ↵ | Louise Crow | 2012-11-08 | -1/+8 | |
|/ | | | | actual usage. | ||||
* | Add some specs for admin_current_user | Louise Crow | 2012-10-30 | -0/+27 | |
| | |||||
* | Pull out a bit of shared setup code. | Louise Crow | 2012-10-30 | -13/+11 | |
| | |||||
* | Don't load raw emails before the frontpage specs - they don't rely on the ↵ | Louise Crow | 2012-10-29 | -1/+0 | |
| | | | | raw email table being populated, and it's slow. | ||||
* | Make spec a bit more generic in terms of what we're expecting. Really what ↵ | Louise Crow | 2012-10-29 | -12/+28 | |
| | | | | we want is reverse date order on the events, and only successful responses or initial sending. | ||||
* | Mock xapian call for specs that are really for orthogonal things like ↵ | Louise Crow | 2012-10-29 | -0/+16 | |
| | | | | localization. | ||||
* | Move search spec to search group. | Louise Crow | 2012-10-29 | -10/+7 | |
| | |||||
* | Split up specs for frontpage and search. | Louise Crow | 2012-10-29 | -25/+27 | |
| | |||||
* | Add spec - currently failing due to typo. | Louise Crow | 2012-10-23 | -0/+42 | |
| | |||||
* | Add extra checks from ↵ | Louise Crow | 2012-10-23 | -2/+4 | |
| | | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb and some extra description. | ||||
* | Adding new spec from ↵ | Louise Crow | 2012-10-23 | -2/+13 | |
| | | | | https://github.com/mysociety/alaveteli/commit/cdb1c9420169ed6eafdd4e57ca21e1809c95e5cb | ||||
* | Handle the case where the blog feed already has querystring parameters. | Louise Crow | 2012-10-11 | -0/+16 | |
| | |||||
* | add magic encoding comment to specs | James McKinney | 2012-10-10 | -1/+3 | |
| | |||||
* | Extract configuration with defaults into one module | Matthew Landauer | 2012-09-25 | -1/+1 | |
| | |||||
* | Add an option to disable comments on a request | Robin Houston | 2012-09-19 | -0/+27 | |
| | | | | Closes #30. | ||||
* | Paginate the timeline to allow it to render in a reasonable amount of time. ↵ | Louise Crow | 2012-09-13 | -12/+33 | |
| | | | | In order to avoid sorting large numbers of objects in order to get the right order of combined events across the two model types, get the overall order first from the database and then populate the slice we're interested in. | ||||
* | Merge branch 'develop' of ssh://git.mysociety.org/data/git/public/alaveteli ↵ | Louise Crow | 2012-09-11 | -20/+72 | |
|\ | | | | | | | into develop | ||||
| * | Add a since_date parameter to the API feed | Robin Houston | 2012-09-10 | -0/+15 | |
| | | |||||
| * | Update other tests | Robin Houston | 2012-09-07 | -20/+25 | |
| | | | | | | | | Update the other API tests to take account of the changed error behaviour. | ||||
| * | API errors should be JSON | Robin Houston | 2012-09-04 | -0/+32 | |
| | | | | | | | | | | | | | | | | | | | | The API was returning Rails (HTML) errors for certain error conditions, which is inconvenient because it makes it difficult for the client to extract the error message. This patch changes add_correspondence to return JSON errors (still with suitable HTTP status codes) for two common exceptional conditions, and adds tests. | ||||
* | | Bugfix in spec. | Louise Crow | 2012-09-11 | -1/+1 | |
| | | |||||
* | | Record a status update by someone other than the request owner as a request ↵ | Louise Crow | 2012-09-11 | -2/+12 | |
|/ | | | | classification. | ||||
* | Merge branch 'feature/repo-move' into develop | Louise Crow | 2012-08-30 | -8/+8 | |
|\ | |||||
| * | Update references to point to the mySociety repo. | Louise Crow | 2012-08-29 | -8/+8 | |
| | | |||||
* | | Fix basic admin interface in case where external request without username is ↵ | Louise Crow | 2012-08-29 | -0/+5 | |
|/ | | | | being displayed. |