Commit message (Collapse) | Author | Age | Lines | ||
---|---|---|---|---|---|
... | |||||
* | | | | Enforce a lifetime on session cookies | Louise Crow | 2014-12-12 | -0/+29 | |
| |/ / |/| | | | | | | | | | | | | | | Problem described in http://seclists.org/fulldisclosure/2013/Sep/145 Pattern taken from https://www.coffeepowered.net/2013/09/26/rails-session-cookies/ | ||||
* | | | Merge branch 'catch-openuri-timeout-errors' into rails-3-develop | Louise Crow | 2014-12-11 | -1/+5 | |
|\ \ \ | |/ / |/| | | |||||
| * | | Use exception notification for third party url errors | Louise Crow | 2014-11-14 | -1/+5 | |
| | | | | | | | | | | | | Include URL and error in notification and log. | ||||
* | | | Merge branch '1666-related-requests-search' into rails-3-develop | Gareth Rees | 2014-12-08 | -0/+17 | |
|\ \ \ | |_|/ |/| | | |||||
| * | | RequestController#search_typaahead limit results | Gareth Rees | 2014-11-11 | -0/+11 | |
| | | | | | | | | | | | | Use the per_page parameter to limit the results returned | ||||
| * | | RequestController#search_typeahead filter by body | Gareth Rees | 2014-11-11 | -0/+6 | |
| | | | | | | | | | | | | | | | Action now supports the `request_from` param as per the Xapian filtering system to filter search typeaheads by public body | ||||
* | | | Merge branch '1965-censor-rule-creation-failure' into rails-3-develop | Louise Crow | 2014-12-01 | -0/+471 | |
|\ \ \ | |||||
| * | | | Use instance variable for CensorRule in #destroy | Gareth Rees | 2014-11-19 | -2/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Easier to check against the assigned variable, but the spec still fails because an internal error is raised if the rule is not associated with a User or InfoRequest | ||||
| * | | | Set the form URL to POST to in #create | Gareth Rees | 2014-11-19 | -0/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Direct the (re-rendered) form at the correct route for the association (or use the generic route if the rule is being created for some other reason) | ||||
| * | | | Associate censor rule with something in #create | Gareth Rees | 2014-11-19 | -0/+48 | |
| | | | | | | | | | | | | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id) | ||||
| * | | | Set the form URL to POST to in #new | Gareth Rees | 2014-11-19 | -0/+17 | |
| | | | | | | | | | | | | | | | | | | | | Direct the form at the correct route for the association (or use the generic route if the rule is being created for some other reason) | ||||
| * | | | Associate censor rule with something in #new | Gareth Rees | 2014-11-19 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id) | ||||
| * | | | Initialize a new CensorRule in #new | Gareth Rees | 2014-11-19 | -0/+5 | |
| | | | | |||||
| * | | | Specs for AdminCensorRuleController#update | Gareth Rees | 2014-11-19 | -0/+126 | |
| | | | | | | | | | | | | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do! | ||||
| * | | | Specs for AdminCensorRuleController#create | Gareth Rees | 2014-11-19 | -0/+111 | |
| | | | | | | | | | | | | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do! | ||||
| * | | | Specs for AdminCensorRuleController#destroy | Gareth Rees | 2014-11-18 | -0/+65 | |
| | | | | | | | | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do! | ||||
| * | | | Specs for AdminCensorRuleController#edit | Gareth Rees | 2014-11-18 | -0/+23 | |
| | | | | |||||
| * | | | Specs for AdminCensorRuleController#new | Gareth Rees | 2014-11-18 | -0/+48 | |
| | | | | |||||
* | | | | Merge branch 'issues/1969-inconsistent-public-body-admin-interface' into ↵ | Gareth Rees | 2014-11-19 | -7/+16 | |
|\ \ \ \ | | | | | | | | | | | | | | | | rails-3-develop | ||||
| * | | | | Remove restricton on deleting PublicBodyHeadings with associated ↵ | lizconlan | 2014-11-19 | -3/+6 | |
| | | | | | | | | | | | | | | | | | | | | PublicBodyCategories | ||||
| * | | | | Fix view bug preventing PublicBodyCategories being deleted in the admin ↵ | lizconlan | 2014-11-19 | -4/+10 | |
| | |/ / | |/| | | | | | | | | | | interface | ||||
* | | | | Remove stubs of removed method | Gareth Rees | 2014-11-18 | -5/+0 | |
| |/ / |/| | | | | | | | | | | | | | | | | | PublicBodyCategory#load_categories no longer exists, so don't try to stub it. Fixes https://github.com/mysociety/alaveteli/issues/1970 | ||||
* | | | Use flash[:error] for error condition | Gareth Rees | 2014-11-18 | -1/+3 | |
| | | | | | | | | | Also use double quotes rather than string escaping | ||||
* | | | Add specs to cover unsuccessful creation | Gareth Rees | 2014-11-17 | -1/+12 | |
| | | | |||||
* | | | Add coverage to ensure ‘new’ templates are rendered | Gareth Rees | 2014-11-17 | -0/+11 | |
| | | | |||||
* | | | Add expectation to #index spec | Gareth Rees | 2014-11-17 | -0/+1 | |
| | | | | | | | | | | | | The spec that covers AdminPublicBodyCategoriesController#index did not have an expectation | ||||
* | | | Redirect to #edit after updating | Gareth Rees | 2014-11-17 | -0/+14 | |
| | | | | | | | | | | | | | | | On an unsuccessful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should render the #edit action. | ||||
* | | | Redirect to #edit after updating | Gareth Rees | 2014-11-17 | -0/+16 | |
| | | | | | | | | | | | | | | | | | | | | | On a successful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should redirect to the #edit action rather than simply rendering the ‘edit’ template. Fixes https://github.com/mysociety/alaveteli/issues/1977 | ||||
* | | | Provide expectations for controller specs | Gareth Rees | 2014-11-17 | -4/+17 | |
|/ / | | | | | | | This commit adds expectations to AdminPublicBodyCategoriesController and AdminPublicBodyHeadingsController edit actions | ||||
* | | Redirect /help to /help/about | Gareth Rees | 2014-11-05 | -0/+9 | |
| | | | | | | | | Shouldn't really 404 on an important/accessible URL | ||||
* | | Merge branch 'issues/1457-close-change-request-without-email' into ↵ | Louise Crow | 2014-10-30 | -16/+26 | |
|\ \ | | | | | | | | | | rails-3-develop | ||||
| * | | Remove redirect to trailing slash URL. | Louise Crow | 2014-10-30 | -6/+1 | |
| | | | | | | | | | | | | | | | Introduced in 4f501309ade230f65f4ba45e1d0161e89587d755 but no longer needed as we don't proxy the admin interface. | ||||
| * | | Allow closure of a change request without sending an email. | Louise Crow | 2014-10-30 | -10/+25 | |
| |/ | |||||
* | | Merge branch 'issues/1778-send-message' into rails-3-develop | Gareth Rees | 2014-10-17 | -2/+18 | |
|\ \ | |||||
| * | | Extract initial and followup sending from model | Gareth Rees | 2014-10-17 | -2/+18 | |
| | | | |||||
* | | | Merge branch 'spam_address_routing' into rails-3-develop | Gareth Rees | 2014-10-14 | -2/+2 | |
|\ \ \ | |||||
| * | | | Add admin prefix to spam_addresses resources | Gareth Rees | 2014-10-10 | -2/+2 | |
| |/ / | |||||
* | | | Merge branch 'issues/1830-batch-request-user-filter' into rails-3-develop | Gareth Rees | 2014-10-14 | -1/+11 | |
|\ \ \ | |||||
| * | | | User profile option to filter requests by status | Gareth Rees | 2014-10-14 | -1/+11 | |
| |/ / | | | | | | | | | | | | | Filters on `latest_status` because filtering by `status` searches all states a request has ever been in. | ||||
* | | | Merge branch 'issues/222-category-editing-add-order-interface' into ↵ | Louise Crow | 2014-10-14 | -7/+447 | |
|\ \ \ | |/ / |/| | | | | | rails-3-develop | ||||
| * | | fixup! Use RESTful routing. | Louise Crow | 2014-10-09 | -7/+7 | |
| | | | |||||
| * | | Use RESTful routing. | Louise Crow | 2014-09-26 | -73/+74 | |
| | | | |||||
| * | | fixup! Basic category admin screen | Louise Crow | 2014-09-25 | -8/+0 | |
| | | | |||||
| * | | fixup! Replace existing PublicBodyCategories functionality with db models ↵ | Louise Crow | 2014-09-24 | -8/+11 | |
| | | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading | ||||
| * | | fixup! New heading associations should be added on category create. | Louise Crow | 2014-09-24 | -7/+4 | |
| | | | |||||
| * | | fixup! Add actions for reordering public body headings and categories. | Louise Crow | 2014-09-24 | -12/+35 | |
| | | | |||||
| * | | fixup! Add actions for reordering public body headings and categories. | Louise Crow | 2014-09-24 | -20/+24 | |
| | | | |||||
| * | | fixup! Remove dependence on default public bodies. | Louise Crow | 2014-09-24 | -26/+36 | |
| | | | |||||
| * | | New heading associations should be added on category create. | Louise Crow | 2014-09-22 | -0/+16 | |
| | | | |||||
| * | | Add actions for reordering public body headings and categories. | Louise Crow | 2014-09-22 | -1/+89 | |
| | | |