| Commit message (Collapse) | Author | Age | Lines |
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
app/controllers/admin_public_body_controller.rb
app/views/admin_public_body/import_csv.rhtml
spec/controllers/admin_public_body_controller_spec.rb
spec/models/info_request_spec.rb
|
| |
| |
| |
| | |
Fix spec to accommodate validation of text presence.
|
| | |
|
| |
| |
| |
| | |
created with the text of the rule.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
apply rules from its public body.
|
| |
| |
| |
| | |
Apply global rules to every request, not regex rules.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Is there actually any point in tests of this sort? It is not testing
that anything works as intended, only that a particular SQL string is
passed to the database -- and surely the only way that string could
have been discovered for test purposes was essentially to copy it
from the code under test.
It seems to me that the only real function of a test of this sort
is to make it more difficult to modify the code under test.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also make the InfoRequest#is_old_unclassified? method a little
more conservative, by returning false only is the is_external?
method returns true. This makes it subtly inconsistent with
InfoRequest.find_old_unclassified, but it is better I think to
be subtly inconsistent than to risk breaking things that used
to work.
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Conflicts:
app/controllers/admin_request_controller.rb
config/httpd.conf
spec/models/info_request_spec.rb
|
| |
| |
| |
| | |
cache the associated objects for an info request in the file cache which will be served up without authentication.
|
| |
| |
| |
| | |
problem testing template results
|
|/
|
|
| |
CensorRules that aren't attached to a User or Request or Public Body (but don't expose this in the admin UI). Fixes #33
|
|
|
|
|
| |
Replace another constant with a computed value, so we can accommodate
new test data without spuriously failing.
|
|
|
|
|
|
|
| |
Remove another dependency of a test on the aggregate set of test
data, part of a long-term programme to make it easier to add test data
(and required here because recently-added test data was causing these
tests to fail!)
|
| |
|
| |
|
|
|
|
| |
be sent
|
|
|
|
| |
via the search UI
|
|
|
|
| |
endlessly polling the Varnish server until its fixed). Administrators should check the logs for failed purges.
|
|
|
|
| |
test always passes
|
| |
|
| |
|
|
|
|
| |
defined
|
| |
|
| |
|
|
|
|
| |
Really, what was that about?
|
|
|
|
|
| |
Change the test assertions so they give more informative errors
when they fail -- as they sometimes do: see issue #408.
|
|
|
|
| |
Update test to take account of change 76fd5f9.
|
|
|
|
|
|
|
|
|
| |
The ad hoc specification of fixtures has been an ongoing source
of bugs in the tests. The straw that broke the camel’s back is
that 7c6eb09 requires the fixtures to be loaded in order (i.e.
children before their parents), and it would have been a painful
process to reorder all the dozens of different fixture lists,
but the test system ought to be more reliable this way.
|
|
|
|
|
|
|
|
|
|
|
| |
Previously there was just one raw email, and the test code relied
on that fact. Generalise it to handle multiple raw emails.
This change causes a number of tests to fail, because it exposes
failures that should have happened when the second raw email was
added but were masked by the fact that the text of this second
raw email was never loaded. These failures will be fixed in the
next commit.
|
|
|
|
|
| |
This was added for temporary debugging purposes, and ought to have
been removed.
|
|
|
|
|
|
|
|
| |
Previously many of the tests made assumptions about the global
structure of the test data set: the total number of requests, for
example, or the names of all public bodies. This makes it difficult
to add to the test data. This change is intended to make the test
data easier to extend by eliminating such global assumptions.
|
|
|
|
| |
Towards #361
|
|
|
|
|
| |
This fixes (at least) one of the failures in #361, viz
spec/controllers/admin_request_controller_spec.rb spec/models/xapian_spec.rb
|
|
|
|
| |
This test was failing if run after, for example, general_controller_spec.rb.
|
|\ |
|
| |\ |
|
| | | |
|
| |/
| |
| |
| |
| | |
...by forcing the IncomingMessage to be re-parsed after we have
edited it.
|
|/ |
|
|\
| |
| |
| | |
example at issue #327, at least in part.
|
| |
| |
| |
| | |
every time
|
| |
| |
| |
| | |
issue #343.
|
|/
|
|
| |
getting the body a few times before failing. May be related to issue #333 and #339
|
|
|
|
| |
date, resulting in incoming_messages all apparently being sent on January 1, 2000)
|
|
|
|
| |
regenerate attachments cache when necessary)
|