Commit message (Collapse) | Author | Age | Lines | |
---|---|---|---|---|
* | Save cached columns once updated. | Louise Crow | 2013-09-05 | -1/+6 |
| | ||||
* | Don't dirty every attribute in checking for whitespace. | Louise Crow | 2013-09-05 | -15/+31 |
| | | | | | | | Check to see if the stripped version is different before setting it on the record. If we don't do this, the subsequent call to write_attribute in Globalize3 which uses attribute_will_change! means we're storing versions when there hasn't really been any change. | |||
* | Improve calculation of PublicBody statistics columns | Mark Longair | 2013-08-20 | -0/+66 |
| | | | | | | | | | | | | | | | | On PublicBody, we don't need to update info_requests_count because that's already done with :counter_cache. On the other hand, info_requests_successful_count and info_requests_not_held_count can't be updated easily with counter_cache (since they need conditions to be attached). Instead we update them in post_save and post_destroy, as suggested here: http://blog.douglasfshearer.com/post/17495285851/custom-counter-cache-with-conditions This also adds tests to ensure that the after_(save|destroy) callbacks are called and that they modify the counts correctly. | |||
* | Merge branch 'feature/further-request-event-fixes' into rails-3-develop | Louise Crow | 2013-08-15 | -3/+50 |
|\ | ||||
| * | Make admin edits affect info_request_event described_states. | Louise Crow | 2013-08-15 | -0/+21 |
| | | | | | | | | | | | | | | Make sure that admin edits changing the described state of an info request are reflected in the latest_status and status values of info request events so that the info requests are retrieved correctly in status-based searches. | |||
| * | Allow 'edit' and 'status_update' calculated states to propagate. | Louise Crow | 2013-08-15 | -3/+29 |
| | | | | | | | | | | | | | | | | Update test expectations and add further test to explicitly show that we want the described status from a status update to be propagated to a preceding response, as well as being filled in in the status update itself (which is mostly to deal with the case where there isn't a preceding response). Make those changes to calculate_event_states | |||
* | | Update tests for changes to fixture file. | Louise Crow | 2013-08-14 | -14/+18 |
|/ | ||||
* | Merge branch 'feature/localisation-fixes' into rails-3-develop | Louise Crow | 2013-07-29 | -1/+7 |
|\ | ||||
| * | Prepare the xapian database before running tests that rely on it existing. | Louise Crow | 2013-07-29 | -0/+5 |
| | | ||||
| * | Add loading of raw emails - test depends on this. | Louise Crow | 2013-07-23 | -0/+1 |
| | | ||||
| * | Use AlaveteliConfiguration wrapper in test so we can be more specific about ↵ | Louise Crow | 2013-07-23 | -1/+1 |
| | | | | | | | | the method to be stubbed and avoid side effects. | |||
* | | Prevent erroneous internal error messages with multibyte characters under ↵ | Louise Crow | 2013-07-25 | -1/+12 |
| | | | | | | | | ruby 1.8 by using mb_chars for length comparison - it counts multibyte characters. | |||
* | | Merge remote-tracking branch ↵ | Louise Crow | 2013-07-23 | -0/+203 |
|\ \ | |/ |/| | | | | | | | | | 'openaustralia_github/tests_set_described_state' into rails-3-develop Conflicts: spec/models/info_request_spec.rb | |||
| * | How we would handle event states if we added a state_update event whenever a ↵ | Matthew Landauer | 2013-04-20 | -17/+41 |
| | | | | | | | | user classifies a request | |||
| * | Access events in tests as an array | Matthew Landauer | 2013-04-20 | -42/+43 |
| | | ||||
| * | Test case that shows up event states bug in ↵ | Matthew Landauer | 2013-04-18 | -1/+18 |
| | | | | | | | | https://www.whatdotheyknow.com/details/request/family_support_worker_redundanci | |||
| * | Test case that shows up event states bug in ↵ | Matthew Landauer | 2013-04-18 | -0/+20 |
| | | | | | | | | https://www.whatdotheyknow.com/request/human_rights_and_deprivation_of | |||
| * | Testing an internal review | Matthew Landauer | 2013-04-18 | -109/+131 |
| | | ||||
| * | Add test for events in another situation | Matthew Landauer | 2013-04-15 | -0/+28 |
| | | ||||
| * | Check event_type in tests | Matthew Landauer | 2013-04-15 | -0/+7 |
| | | ||||
| * | Test event states when follow up message is sent | Matthew Landauer | 2013-04-15 | -0/+24 |
| | | ||||
| * | Added a comment | Matthew Landauer | 2013-04-15 | -0/+2 |
| | | ||||
| * | Test events some more | Matthew Landauer | 2013-04-15 | -5/+22 |
| | | ||||
| * | Test event status after a response is received | Matthew Landauer | 2013-04-15 | -12/+39 |
| | | ||||
| * | Test to check event states after initial request is sent | Matthew Landauer | 2013-04-15 | -0/+14 |
| | | ||||
* | | Merge branch 'hotfix/0.11.0.14' into rails-3-develop | Louise Crow | 2013-06-19 | -0/+10 |
|\ \ | ||||
| * | | Allow the HTML display of the body of an email to handle the case where the ↵0.11.0.14hotfix/0.11.0.14 | Louise Crow | 2013-06-19 | -0/+10 |
| | | | | | | | | | | | | body is only quoted text and there is no subject. | |||
* | | | Fix typo | Louise Crow | 2013-06-12 | -1/+1 |
| | | | ||||
* | | | Make sure raw emails are loaded before running test. | Louise Crow | 2013-06-12 | -0/+4 |
| | | | ||||
* | | | Merge branch 'hotfix/0.11.0.7' into rails-3-develop | Louise Crow | 2013-06-10 | -24/+36 |
|\| | | | | | | | | | | | | | | Conflicts: spec/models/info_request_spec.rb | |||
| * | | Cope with replying to a message with a missing or empty Subject | Mark Longair | 2013-06-07 | -0/+12 |
| | | | | | | | | | | | | | | | | | | Conflicts: spec/models/info_request_spec.rb | |||
* | | | Merge branch 'hotfix/0.11.0.4' into rails-3-develop | Louise Crow | 2013-06-10 | -3/+14 |
|\| | | ||||
| * | | Merge branch 'release/0.11'0.11.0.3 | Louise Crow | 2013-06-04 | -951/+115 |
| |\ \ | ||||
| * | | | Use class instead of type - type is removed in Ruby 1.90.9.0.6hotfix/0.9.0.6 | Louise Crow | 2013-05-28 | -1/+1 |
| | | | | ||||
| * | | | Return a string from user.name always to avoid any complications with other ↵hotfix/0.9.0.5 | Louise Crow | 2013-05-28 | -3/+14 |
| | | | | | | | | | | | | | | | | functions calling gsub on the result. SafeBuffer won't work with gsub until Rails 3.2 https://github.com/rails/rails/commit/b4a6e2f8442ceda118367f9a61c38af754be1cbf | |||
| * | | | Bugfix for the case where a suspended user sends a contact message. Their ↵hotfix/0.9.0.2 | Louise Crow | 2013-05-07 | -1/+15 |
| | | | | | | | | | | | | | | | | name (with the '(account suspended)' suffix) is marked by the translation call as HTML safe, so escapes the angled brackets when they are appended to it in the contact mailer code. Use string interpolation instead. | |||
| * | | | Set locale with I18n rather than through globalize | Matthew Landauer | 2013-04-02 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: app/controllers/general_controller.rb | |||
| * | | | When force_ssl is true make links in emails https | Matthew Landauer | 2013-04-02 | -7/+22 |
| | | | | ||||
* | | | | Handle request for json for an external request. Closes #973. | Louise Crow | 2013-06-07 | -0/+29 |
| | | | | ||||
* | | | | Merge branch 'release/0.11' into rails-3-develop | Louise Crow | 2013-06-04 | -0/+8 |
|\ \ \ \ | | |/ / | |/| | | ||||
| * | | | Parse the 'to' address as if on a real mail to trigger quoted string encoding. | Louise Crow | 2013-06-03 | -0/+8 |
| | | | | ||||
* | | | | Merge remote-tracking branch ↵ | Louise Crow | 2013-06-04 | -51/+52 |
|\ \ \ \ | | | | | | | | | | | | | | | | 'openaustralia_github/inline_search_method_refactor' into rails-3-develop | |||
| * | | | | Inline method InfoRequest.full_search | Matthew Landauer | 2013-03-25 | -51/+52 |
| | |_|/ | |/| | | ||||
* | | | | Merge remote-tracking branch ↵ | Louise Crow | 2013-06-04 | -0/+26 |
|\ \ \ \ | | | | | | | | | | | | | | | | 'openaustralia_github/fix_search_highlight_non_ascii_characters' into rails-3-develop | |||
| * | | | | Fix word highlighting in acts_as_xapian for non-ascii characters. Fixes #505 | Matthew Landauer | 2013-03-25 | -0/+26 |
| |/ / / | ||||
* | | | | Merge branch 'feature/new-string-for-translation' into rails-3-develop | Louise Crow | 2013-05-30 | -1/+18 |
|\ \ \ \ | |_|/ / |/| | | | ||||
| * | | | Allow the default text of an internal review request to be translated. | Louise Crow | 2013-05-07 | -1/+18 |
| |/ / | ||||
* | | | When extracting attachments for an incoming message and getting the body of ↵ | Louise Crow | 2013-05-29 | -0/+43 |
| | | | | | | | | | | | | the main part in order to look for uuencoded text, make sure that we're getting that main part from the reparsed attachments, and not getting an obsolete attachment. Fixes #958. | |||
* | | | Remove erroneous test name | Louise Crow | 2013-05-28 | -1/+1 |
| | | | ||||
* | | | Avoid an FoiAttachment validation failure under Rails 3 | Mark Longair | 2013-05-16 | -0/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Under Rails 3, the uudecoded FoiAttachment in this test fails validation at the self.save! in IncomingMessage.parse_raw_email, although the FoiAttachment has been correctly created and saved to the database in _uudecode_and_save_attachments. Forcing a reload=true on self.foi_attachments fixes this. Thanks to Louise Crow for finding the fix for this problem. |