aboutsummaryrefslogtreecommitdiffstats
path: root/spec/models
Commit message (Collapse)AuthorAgeLines
* Send batch requests as a cron job.Louise Crow2013-12-04-0/+40
|
* Simplify return value, set sent_at in create_batch!Louise Crow2013-12-04-13/+34
|
* Use public bodies not requests in find_existingLouise Crow2013-12-04-6/+8
| | | | The requests may not have been created at this point.
* Split the creation of a batch and the associated requests.Louise Crow2013-12-04-10/+9
| | | | We're going to want to actually create and send the requests later.
* Add the specific salutations to each request.Louise Crow2013-12-04-0/+22
| | | | | | Also, wrap model creation in a transaction and do the message sending separately - we may ultimately want to do this outside the request cycle.
* Add check for double submission.Louise Crow2013-12-04-0/+45
|
* Make method names for finding existing objects clearerLouise Crow2013-12-04-1/+1
| | | | | They're not finding by the existing object, they're finding an existing object.
* Add InfoRequestBatch model.Louise Crow2013-12-04-0/+21
| | | | | Re-annotate models. Index InfoRequestBatches by user - we'll display the batches for a user when they view their own requests.
* Batch users don't have a daily limit.Louise Crow2013-12-04-0/+7
| | | | | | | It doesn't make logical sense that they would. However I am preserving the ability to make batch requests as a separate thing from not having a daily limit - I think batch sending requires a (perhaps marginally) bigger level of trust.
* Add some specs for existing exceeded_limit? behaviourLouise Crow2013-12-04-0/+24
|
* Create a placeholder salutation for a batch request template.Louise Crow2013-12-04-2/+12
|
* Handle the application of censor rules to a batch request template.Louise Crow2013-12-04-0/+6
|
* Add a batch_request_template flagLouise Crow2013-12-04-0/+13
| | | | | | A virtual attribute to use to customise some info request behaviours when we are using one request as a template for creating multiple requests.
* Merge branch 'move-plugins-out-of-vendor-plugins' into rails-3-developMark Longair2013-12-03-1/+1
|\
| * Move acts_as_xapian out of vendor/pluginsMark Longair2013-11-29-1/+1
| | | | | | | | | | This includes making making sure that xapiandbs directory is moved with this version of the code.
* | Move getting recent requests into a helper method.Louise Crow2013-11-25-0/+37
| |
* | Move getting similar requests to the InfoRequest model.Louise Crow2013-11-25-2/+19
|/
* Don't include public bodies tagged 'test' in public body statisticsMark Longair2013-11-07-0/+44
| | | | | | | | | | In the initial release of public body statistics to WhatDoTheyKnow a public body only intended for testing ("mySociety Test Quango") was included in the statistics. This commit causes public bodies tagged with "test" to be excluded from the public body statistics page. Fixes #1115.
* For percentage stats, exclude hidden or unclassified requestsMark Longair2013-11-05-0/+30
| | | | | | | | The WDTK volunteers pointed out that it's not fair to include hidden requests in the denominator, since they're typically hidden for a good reason (e.g. being vexatious, spam, etc.), and we have no information about those that are awaiting_description (i.e. unclassified) so they should be excluded as well.
* Add a info_requests_visible_classified_count column to PublicBodyMark Longair2013-11-05-20/+21
| | | | | | This counts only those info requests that have prominence 'normal' (i.e. are not hidden) and are not 'awaiting_description' (i.e. that they have had some basic status classification).
* Update the helpful model schema annotationsMark Longair2013-11-01-19/+22
| | | | These are regenerated with "bundle exec annotate"
* Add data to test example given in #1143Louise Crow2013-10-21-11/+14
| | | | This causes several specs to fail.
* Merge remote-tracking branch 'origin/fix-aborted-transaction' into ↵Louise Crow2013-10-07-19/+4
|\ | | | | | | rails-3-develop
| * Factor out a 'with_duplicate_xapian_job_creation' helperMark Longair2013-10-07-19/+4
| | | | | | | | | | | | | | | | | | | | In a subsequent commit, we will want to wrap an additional section of code with the addition and removal of a hook that creates a duplicate xapian job, so it's useful for this to be factored out. This commit introduces a 'with_duplicate_xapian_job_creation' method that can be passed a block which will be run with the forced duplicate xapian job creation.
* | Merge branch 'feature/email-subject-cleanup' into rails-3-developLouise Crow2013-10-07-0/+10
|\ \ | |/ |/|
| * Move special case to whatdotheyknow-themeLouise Crow2013-10-04-0/+10
| | | | | | | | | | Apart from anything else, we don't want translators to have to worry about the special case text. See https://github.com/mysociety/whatdotheyknow-theme/commit/2078febca5181ce3b1a9c0fae0123ae5f6448718 for the corresponding change to whatdotheyknow-theme.
* | Fix upcasing of a non-US-ASCII first letter under Ruby 1.8Mark Longair2013-10-04-0/+11
| | | | | | | | | | | | | | | | In the rare circumstance that someone created a public body whose name started with a lower case letter outside [a-z] with Alaveteli running under Ruby 1.8, the letter would not be upcased correctly before saving to the first_letter column. This commit fixes that by using a Unicode-aware upcase function.
* | Add to fixtures a public body with an accented initial letterMark Longair2013-10-04-7/+7
|/ | | | | | | | | | | | | | | | | This adds a public body called "Åčçèñtéd Authority" in the Czech locale (cs) so that we can create tests that exercise, for example, searching based on an initial letter that has a multi-byte representation in UTF-8. An old test for "add mass tags" in the admin needed to be updated since it implicitly assumed that all the public bodies in the fixtures had translations in the :en locale. The tests for loading CSV files of public bodies also needed to be updated, since they were assuming that public body names only contained letters in [A-Za-z ]. Since Unicode character classes aren't easily available in Ruby 1.8 and it makes little difference to the test, the character class is replaced by '.'.
* Fix typoLouise Crow2013-09-19-1/+1
|
* Handle salutations with regexp special characters.Louise Crow2013-09-19-0/+10
| | | | Fixes #1104.
* Merge branch 'hotfix/0.13.0.3' into rails-3-developLouise Crow2013-09-18-0/+37
|\
| * Restrict old_unclassified methods to normal prominence.0.13.0.3hotfix/0.13.0.3Louise Crow2013-09-18-0/+37
| | | | | | | | Fixes #1082.
* | Merge branch 'feature/hide-individual-responses' into rails-3-developLouise Crow2013-09-17-11/+622
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: Gemfile app/views/admin_request/edit_outgoing.html.erb config/packages doc/CHANGES.md doc/INSTALL.md spec/models/info_request_spec.rb spec/models/public_body_spec.rb
| * | Exclude hidden responses when calculating old_unclassifiedLouise Crow2013-09-16-7/+13
| | | | | | | | | | | | | | | Make old_unclassified_params method consistent with last_public_response_event and associated methods.
| * | Only include public messages in who_can_followup_toLouise Crow2013-09-16-0/+37
| | |
| * | Add public criteria for message event access methodsLouise Crow2013-09-16-2/+61
| | | | | | | | | | | | | | | | | | | | | get_last_response_event and get_last_outgoing_event are used in various places to determine which events to link to, use in queries etc. Restrict them to refer to the last publicly visible event of the relevant type, and rename them to make that clear.
| * | InfoRequestEvent.indexed_by_search consults OutgoingMessage.Louise Crow2013-09-16-1/+18
| | |
| * | Move indexed_by_search to MessageProminenceLouise Crow2013-09-16-2/+23
| | | | | | | | | | | | Add some tests that it's working on the outgoing message model.
| * | Add some tests for user_can_view? on outgoing message.Louise Crow2013-09-16-0/+52
| | |
| * | Don't index hidden and requester_only incoming messages.Louise Crow2013-09-16-0/+64
| | |
| * | Adding prominence_reason to IncomingMessage.Louise Crow2013-09-16-0/+1
| | |
| * | Refactor common logic about prominence and access.Louise Crow2013-09-16-1/+1
| | | | | | | | | | | | Move it into the Ability module.
| * | Add a method to ask whether a user can view an incoming message.Louise Crow2013-09-16-0/+57
| | |
| * | Add response_event helperLouise Crow2013-09-16-0/+12
| | | | | | | | | | | | | | | Add a convenience method for getting the 'response' event associated with an incoming message.
| * | Add prominence to incoming message.Louise Crow2013-09-16-0/+21
| | |
| * | Re-annotate models with database fieldsLouise Crow2013-09-16-0/+264
| | |
* | | Merge branch 'feature/issue-902-fix' into rails-3-developLouise Crow2013-09-17-0/+22
|\ \ \
| * | | Allow a unicode-only title in validationLouise Crow2013-09-17-0/+22
| | | |
* | | | Merge branch 'feature/issue-555-fix' into rails-3-developLouise Crow2013-09-17-0/+31
|\ \ \ \ | |/ / / |/| | |
| * | | Add a failing spec for handling a race conditionLouise Crow2013-09-17-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec uses a hook method to simulate the insertion of an acts_as_xapian_job in another process for the model. Credit to: http://stackoverflow.com/questions/2017587/simulating-race-conditions-in-rspec-unit-tests Conflicts: vendor/plugins/acts_as_xapian/lib/acts_as_xapian.rb