Commit message (Collapse) | Author | Age | Lines | |
---|---|---|---|---|
* | modernise redirect tests by converting to using url helpers | Matthew Landauer | 2013-01-29 | -7/+7 |
| | ||||
* | When matching the body of an email to a regex cast it to a string | Matthew Landauer | 2013-01-29 | -6/+6 |
| | ||||
* | Email address returned from mail doesn't have the name part anymore | Matthew Landauer | 2013-01-29 | -9/+9 |
| | ||||
* | Pass string to paremeter in test | Matthew Landauer | 2013-01-29 | -1/+1 |
| | ||||
* | When mocking ActsAsXapian can't use mock_model because it's not a model | Matthew Landauer | 2013-01-29 | -2/+2 |
| | ||||
* | Reset Actionmailer deliveries on controller tests. Apparently rspec isn't ↵ | Matthew Landauer | 2013-01-29 | -0/+26 |
| | | | | now doing this automatically | |||
* | Replace use of have_text with contain from webrat or match | Matthew Landauer | 2013-01-29 | -34/+34 |
| | ||||
* | Copy basic_auth_login spec_helper from rspec 1 to 2 | Matthew Landauer | 2013-01-29 | -0/+6 |
| | ||||
* | Correct use of have_selector in b37586c7165afb7b3447dfe2780169a88cb0a942. | Matthew Landauer | 2013-01-29 | -9/+17 |
| | ||||
* | Replace use of have_tag with have_selector from webrat | Matthew Landauer | 2013-01-28 | -26/+26 |
| | ||||
* | Correctly recognise a fragment for html validation | Matthew Landauer | 2013-01-28 | -1/+1 |
| | ||||
* | Use preceding slash on paths to fixtures files | Matthew Landauer | 2013-01-28 | -4/+4 |
| | ||||
* | Calling TMail::Mail#base64_decode does not modify the mail object so doesn't ↵ | Matthew Landauer | 2013-01-28 | -1/+1 |
| | | | | do anything as used here | |||
* | Fix indentation only | Henare Degan | 2013-01-27 | -6/+6 |
| | ||||
* | This API seems to have changed so just check if there's a body | Henare Degan | 2013-01-27 | -1/+1 |
| | ||||
* | path helper should be html safe and fix up view test for rspec 2 | Matthew Landauer | 2013-01-25 | -3/+3 |
| | ||||
* | Merge branch 'rails_xss' into rails-3-spike | Matthew Landauer | 2013-01-25 | -1/+57 |
|\ | | | | | | | | | | | | | | | Conflicts: Gemfile Gemfile.lock config/environment.rb lib/i18n_fixes.rb | |||
| * | Merge remote-tracking branch 'mysociety/develop' into rails_xss | Matthew Landauer | 2013-01-15 | -212/+1486 |
| |\ | ||||
| | * | As we're validating filename with validates_presence_of, which doesn't allow ↵ | Louise Crow | 2013-01-14 | -1/+12 |
| | | | | | | | | | | | | blanks, ensure_filename! should populate a default filename on a blank filename, as well as on nil. | |||
| | * | Handle case where info request doesn't have a user_name | Louise Crow | 2013-01-07 | -0/+7 |
| | | | ||||
| * | | Fix translations with interpolations to correctly handle safe_html | Matthew Landauer | 2013-01-15 | -0/+38 |
| | | | ||||
* | | | In rails 3 sendmail is passed the destination of the email on the ↵ | Matthew Landauer | 2013-01-25 | -1/+6 |
| | | | | | | | | | | | | commandline. Also, monkeypatch not needed anymore | |||
* | | | Rename mailer method to avoid naming conflict in Rails 3 | Matthew Landauer | 2013-01-25 | -2/+2 |
| | | | ||||
* | | | Remove timezone monkeypatch fixes because they're not necessary in Rails 3 ↵ | Matthew Landauer | 2013-01-25 | -0/+5 |
| | | | | | | | | | | | | anymore | |||
* | | | read_attribute does timezone conversion in rails 3. So using ↵ | Matthew Landauer | 2013-01-25 | -13/+8 |
| | | | | | | | | | | | | attributes_before_type_cast instead | |||
* | | | Copied load_test_categories from rspec 2 to rspec 3 helper file | Matthew Landauer | 2013-01-25 | -0/+8 |
| | | | ||||
* | | | Disable routing filter in tests by using RoutingFilter.active rather than ↵ | Matthew Landauer | 2013-01-25 | -27/+18 |
| | | | | | | | | | | | | writing to ActionController::Routing::Routes.filters | |||
* | | | Change method name as it conflicts with globalize3 method name | Henare Degan | 2013-01-24 | -1/+1 |
| | | | ||||
* | | | Oops. accidently deleted file in last commit | Matthew Landauer | 2013-01-23 | -0/+1 |
| | | | ||||
* | | | Fixes to ApplicationMailer tests in Rails 3 | Matthew Landauer | 2013-01-23 | -16/+11 |
| | | | ||||
* | | | Fix deprecation warnings | Henare Degan | 2013-01-23 | -3/+3 |
| | | | | | | | | | | | | | | | * Errors#on have been deprecated * Errors#[] now always returns an Array | |||
* | | | Change syntax - this looks like a test to me | Henare Degan | 2013-01-23 | -1/+1 |
| | | | ||||
* | | | In 447e4af we started adding the error to each attribute so start testing each | Henare Degan | 2013-01-23 | -4/+10 |
| | | | ||||
* | | | Add some more xapian methods for models/xapian_spec.rb | Henare Degan | 2013-01-18 | -20/+21 |
| | | | ||||
* | | | Merge remote-tracking branch 'mysociety/develop' into rails-3-spike | Matthew Landauer | 2013-01-04 | -109/+227 |
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: Gemfile.lock Rakefile app/controllers/request_controller.rb lib/tasks/rspec.rake spec/controllers/services_controller_spec.rb spec/spec_helper.rb spec/views/request/_after_actions.rhtml_spec.rb | |||
| * | | Only serve up 'similar' pages up to the offset we use for list. | Louise Crow | 2012-12-17 | -0/+8 |
| | | | ||||
| * | | Add a spec to test that mailin does not produce any output. This is ↵ | Louise Crow | 2012-12-17 | -0/+21 |
| | | | | | | | | | | | | important as under some MTA configurations, any output will result in a bounce message being sent to the original mail sender. | |||
| * | | Adding mocking of incoming message id. | Louise Crow | 2012-12-17 | -0/+1 |
| | | | ||||
| * | | Rewrite specs that were in spec/controller/application_controller as ↵ | Louise Crow | 2012-12-17 | -56/+71 |
| | | | | | | | | | | | | full-stack controller specs in the relevant controllers. It turns out that having spec blocks that reference the ApplicationController class directly i.e. "describe ApplicationController" can have unpredictable effects. actionpack's action_controller/test_case.rb rewrites rescue_action_without_handler on whatever it is included in, and if this is done on a controller class, and then directly on action controller, it can result in an infinite loop of recursive calls. This turns out to be the problem that was causing some tests in error_spec.rb to fail in Travis under Ruby 1.9. | |||
| * | | Merge branch 'hotfix/authenticate-and-expire-download-zips' into develop | Louise Crow | 2012-12-13 | -2/+28 |
| |\ \ | ||||
| | * | | Check that a request is publicly visible before generating a download link. | Louise Crow | 2012-12-13 | -1/+11 |
| | | | | ||||
| | * | | Only offer download links on publicly visible requests | Louise Crow | 2012-12-13 | -1/+17 |
| | | | | ||||
| * | | | Merge branch 'hotfix/no-html-conversion-for-hidden' into develop | Louise Crow | 2012-12-13 | -0/+15 |
| |\| | | ||||
| | * | | Don't offer or allow viewing of an HTML version of a response attachment if ↵ | Louise Crow | 2012-12-13 | -0/+15 |
| | | | | | | | | | | | | | | | | the request is hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently can produce image files that will then be publicly viewable directly from the webserver (see config/httpd.conf). If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | |||
| * | | | Reformat for line length, add the expected response code. | Louise Crow | 2012-12-13 | -2/+9 |
| | | | | ||||
| * | | | Don't offer or allow viewing of an HTML version of a request if it is ↵ | Louise Crow | 2012-12-13 | -0/+15 |
| | | | | | | | | | | | | | | | | hidden, or requester_only. Google docs viewer won't be able to access it, and our own conversion process currently produces image files that will then be publicly viewable. If necessary we can revisit this code to enable admins and requesters to view the HTML version created by our own conversion without adding these files to a path that is served directly by the web server. | |||
| * | | | Wrap specs on the extraction of RFC-822 headers in code that sets the ENV ↵ | Louise Crow | 2012-12-11 | -50/+61 |
| | | | | | | | | | | | | | | | | timezone. TMail renders headers using localtime, which is not ideal, but we're migrating away from it anyway, so I'm not sure it's worth delving into the internals of TMail to fix it. | |||
* | | | | Moved two needed helper functions from spec/spec_helper.rb.rails2 | Matthew Landauer | 2013-01-04 | -0/+23 |
| | | | | ||||
* | | | | No need to specify extension when testing particular template is rendered | Matthew Landauer | 2013-01-04 | -7/+7 |
| | | | | ||||
* | | | | response.status now returns an integer | Matthew Landauer | 2013-01-04 | -6/+6 |
| | | | |