aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeLines
* Use flash[:error] for error conditionGareth Rees2014-11-18-1/+3
| | | Also use double quotes rather than string escaping
* Add specs to cover unsuccessful creationGareth Rees2014-11-17-1/+12
|
* Add coverage to ensure ‘new’ templates are renderedGareth Rees2014-11-17-0/+11
|
* Add expectation to #index specGareth Rees2014-11-17-0/+1
| | | | The spec that covers AdminPublicBodyCategoriesController#index did not have an expectation
* Redirect to #edit after updatingGareth Rees2014-11-17-0/+14
| | | | | On an unsuccessful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should render the #edit action.
* Redirect to #edit after updatingGareth Rees2014-11-17-0/+16
| | | | | | | On a successful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should redirect to the #edit action rather than simply rendering the ‘edit’ template. Fixes https://github.com/mysociety/alaveteli/issues/1977
* Provide expectations for controller specsGareth Rees2014-11-17-4/+17
| | | | This commit adds expectations to AdminPublicBodyCategoriesController and AdminPublicBodyHeadingsController edit actions
* Merge branch 'issues/1437-apple-mail-attachment-parsing' into rails-3-developGareth Rees2014-11-10-0/+13962
|\
| * Add fix for Apple Mail with attachments Gareth Rees2014-11-04-0/+13817
| |
| * Add some specs to MailBackendGareth Rees2014-11-04-0/+145
| |
* | Redirect /help to /help/aboutGareth Rees2014-11-05-0/+9
|/ | | | Shouldn't really 404 on an important/accessible URL
* Merge branch 'hotfix/0.19.0.9' into rails-3-developLouise Crow2014-10-31-6/+9
|\
| * Comment out spec which sends an invalid utf-8 param.0.19.0.9hotfix/0.19.0.9Louise Crow2014-10-31-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original error `ActionView::Template::Error` that this spec was written to represent (#1406) occurred under ruby 1.8 when the decoded non-utf-8 string was used in the locale switcher on the 'not found' error page to generate a url for the alternative locales. Under Ruby >= 1.9, the error thrown in that situation is an `invalid byte sequence in UTF-8` error, thrown in the same place - the locale switcher. However, no error seems to be thrown when the same param is used in a request in production. The upgrade to Rails 3.2.20 causes `String.split` to be called on the request path in `actionpack/lib/action_dispatch/middleware/static.rb` in order to check for attempts to access files outside the `public` directory. This means that under Ruby >= 1.9, an `invalid byte sequence in UTF-8` error will be thrown there in running this spec. I think a possible solution is to use the `rack-utf8_sanitizer` gem to provide middleware to strip invalid utf-8 from request URIs and headers before they're processed by Rails, but it's currently unclear whether that would have any undesirable side-effects.
* | Merge branch 'issues/1457-close-change-request-without-email' into ↵Louise Crow2014-10-30-16/+26
|\ \ | | | | | | | | | rails-3-develop
| * | Remove redirect to trailing slash URL.Louise Crow2014-10-30-6/+1
| | | | | | | | | | | | | | | Introduced in 4f501309ade230f65f4ba45e1d0161e89587d755 but no longer needed as we don't proxy the admin interface.
| * | Allow closure of a change request without sending an email.Louise Crow2014-10-30-10/+25
| |/
* | Merge branch 'code_tidying' into rails-3-developGareth Rees2014-10-29-0/+124
|\ \
| * | Add ChangeEmailValidator specGareth Rees2014-10-29-0/+124
| | |
* | | Merge branch 'fix_transient_locale_integration_errors' into rails-3-developLouise Crow2014-10-28-7/+22
|\ \ \ | |/ / |/| |
| * | Use factories, not fixtures, in integration spec.Louise Crow2014-10-28-7/+22
| | | | | | | | | | | | Removes the dependency on fixtures having been loaded.
* | | Merge branch 'issues/1778-send-message' into rails-3-developGareth Rees2014-10-17-7/+34
|\ \ \
| * | | Remove now-unused OutgoingMessage#send_messageGareth Rees2014-10-17-4/+7
| | | | | | | | | | | | | | | | Models should not send emails
| * | | Extract initial and followup sending from modelGareth Rees2014-10-17-3/+27
| | | |
* | | | Merge branch 'spam_address_routing' into rails-3-developGareth Rees2014-10-14-2/+2
|\ \ \ \
| * | | | Add admin prefix to spam_addresses resourcesGareth Rees2014-10-10-2/+2
| |/ / /
* | | | Merge branch 'issues/1830-batch-request-user-filter' into rails-3-developGareth Rees2014-10-14-2/+14
|\ \ \ \ | |_|/ / |/| | |
| * | | User profile option to filter requests by statusGareth Rees2014-10-14-2/+14
| |/ / | | | | | | | | | | | | Filters on `latest_status` because filtering by `status` searches all states a request has ever been in.
* | | Merge branch 'issues/222-category-editing-add-order-interface' into ↵Louise Crow2014-10-14-57/+733
|\ \ \ | |/ / |/| | | | | rails-3-develop
| * | fixup! Use RESTful routing.Louise Crow2014-10-09-7/+7
| | |
| * | Require heading and category in PublicBodyCategoryLink.Louise Crow2014-10-09-1/+16
| | | | | | | | | | | | Update default factory accordingly.
| * | fixup! Remove old PublicBodyCategories calls.Louise Crow2014-10-09-1/+1
| | |
| * | Remove old PublicBodyCategories calls.Louise Crow2014-10-09-1/+1
| | | | | | | | | | | | | | | Add deprecation notice to draw attention to any place where PublicBodyCategories is called from themes.
| * | Don't migrate categories automatically.Louise Crow2014-09-26-10/+0
| | | | | | | | | | | | | | | It becomes confusing in the test environment, better to have a clean script.
| * | Don't require a category descriptionLouise Crow2014-09-26-0/+20
| | | | | | | | | | | | | | | Some existing themes don't use one for categories like 'misc' and that seems reasonable usage. Add some specs for the things we do validate.
| * | Use RESTful routing.Louise Crow2014-09-26-73/+74
| | |
| * | Create module to clarify what code is just for migrating from files.Louise Crow2014-09-25-2/+2
| | |
| * | fixup! Use translation tables for PublicBodyCategory and PublicBodyHeadingLouise Crow2014-09-25-2/+2
| | |
| * | fixup! Basic category admin screenLouise Crow2014-09-25-8/+0
| | |
| * | fixup! Replace existing PublicBodyCategories functionality with db models ↵Louise Crow2014-09-24-85/+101
| | | | | | | | | | | | PublicBodyCategory and PublicBodyHeading
| * | fixup! New heading associations should be added on category create.Louise Crow2014-09-24-7/+4
| | |
| * | fixup! Add actions for reordering public body headings and categories.Louise Crow2014-09-24-12/+35
| | |
| * | fixup! Add actions for reordering public body headings and categories.Louise Crow2014-09-24-20/+24
| | |
| * | fixup! Remove dependence on default public bodies.Louise Crow2014-09-24-88/+48
| | |
| * | fixup! Validation of display order, default setting callbacks.Louise Crow2014-09-24-44/+49
| | |
| * | New heading associations should be added on category create.Louise Crow2014-09-22-0/+16
| | |
| * | Add actions for reordering public body headings and categories.Louise Crow2014-09-22-1/+89
| | |
| * | Remove dependence on default public bodies.Louise Crow2014-09-22-16/+84
| | | | | | | | | | | | Seems like this could trip us up later. Use factories instead, they're more clearly associated with tests.
| * | Validation of display order, default setting callbacks.Louise Crow2014-09-22-14/+74
| | |
| * | Allow deletion of public body categories with associatied bodieslizconlan2014-09-22-9/+1
| | |
| * | Add display order to public body categories and headingslizconlan2014-09-22-53/+112
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 04:36:23 +0000