Commit message (Collapse) | Author | Age | Lines | |
---|---|---|---|---|
* | Add message index to attachment files | Louise Crow | 2013-09-16 | -3/+3 |
| | | | | | So that files attached to different messages with the same name and url_part don't get overwritten. | |||
* | Make test ruby 1.8.7 compatible. | Louise Crow | 2013-09-16 | -1/+1 |
| | ||||
* | Use earlier factory_girl syntax | Louise Crow | 2013-09-16 | -26/+33 |
| | ||||
* | Exclude hidden responses when calculating old_unclassified | Louise Crow | 2013-09-16 | -11/+19 |
| | | | | | Make old_unclassified_params method consistent with last_public_response_event and associated methods. | |||
* | Only include public messages in who_can_followup_to | Louise Crow | 2013-09-16 | -1/+57 |
| | ||||
* | Add public criteria for message event access methods | Louise Crow | 2013-09-16 | -60/+120 |
| | | | | | | | get_last_response_event and get_last_outgoing_event are used in various places to determine which events to link to, use in queries etc. Restrict them to refer to the last publicly visible event of the relevant type, and rename them to make that clear. | |||
* | Hide hidden outgoing messages in download. | Louise Crow | 2013-09-16 | -1/+97 |
| | ||||
* | Fix spec descriptions | Louise Crow | 2013-09-16 | -2/+2 |
| | ||||
* | Add prominence fields and cache expiry to outgoing admin | Louise Crow | 2013-09-16 | -13/+95 |
| | ||||
* | InfoRequestEvent.indexed_by_search consults OutgoingMessage. | Louise Crow | 2013-09-16 | -1/+18 |
| | ||||
* | Move indexed_by_search to MessageProminence | Louise Crow | 2013-09-16 | -2/+23 |
| | | | | Add some tests that it's working on the outgoing message model. | |||
* | Add some tests for user_can_view? on outgoing message. | Louise Crow | 2013-09-16 | -0/+52 |
| | ||||
* | Add hidden messages for outgoing message. | Louise Crow | 2013-09-16 | -0/+38 |
| | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb | |||
* | Allow creation of multiple public bodies in one test. | Louise Crow | 2013-09-16 | -2/+4 |
| | | | | | Add some sequences to make sure that we don't get validation errors on unique fields. | |||
* | Convert specs to factories from fixtures. | Louise Crow | 2013-09-16 | -52/+48 |
| | | | | | | Conflicts: spec/integration/view_request_spec.rb | |||
* | Add a test of incoming message hiding with PDF conversion | Louise Crow | 2013-09-16 | -0/+59 |
| | ||||
* | Clean up the test download dir after use. | Louise Crow | 2013-09-16 | -0/+4 |
| | ||||
* | Add expectations for admin and requester. | Louise Crow | 2013-09-16 | -5/+17 |
| | ||||
* | Give incoming message a body attachment | Louise Crow | 2013-09-16 | -3/+5 |
| | | | | By default, give an incoming message a body attachment. | |||
* | Restore the download for hidden requests | Louise Crow | 2013-09-16 | -24/+58 |
| | | | | | | This was disabled for hidden requests as the download was by redirect, allowing people who have not been authenticated to conceivably access the download. We'll be moving to send_file instead, so can restore it. | |||
* | Fix problem with integration session reuse. | Louise Crow | 2013-09-16 | -0/+7 |
| | | | | | The third (and any subsequent) session created shares a session id with the second without this explicit reset. | |||
* | Make absence of htmltopdf converter more explicit. | Louise Crow | 2013-09-16 | -47/+52 |
| | | | | We're testing the code path where there is no converter here. | |||
* | Make external request download spec more specific. | Louise Crow | 2013-09-16 | -4/+5 |
| | ||||
* | Remove hidden incoming messages from correspondence.txt | Louise Crow | 2013-09-16 | -0/+34 |
| | | | | | | | Adds a spec for what we want to see - no message text in correspondence.txt, and no attachments. Refactors the simple_correspondence templates to make it clearer that these are doing the same job as the html.erb ones, for text. | |||
* | Split up translated messages. | Louise Crow | 2013-09-16 | -5/+11 |
| | | | | | | | | | Each part is a separate sentence, and we're going to reuse some of them in the text view. Conflicts: spec/integration/view_request_spec.rb | |||
* | Give incoming message factory a body text. | Louise Crow | 2013-09-16 | -9/+21 |
| | | | | Also, store an event for the incoming message. | |||
* | Rewrite download spec | Louise Crow | 2013-09-16 | -47/+76 |
| | | | | | Make it an integration spec so we don't need to touch the internals so much. | |||
* | Allow an actual user to be passed to the login method. | Louise Crow | 2013-09-16 | -1/+5 |
| | ||||
* | Replace fixture-based spec with factory-based equivalent. | Louise Crow | 2013-09-16 | -10/+6 |
| | ||||
* | Use expectation for hidden responses more generally. | Louise Crow | 2013-09-16 | -9/+9 |
| | ||||
* | Fix request in spec for hidden attachments not being viewed. | Louise Crow | 2013-09-16 | -2/+15 |
| | | | | | Add another spec for the same behaviour when an incoming message is hidden. | |||
* | Add new code and specs for hiding attachments. | Louise Crow | 2013-09-16 | -1/+106 |
| | ||||
* | Refactor expectation into a method | Louise Crow | 2013-09-16 | -6/+8 |
| | | | | Remove expectation of pdf contents - we're looking at the raw file. | |||
* | Use a real pdf file for foi_attachment factory. | Louise Crow | 2013-09-16 | -2/+2 |
| | ||||
* | Refactor prominence specs to use factories not fixtures. | Louise Crow | 2013-09-16 | -117/+133 |
| | ||||
* | Clarify specs. | Louise Crow | 2013-09-16 | -5/+5 |
| | | | | They refer to the case where the request itself is hidden. | |||
* | Add the meat of the update action. | Louise Crow | 2013-09-16 | -0/+70 |
| | ||||
* | Add a simple edit action and template | Louise Crow | 2013-09-16 | -5/+28 |
| | ||||
* | Make some simple factories for real objects. | Louise Crow | 2013-09-16 | -0/+33 |
| | ||||
* | Shorter route names and paths | Louise Crow | 2013-09-16 | -2/+2 |
| | ||||
* | Slightly nicer action names. | Louise Crow | 2013-09-16 | -5/+5 |
| | ||||
* | Move incoming message admin to its own controller. | Louise Crow | 2013-09-16 | -76/+106 |
| | | | | | Make specs that depend on multiple controllers and models interacting integration specs. | |||
* | Move outgoing message admin actions to their own controller. | Louise Crow | 2013-09-16 | -12/+23 |
| | | | | Eventually this should use standard RESTful routing. | |||
* | Don't index hidden and requester_only incoming messages. | Louise Crow | 2013-09-16 | -0/+64 |
| | ||||
* | Add prominence reason. | Louise Crow | 2013-09-16 | -5/+7 |
| | | | | | | | | | | Conflicts: app/views/request/_incoming_correspondence.html.erb Conflicts: spec/integration/view_request_spec.rb | |||
* | Adding prominence_reason to IncomingMessage. | Louise Crow | 2013-09-16 | -0/+2 |
| | ||||
* | Add messages for hidden and requester_only states. | Louise Crow | 2013-09-16 | -4/+93 |
| | | | | Different messages for normal user, requester and admin user. | |||
* | Refactor some common setup steps in integration tests into a DSL. | Louise Crow | 2013-09-16 | -60/+114 |
| | | | | Add a failing test for what should happen on request hiding. | |||
* | Refactor common logic about prominence and access. | Louise Crow | 2013-09-16 | -1/+1 |
| | | | | Move it into the Ability module. | |||
* | Add a method to ask whether a user can view an incoming message. | Louise Crow | 2013-09-16 | -0/+57 |
| |