aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeLines
* Merge branch 'release/0.6.6' into wdtkLouise Crow2012-09-20-22/+76
|\
| * Ensure non-nil publication_scheme in fixtures so that example data worksMatthew Landauer2012-09-18-0/+3
| |
| * Paginate the timeline to allow it to render in a reasonable amount of time. ↵Louise Crow2012-09-13-12/+33
| | | | | | | | In order to avoid sorting large numbers of objects in order to get the right order of combined events across the two model types, get the overall order first from the database and then populate the slice we're interested in.
| * Allow InfoRequest.find_old_unclassified to accept an offset param so it can ↵Louise Crow2012-09-13-0/+8
| | | | | | | | be used in conjunction with pagination.
| * Add appropriate counter caches for public body fixtures.Louise Crow2012-09-12-5/+9
| |
| * Memoize the notes_without_html calculated value for the life of the model ↵Louise Crow2012-09-12-0/+14
| | | | | | | | instance - no need to keep applying the regex if called multiple times e.g. in a view.
| * Move default value setting for publication scheme to before_save callback ↵Louise Crow2012-09-12-5/+9
| | | | | | | | rather than after_initialize - after_initialize accessing of the variable value was causing eager loading of public body translations to happen after the first attribute access, resulting in n+1 queries for translations.
* | Merge branch 'develop' into wdtkLouise Crow2012-09-12-22/+80
|\|
| * Merge branch 'develop' of ssh://git.mysociety.org/data/git/public/alaveteli ↵Louise Crow2012-09-11-20/+72
| |\ | | | | | | | | | into develop
| | * Add a since_date parameter to the API feedRobin Houston2012-09-10-0/+15
| | |
| | * Update other testsRobin Houston2012-09-07-20/+25
| | | | | | | | | | | | Update the other API tests to take account of the changed error behaviour.
| | * Merge branch 'develop' of github.com:mysociety/alaveteli into developRobin Houston2012-09-04-0/+4
| | |\
| | * | API errors should be JSONRobin Houston2012-09-04-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API was returning Rails (HTML) errors for certain error conditions, which is inconvenient because it makes it difficult for the client to extract the error message. This patch changes add_correspondence to return JSON errors (still with suitable HTTP status codes) for two common exceptional conditions, and adds tests.
| * | | Bugfix in spec.Louise Crow2012-09-11-1/+1
| | | |
| * | | Ignore spacing differences when checking generated SQL, use caps for SQL ↵Louise Crow2012-09-11-9/+24
| | | | | | | | | | | | | | | | reserved words.
| * | | Record a status update by someone other than the request owner as a request ↵Louise Crow2012-09-11-2/+12
| | | | | | | | | | | | | | | | classification.
| * | | Add some more efficient methods for getting old unclassified request counts, ↵Louise Crow2012-09-11-11/+40
| | |/ | |/| | | | | | | and random sets of small numbers of old unclassified requests.
| * | Quote name correctly in query. Fixes #598.Louise Crow2012-09-04-0/+4
| |/
* | Add a since_date parameter to the API feedRobin Houston2012-09-10-0/+15
| |
* | Merge branch 'master' into wdtkRobin Houston2012-09-07-20/+57
|\ \
| * | Update other testsRobin Houston2012-09-07-20/+25
| | | | | | | | | | | | Update the other API tests to take account of the changed error behaviour.
| * | Merge branch 'master' of git.mysociety.org:/data/git/public/alaveteliRobin Houston2012-09-06-671/+1585
| |\| | | | | | | | | | | | | Conflicts: spec/controllers/api_controller_spec.rb
| * | API errors should be JSONRobin Houston2012-09-06-0/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API was returning Rails (HTML) errors for certain error conditions, which is inconvenient because it makes it difficult for the client to extract the error message. This patch changes add_correspondence to return JSON errors (still with suitable HTTP status codes) for two common exceptional conditions, and adds tests. Conflicts: spec/controllers/api_controller_spec.rb
* | | Merge branch 'release/0.6.5' into wdtkLouise Crow2012-08-30-69/+158
|\ \ \ | | |/ | |/|
| * | Merge branch 'feature/repo-move' into developLouise Crow2012-08-30-46/+46
| |\ \
| | * | Update references to point to the mySociety repo.Louise Crow2012-08-29-46/+46
| | | |
| * | | Give external request request event unique timestamp to fix spec failure ↵Louise Crow2012-08-29-1/+1
| | | | | | | | | | | | | | | | caused by two requests with identical last event timestamps.
| * | | Update spec for previous commit.Louise Crow2012-08-29-2/+2
| | | |
| * | | Fix for the case where an external request has no user_nameLouise Crow2012-08-29-11/+21
| | | |
| * | | Fix basic admin interface in case where external request without username is ↵Louise Crow2012-08-29-0/+5
| | | | | | | | | | | | | | | | being displayed.
| * | | Add fixture for an external request without a username.Louise Crow2012-08-29-12/+44
| |/ /
| * | Add headings and by_heading accessors to PublicBodyCategories to allow ↵Louise Crow2012-08-28-0/+42
| | | | | | | | | | | | easier access to headings and to tags associated with a particular heading.
* | | Merge remote-tracking branch 'origin/release/0.6.4' into wdtkLouise Crow2012-08-23-300/+634
|\| | | | | | | | | | | | | | | | | Conflicts: app/views/request/show.rhtml spec/models/info_request_spec.rb
| * | Now that external request followups can't be made and status can't be ↵Louise Crow2012-08-23-12/+104
| | | | | | | | | | | | updated, don't show links or text that suggests they can.
| * | Don't allow status updates on external requests from the front end interface ↵Louise Crow2012-08-23-259/+331
| | | | | | | | | | | | | | | | | | (they can still be changed from the admin interface). Final part of fix for #562.
| * | Don't show 'requester only' actions for an external request.Louise Crow2012-08-23-0/+12
| | | | | | | | | | | | Part of the fix for #562.
| * | Don't error on a request to followup an external request.Louise Crow2012-08-23-0/+16
| | | | | | | | | | | | Partial solution to #562.
| * | Handle the case where someone wants to add an annotation to a successful ↵Louise Crow2012-08-23-0/+20
| | | | | | | | | | | | | | | | | | external request. Fixes #563.
| * | Merge branch 'release/0.6.3' into developLouise Crow2012-08-22-86/+360
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: app/controllers/admin_public_body_controller.rb app/views/admin_public_body/import_csv.rhtml spec/controllers/admin_public_body_controller_spec.rb spec/models/info_request_spec.rb
| * | | Use user_name to supply the user name for an internal or external request in ↵Louise Crow2012-08-22-32/+42
| | | | | | | | | | | | | | | | | | | | | | | | the simple correspondence template used when a full request zip is downloaded. Fixes #561.
| * | | Fix admin links in the case where an external request is viewed by an admin ↵Louise Crow2012-08-22-0/+12
| | | | | | | | | | | | | | | | user.
| * | | Don't send comment alerts for external requests.Louise Crow2012-08-22-0/+10
| | | |
| * | | Re-enable testing of comment links in emails.Louise Crow2012-08-22-7/+2
| | | |
| * | | Clearer formatting of global fixtures list.Louise Crow2012-08-22-7/+21
| | | |
| * | | Fix comment typo.Louise Crow2012-08-22-2/+2
| | | |
| * | | Allow external requests to be hidden from the admin interface.Louise Crow2012-08-22-0/+50
| | | |
| * | | Don't pass a page param of less than one through to Xapian, treat it as a ↵Louise Crow2012-08-21-1/+8
| | | | | | | | | | | | | | | | param of 1. Fixes #557.
| * | | Merge branch 'develop' of github.com:sebbacon/alaveteli into developLouise Crow2012-08-20-5/+24
| |\ \ \
| | * | | Fail with NotFound if request slug doesn't existRobin Houston2012-08-20-1/+20
| | | | | | | | | | | | | | | | | | | | Closes #554.
| | * | | Fix another testRobin Houston2012-08-20-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Is there actually any point in tests of this sort? It is not testing that anything works as intended, only that a particular SQL string is passed to the database -- and surely the only way that string could have been discovered for test purposes was essentially to copy it from the code under test. It seems to me that the only real function of a test of this sort is to make it more difficult to modify the code under test.